Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp407255pxm; Wed, 2 Mar 2022 18:36:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxC/cC4G2BoJmn1+VbYz+qCUn2325WehB9RRCTZlMJASbx9uQLixbyQMCDvmR7djEua48RX X-Received: by 2002:a63:d607:0:b0:378:c5ee:50c0 with SMTP id q7-20020a63d607000000b00378c5ee50c0mr12599618pgg.333.1646274966750; Wed, 02 Mar 2022 18:36:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646274966; cv=none; d=google.com; s=arc-20160816; b=DbCWfv3OcSHmjg/0NR9k9N4IgNy054OYv8ojxQZKXaDqyQRdnDQ9ZCZyJb14v7L99Y B3/zEEu1cRfrc1shWEw9C9FSjfw5krw8SfVB0icDd7Mm339vf8DSH4ac2rodQKT1NvwP N7qiJXPoGmTAfky7vI9823ocHRcC2nYDVOTThCDJnwA2CbtzujKsO5J2Ae/bFhDS0lZO SpecgxztMo5R3VKmOUcBgBeoOgOCXJw9LnbPjmne9XTifbcOVZ7lJn4nJM0uFKxim90y 4IRa1xRN+wjwih2/wyXfniuD8gLykBXQ/ta3FEdApprvCoUpOB8/fNOTVPrHJ6CiWMwd hwyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=aF9XLvD9hWpFw+NKklK1sIzRoJfmjTG+zLqETPl2pZA=; b=0Br/MTQ+hHMfKFVyB26JbGKwiodHXWVJwd+ivRyLWx2eNQ1fu1jfte9wdY/eckLb8A Sa1dC8+XpN2xZomaPYHtRGndMU0f2ruBrdrHE2oNaNwG4go2S2IvskF0ENWc5ScsEu3c 4+T2NOLbzKk1bpX59TWPFO8RGiodh68ZDEB6rooESQr3SH3llJBGYlifA3twFm9dFGi0 9/CXTmTDLlXBhvrZGtChkyCm7/g2v9YFmY8mxAtklLRKVJ4qypoCD2S80tAw+gytSILT uoes/M2AEv5+ax77ZxQHmL+q+DHJ6P8JpAycaqcOYmTbC5Xc8YhXVCf+uzBA8Nem7M5f w23w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m63-20020a632642000000b003658e16ecdesi752660pgm.664.2022.03.02.18.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 18:36:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 945A246165; Wed, 2 Mar 2022 18:30:19 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbiCCCbA (ORCPT + 99 others); Wed, 2 Mar 2022 21:31:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbiCCCa7 (ORCPT ); Wed, 2 Mar 2022 21:30:59 -0500 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E013DBB2 for ; Wed, 2 Mar 2022 18:30:14 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0V65YKLq_1646274611; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V65YKLq_1646274611) by smtp.aliyun-inc.com(127.0.0.1); Thu, 03 Mar 2022 10:30:11 +0800 From: Yang Li To: alison.wang@nxp.com Cc: stefan@agner.ch, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err() Date: Thu, 3 Mar 2022 10:30:10 +0800 Message-Id: <20220303023010.61403-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index 7a503bf08d0f..20895ea79739 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev) } fsl_dev->irq = platform_get_irq(pdev, 0); - if (fsl_dev->irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (fsl_dev->irq < 0) return fsl_dev->irq; - } fsl_dev->regmap = devm_regmap_init_mmio(dev, base, &fsl_dcu_regmap_config); -- 2.20.1.7.g153144c