Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932718AbXBSVxK (ORCPT ); Mon, 19 Feb 2007 16:53:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932720AbXBSVxK (ORCPT ); Mon, 19 Feb 2007 16:53:10 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:26015 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932719AbXBSVxJ (ORCPT ); Mon, 19 Feb 2007 16:53:09 -0500 Date: Mon, 19 Feb 2007 16:50:48 -0500 From: Chris Mason To: "Ananiev, Leonid I" Cc: Zach Brown , linux-aio@kvack.org, linux-kernel@vger.kernel.org, Benjamin LaHaise , Suparna bhattacharya , Andrew Morton Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event Message-ID: <20070219215048.GI6133@think.oraclecorp.com> References: <20070219203527.20419.68418.sendpatchset@tetsuo.zabbo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.12-2006-07-14 X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 24 On Mon, Feb 19, 2007 at 11:58:16PM +0300, Ananiev, Leonid I wrote: > > while triggering EIO in invalidate_inode_pages2_range() > ... > > With this patch aio-stress sees -EIO. > > Actually if invalidate_inode_pages2_range() returns EIO it means > that internal kernel synchronization conflict was happen. > It is reported to user as hardware IO error. > Iteration in synchronization process could be performed instead. > aio is not responsible for this particular synchronization. Those fixes (if we make them) should come from other places. The patch is important to get aio error handling right. I would argue that one common cause of the EIO is userland error (mmap concurrent with O_DIRECT), and EIO is the correct answer. -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/