Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 22:23:25 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tom Zanussi <zanussi@kernel.org>
Subject: Re: [PATCH 2/2] tracing: Add sample code for custom trace events
Message-ID: <20220302222325.7ad12606@rorschach.local.home>
In-Reply-To: <20220303104006.56820d801a9ba6c4d5da8c93@kernel.org>
References: <20220302032414.503960863@goodmis.org>
        <20220302032820.877781830@goodmis.org>
        <20220303104006.56820d801a9ba6c4d5da8c93@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 3 Mar 2022 10:40:06 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> > +static struct trace_event_call sched_switch_call = {
> > +	.class			= &sched_switch_class,
> > +	.event			= {
> > +		.funcs			= &sched_switch_funcs,
> > +	},
> > +	.print_fmt		= SCHED_PRINT_FMT,
> > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 15, 0)
> > +	.module			= THIS_MODULE,
> > +#else
> > +	.mod			= THIS_MODULE,
> > +#endif  
> 
> I think this example code doesn't need to care about older kernels. 

Oops, I thought I got rid of all the mod versions :-p  I had this
working on a 5.4 kernel that we were going use, and there was a bunch
more of these in my original code. I'll nuke this on v2.

> 
> Others looks good to me.
> 
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> Hopefully, it is more helpful if there are more comments for other developers. :-)
> (and usage comments too)

Actually, I was thinking of coming up with a bunch of helper
functions/macros to make this less complex. But yeah, it needs a bunch
of comments before it can be accepted.

Thanks a lot for the review!

-- Steve