Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v4 4/4] net: tun: track dropped skb via
 kfree_skb_reason()
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     dsahern@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
        joao.m.martins@oracle.com, joe.jin@oracle.com, edumazet@google.com
References: <20220226084929.6417-1-dongli.zhang@oracle.com>
 <20220226084929.6417-5-dongli.zhang@oracle.com>
 <20220301185021.7cba195d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
 <ca81687c-4943-6d58-34f9-fb0a858f6887@oracle.com>
 <20220302111731.00746020@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
 <e3bc5ac4-e1db-584c-7219-54a09192a001@oracle.com>
 <20220302212122.7863b690@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
From:   Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <8daa7abc-c78f-3895-996f-6bb5ead5049a@oracle.com>
Date:   Wed, 2 Mar 2022 21:55:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <20220302212122.7863b690@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmtBNE92ZFNoc0UzUEw3K2g1b2xPemh6b2NDVW5MN0ZDOCtITjgwUE9WaUlQ?=
 =?utf-8?B?R21lQjhPMWlRVVN6UjJNS2Fwc3VEeU1PL09HUXYvM2V2aVFvTnE3b1I1SE42?=
 =?utf-8?B?YmVZZEFQN29zUmgyWjI5OXMyQ1lBNGZldFRUdE1qVFpEdUJJNXhwb0oyQ1Ey?=
 =?utf-8?B?ekpVdnNySkpiWFMwUXdtamNnUEx6dXJKWlZnMWdXdjlVbzE3S1RvSkdxYS94?=
 =?utf-8?B?RVE3aUhwWjZsNjZVWjhUZWhTVVpwTk9uUXRSWXd4Zm9tMWRQcTNKbnRvZHU5?=
 =?utf-8?B?SFVvTllWUnlKd3dmRDJtdGNlV2hmeG5vTVcwaDlWY0V2K1l3di9rU2w2MFhj?=
 =?utf-8?B?dWVQVjFVQzRuZ2Z5elE3cHl0QkRNK1FCSEoyMmh1YU5HZ2J4N21kK3JZSVY5?=
 =?utf-8?B?NURLVFJNSWxhci8walMySm1DN3J2WmtuWm1oclRrb2hZRVUwdnA5eFJ6Vkhz?=
 =?utf-8?B?b2NlYllNSG5zV29NVVVPbmxvTjdaNU1CeEhmWVNKSHJVd2N5cWJ3NTZuTWlL?=
 =?utf-8?B?QUtDdVJFUVlIaXlIZmFtZHN2aVBDVmdZdHRDSnliMGxiUkpJblMzZmhZNWYw?=
 =?utf-8?B?WitFL3ZNTWJ4cUdXVUlDZ0JXYU1PMlpDcWVHTVFhTkVERUlvSGwrQldiMHMx?=
 =?utf-8?B?UU1BckhoYi9kMEhZTW9oZUhnU256UkZJRUtNN0sxcG1vVndxaGtWNjRPL3Rl?=
 =?utf-8?B?eWRtMytJTGhnQmdUbkptYkNBdXpwM3l1a0VDQkluT3BtNW9oVmdVekFCZzZK?=
 =?utf-8?B?cGRiSUs2WlQ0WG9MRElWaWIxeXEybFIyWkxlbldvSWNGYjlJT29GSmNjM2gv?=
 =?utf-8?B?NXcyZ0hqdEtlaW5iRWdFYjU1a3VQTjJOU3VYR0Fjb3ZIbTNyWFZmUVRDdWdY?=
 =?utf-8?B?UGp4bWJ0WHAvWWhyR251dzZqZTVWaHNHRGlqQ1ZoSWxOdjNPM0dqUWxFR2Ux?=
 =?utf-8?B?OVlyY3BITzB1ZlJkSmVmckduYmFPMjBTYkN6MVlFVGJIUnozTmJYMUhZSmlw?=
 =?utf-8?B?VmdNaWhpeFgzT0orU1pqRmZiYWtGdTN0WTNNVDRadjVFZGVBZFpuM2xIK1g1?=
 =?utf-8?B?SVVJZDlxS2hqZEZRRHAveVc5MjhKWnF4RTZHVUF4Ym9UUUVmT21VTVhqVmFU?=
 =?utf-8?B?cU45RVFxSElmbEpEQkd1V04vQkpRbCtnSjhTcGk2K2JJdWowVUhaWnVrenJY?=
 =?utf-8?B?YjNnUzY4VVd6R3Z2NGRXZmV5Nk1TODhJSU1nWXBTUUtEcGptdWg4cndBQVpx?=
 =?utf-8?B?dFZsVXdpVXBKdVdYWjdIangxNEFPSkllRS9KdTdOOHZETGphb0ZNTThraXIr?=
 =?utf-8?B?V0Y3KzI0bmVwdXZjUHFvalo0bmVNWVU2bkJkUjlmYjlVclVkSjlwQVNKK2Rs?=
 =?utf-8?B?VzIxaHB5UWZTWXEzNks5b0lVRmZYRmZMUXdpRWd5dm9oazY3RXpXZ09ERE9V?=
 =?utf-8?B?cmwza0FUZThuMWxZczErdUJ3TFE5dzVlZXZCaVA0cUxYODZPWndWWTg0aWhn?=
 =?utf-8?B?MEsvaHl4THZkRzN4M1dRRVBHejlGb0hxdVY1VXBQekJMeU5Mdi9KSHRpUlB5?=
 =?utf-8?B?VStGT1BsT3JZUzFXUXh5ZGYyam5VOGZLZ0xhQUZidmw5aEMxVTgzQk04eVMx?=
 =?utf-8?B?UFZpTEhnaGFNeWlvNW8zNzFlQVZJL0FxMnNSaG1jaXVVaENEdllteGV4R29N?=
 =?utf-8?B?MEticWpKSkxBN3lxeUVMWWNldDFEU1d5SDJ2bDEyRGFJS2F4ZkxwdkZnNDVt?=
 =?utf-8?B?NHJNaDIwWE5UbXVvVFppZ3gySGZxSnRNY0lvbExOUy9LTFdxRzM3SWc2eHJ4?=
 =?utf-8?B?SWR3dU1tVi9NbEoxOXRNblNJTTdvYjZ6N2gzVHI1ajRSYlRnNkFvZjY4TXpk?=
 =?utf-8?B?a0FCdCsySG5meEl3L25hZW0yZGk1c1plMC91WUxUUVF3MXcrMW9ZbWhkSUhz?=
 =?utf-8?B?eFh2TytSWWVPMkpBY0MyN05qa1U3MDlmcFlDSWNMYkZyT2FldWFHM0FHZXln?=
 =?utf-8?B?bnM3eXRsV0owTTY0T1FVSlZGTmV5VldxMnd4SlF5clA2TVVzK1MrU1JHMGFm?=
 =?utf-8?B?dTFMVzV4eFlPT0dIb1BKU05DWEp6NytIQS9WcGRQR1BDSXdEekY4bzFlMGhI?=
 =?utf-8?B?TU4rcGNnb0RhY0JVQVAycmR4cml4dUdPQlc1dVUzcjdvalpTY04xWWE2azl0?=
 =?utf-8?Q?wzAwbSd0NdVc+fmQ0HjihkcD9BYn6+F2RXg+CSC8ORte?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9158837e-03e2-4af4-7f35-08d9fcda6356
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 05:55:15.1818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VHiezOTDoZN43zu1mtddYr+99fzh1EZR9eI7gHkFgb24fAcdiYfg2z8QZWEjYzrAnWrw2rXFVm4UDgjNh+pF5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2144
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203030028
X-Proofpoint-GUID: m48DiFQBzOS86xzGJcpqt3c8SvQmxREx
X-Proofpoint-ORIG-GUID: m48DiFQBzOS86xzGJcpqt3c8SvQmxREx
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub,

On 3/2/22 9:21 PM, Jakub Kicinski wrote:
> On Wed, 2 Mar 2022 14:21:31 -0800 Dongli Zhang wrote:
>>> because of OOM" is what should be reported. What we were trying to
>>> allocate is not very relevant (and can be gotten from the stack trace 
>>> if needed).  
>>
>> I think OOM is not enough. Although it may not be the case in this patchset,
>> sometimes the allocation is failed because we are allocating a large chunk of
>> physically continuous pages (kmalloc vs. vmalloc) while there is still plenty of
>> memory pages available.
>>
>> As a kernel developer, it is very significant for me to identify the specific
>> line/function and specific data structure that cause the error. E.g, the bug
>> filer may be chasing which line is making trouble.
>>
>> It is less likely to SKB_TRIM more than once in a driver function, compared to
>> ENOMEM.
> 
> Nack, trim is meaningless.
> 

I will use SKB_DROP_REASON_NOMEM.

Thank you very much!

Dongli Zhang