Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40be865d-17c0-80a3-e434-73317c5bff70@linux.alibaba.com>
Date:   Thu, 3 Mar 2022 15:12:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4 2/2] io_uring: Add support for napi_busy_poll
Content-Language: en-US
To:     Olivier Langlois <olivier@trillion01.com>,
        Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>
Cc:     io-uring <io-uring@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <cover.1646142288.git.olivier@trillion01.com>
 <aa38a667ef28cce54c08212fdfa1e2b3747ad3ec.1646142288.git.olivier@trillion01.com>
 <29bad95d-06f8-ea7c-29fe-81e52823c90a@linux.alibaba.com>
 <4f01857ca757ab4f0995420e6b1a6e3668a40da5.camel@trillion01.com>
 <4af380e8-796b-2dd6-4ebc-e40e7fa51ce1@linux.alibaba.com>
 <81a915d3-cf5f-a884-4649-704a5cf26835@linux.alibaba.com>
 <a549f23857b327131c621dbc9a029a91401967c8.camel@trillion01.com>
From:   Hao Xu <haoxu@linux.alibaba.com>
In-Reply-To: <a549f23857b327131c621dbc9a029a91401967c8.camel@trillion01.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/3/22 06:03, Olivier Langlois wrote:
> On Wed, 2022-03-02 at 14:38 +0800, Hao Xu wrote:
>>>>
>>>> If that is what you suggest, what would this info do for the
>>>> caller?
>>>>
>>>> IMHO, it wouldn't help in any way...
>>> Hmm, I'm not sure, you're probably right based on that ENOMEM here
>>> shouldn't
>>>
>>> fail the arm poll, but we wanna do it, we can do something like
>>> what
>>> we do for
>>                               ^---but if we wanna do it
> My position is that being able to perform busy poll is a nice to have
> feature if the necessary resources are available. If not the request
> will still be handled correctly so nothing special should be done in
> case of mem alloc problem.
Exactly what I meant.
>
> but fair enough, lets wait for Jens and Pavel to chime him if they
> would like to see something to be done here.
Agree.
>
> Beside that, all I need to know is if napi_list needs to be protected
> in __io_sq_thread with regards to io worket threads to start working on
> a v5.

Sorry for the delay, was stuck in other things. We definitely need

lock in this case too. It should be several lines code, super appreciate

if you could add it.


Thanks,

Hao

>
> I'll look into this question too...