Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 22:32:48 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Wong Vee Khee <vee.khee.wong@linux.intel.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>, netdev@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        pei.lee.ling@intel.com
Subject: Re: [PATCH net 1/1] net: stmmac: Resolve poor line rate after
 switching from TSO off to TSO on
Message-ID: <20220302223248.2492658e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220228111558.3825974-1-vee.khee.wong@linux.intel.com>
References: <20220228111558.3825974-1-vee.khee.wong@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 28 Feb 2022 19:15:58 +0800 Wong Vee Khee wrote:
> From: Ling Pei Lee <pei.lee.ling@intel.com>
>=20
> Sequential execution of these steps:
> i) TSO ON =E2=80=93 iperf3 execution,
> ii) TSO OFF =E2=80=93 iperf3 execution,
> iii) TSO ON =E2=80=93 iperf3 execution, it leads to iperf3 0 bytes transf=
er.

IMHO the iperf output can be dropped from the commit message,=20
it doesn't add much beyond this description.

> Clear mss in TDES and call stmmac_enable_tso() to indicate
> a new TSO transmission when it is enabled from TSO off using
> ethtool command

How does the TSO get disabled I don't see any ...enable_tso(, 0, )
calls in the driver? And why call enable in fix_features rather=20
than set_features?