Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <48646a29-9cd1-f1c7-9230-453aadbfb07f@amd.com>
Date:   Thu, 3 Mar 2022 08:09:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH -next] drm/amdgpu: clean up some inconsistent indenting
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, airlied@linux.ie
Cc:     daniel@ffwll.ch, Xinhui.Pan@amd.com, alexander.deucher@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220303015215.92536-1-yang.lee@linux.alibaba.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220303015215.92536-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnNZcFdsTDZYV3pmdTVHbllWL250dEdaMVR2b0h2WkFvbDdzMUxuVFpaYTdt?=
 =?utf-8?B?RjlnTUFWQXI2MjJzVThIRzV0b2ZsSy9FR09xeUNSZGVaME9vSUYwQzNzdFVo?=
 =?utf-8?B?RnhIdS9pSDRZQWFzR1BIYjJoVitrekRvYTZScEliQXc5d29qUStJaWplQkFO?=
 =?utf-8?B?S2Ercll1cHp5bU1ab0g1aU9LVjJ2RWZOenNpOXhIcENleFdSdlJSa0VOc0R1?=
 =?utf-8?B?SkN0emM5T3I2eS9vWGY1aUEvM1RLNlA2a1RaUGNWVzlnYWFXVzc1MnU3bUZQ?=
 =?utf-8?B?c0Z4blBhQVhhUUorcUdhVDVFWmlIMmQwSThTbzBWTEFuOXlYUW9nOGZFWUxQ?=
 =?utf-8?B?ZGJtSmxPbk1mazRkVEc1Ti9EbmpheGdYVnZsdnZMbnJpTXRJamdCcEVnT3hs?=
 =?utf-8?B?eUlqS2lja2M4VW43ck12SUhuRXcxNjhkWFVQdzRRSjlrQW5nMWwvS0xJaTMz?=
 =?utf-8?B?SGZrZC95cjl3T2w0NmZsUnZUUVhqMnkvcVNxNjM4L0QwUkU3bjJxSHNad1Vt?=
 =?utf-8?B?OWt1b2gzeFpKMHM4WGdBSVBNcjdoUmNqNmZybXByL29rUklidDQvQW0xQ01V?=
 =?utf-8?B?V3hKMHZCeTFkcndRRkpyME16N2FTckN4VG9zMTd0S21ieDlOSkJ3REp2RDB2?=
 =?utf-8?B?cVY4T2paeE1hd1ZIN1FDS2dNQXR2NVBhbVRnMFQwdDdnakloemtwQ2pHTW92?=
 =?utf-8?B?bVdlaUZxSVVONmRTVzJIeEhISFRLdTdsSWJQa0xCTGptV1lKOUloSEhsb21h?=
 =?utf-8?B?MHQyWUpYRUFsdkVtMzFhdmtjb2xKYUJjYzVLWXg0czFXa2dvbUY5bFVYUTVt?=
 =?utf-8?B?ZlRRUTJWbDlDMWxMVDd2cVQvVkgwM1pqa0lPdUFqdmhzdjZLak9idWlwQW5D?=
 =?utf-8?B?QXlGS2s3Ri8zaXRPVGhwQXBZaXo3dlBVMkg3ZmpUS0xMSzF3RDcxblNOOFFE?=
 =?utf-8?B?MkpnQ2R5NUtnNkxjT1YxcHh4b0Q2NWVIa2g2SUJhNm9ZSkU0TUdsMDBTVnc0?=
 =?utf-8?B?VGdFMkFtSVJSVVU2VndxWnF4KzZWa1FiaDhKRnpjcWRNSHVRRitwbHZuaEg3?=
 =?utf-8?B?dHB1Nm51WUR1MmNDYTVHQ2puL0Ivc1dsR0V2ZlFvaExBR0piQlNRZDNUbmEx?=
 =?utf-8?B?WTM2anM5SjB6ZDhLQUIwcGRUOXB4TWgvZTRFcW53eFFuaFZWZlJUV284anZC?=
 =?utf-8?B?QkNqWnR2V0RmRzZuK28zZkwwekY2V0wrYkl4dmxFN1ZxVThEVzhlVU1LMnE4?=
 =?utf-8?B?MjRHQVBmVXdiL3JZcDVINm1GY1A0UTdlVnRwVWNBS2ZIQUN4VTZqNmtlYkhs?=
 =?utf-8?B?SnN5ZlAwbUJyRVRaSGdjSmZVVHBscVVtRUd0dUJRQk01bFRJWkVYU3RpNmJ0?=
 =?utf-8?B?NzV3c1QvNlc2ZmJqYmx0bTVmTDJ3SkNqM3NqVHphaXBQVnM4QWp5dDJoRmFG?=
 =?utf-8?B?aWRGN1NpcXJwWEZUaWlSV0NSQWxHWTJPczFrVEhoZlViVWwraWdUeWJYTDR5?=
 =?utf-8?B?MXUxSVd1czZwNjY2TUVLY2FSNFl0RjhSbFc4NGNKYzdzdUU5dkZXNFlETUxm?=
 =?utf-8?B?QW9xdkVSd0NtVkMwRTJON3ZGOVVmNTJyR2tkQkYySnlGRW9qS25hN0ZzeGty?=
 =?utf-8?B?aWpVSDFXSS9FRU9FbFlxM0l1Q1JHVTNMV2MreUhiZTFUQ21jRFUwek0xMGdL?=
 =?utf-8?B?RStyMGgwWm9ZK281NTYrNUYwaHdGcXo0djQyVE1kTzhKWFFsRThyMCtpSTIr?=
 =?utf-8?B?RGFZeXRNQ1ZVMGpCMWg3NFkyT3ZIN1NweFhGSDdheGN3K0hYamhjRERHSkta?=
 =?utf-8?B?T1RmNzFlYlNDM2o5SmdUbHAwdk5aZ1QrUmx4emgvdThLZE5rOExVclBmMUhS?=
 =?utf-8?B?bnBnMlNmQmhIM1JKMDBKcTJqUVRJTThEWUxZajN6K3Q4cE1NdWU1R3hwMGlm?=
 =?utf-8?B?Zy9NQUgrZmozY2ZaS3hmdkFsaVQzYm9OQllIQUlId1NrUzJwSndCSm9WQzV0?=
 =?utf-8?B?dkwzOGVmZzZDYSsxRlVKR05CMTJ3RFc4SGg0MHFNOWFYYm5keHFscUszODYz?=
 =?utf-8?B?MUVNbUw0RWJiWVlVTW16YllPOHkzWnhobGJONmZlVExkT2dZYU1DQU5KV0dY?=
 =?utf-8?Q?cwNs=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2316bb9-d550-409d-2338-08d9fce4c415
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 07:09:32.7723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pWPKRs0U7p+uwhFLT0vI/BI7GAvdeZM32TmyI1euVio7HmgRzTvwkbDCuhDY3gId
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2343
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 03.03.22 um 02:52 schrieb Yang Li:
> Eliminate the follow smatch warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:413 amdgpu_get_xgmi_hive()
> warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 91817a31f3e1..4ff6e06babca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -410,14 +410,14 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
>   	 */
>   	if (adev->reset_domain->type != XGMI_HIVE) {
>   		hive->reset_domain = amdgpu_reset_create_reset_domain(XGMI_HIVE, "amdgpu-reset-hive");
> -			if (!hive->reset_domain) {
> -				dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
> -				ret = -ENOMEM;
> -				kobject_put(&hive->kobj);
> -				kfree(hive);
> -				hive = NULL;
> -				goto pro_end;
> -			}
> +		if (!hive->reset_domain) {
> +			dev_err(adev->dev, "XGMI: failed initializing reset domain for xgmi hive\n");
> +			ret = -ENOMEM;
> +			kobject_put(&hive->kobj);
> +			kfree(hive);
> +			hive = NULL;
> +			goto pro_end;
> +		}
>   	} else {
>   		amdgpu_reset_get_reset_domain(adev->reset_domain);
>   		hive->reset_domain = adev->reset_domain;