Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-1ca1f3fd-1eeb-4c8d-a7e2-65851eb8002b-1646291055736@3c-app-gmx-bs69>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Rob Herring <robh@kernel.org>
Cc:     Frank Wunderlich <linux@fw-web.de>, devicetree@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Subject: Aw: Re: [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT
 bindings to yaml
Content-Type: text/plain; charset=UTF-8
Date:   Thu, 3 Mar 2022 08:04:15 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <Yh+0B+iKx1gJXXCk@robh.at.kernel.org>
References: <20220301152421.57281-1-linux@fw-web.de>
 <20220301152421.57281-2-linux@fw-web.de>
 <Yh+0B+iKx1gJXXCk@robh.at.kernel.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rob,

thanks for review,

have prepared the changes based on yours and krzysztof comments

https://github=2Ecom/frank-w/BPI-R2-4=2E14/commits/5=2E17-next-20220225

(just ignore the top 2 commits) i thought i had a size-cells-error, but di=
d not get them again after reverting this part, seems they are fixed by inc=
lusion of the sata-common binding

> Gesendet: Mittwoch, 02=2E M=C3=A4rz 2022 um 19:14 Uhr
> Von: "Rob Herring" <robh@kernel=2Eorg>
> An: "Frank Wunderlich" <linux@fw-web=2Ede>

> On Tue, Mar 01, 2022 at 04:24:17PM +0100, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files=2Ede>

> > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform=2Eyam=
l b/Documentation/devicetree/bindings/ata/ahci-platform=2Eyaml
> > new file mode 100644
> > index 000000000000=2E=2Ecf67ddfc6afb
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/ahci-platform=2Eyaml
> > @@ -0,0 +1,162 @@
> > +# SPDX-License-Identifier: GPL-2=2E0
> > +%YAML 1=2E2
> > +---
> > +$id: http://devicetree=2Eorg/schemas/ata/ahci-platform=2Eyaml#
> > +$schema: http://devicetree=2Eorg/meta-schemas/core=2Eyaml#
> > +
> > +title: AHCI SATA Controller
>=20
> blank line=2E

done
=20
> > +description:
> > +  SATA nodes are defined to describe on-chip Serial ATA controllers=
=2E
> > +  Each SATA controller should have its own node=2E
> > +
> > +  It is possible, but not required, to represent each port as a sub-n=
ode=2E
> > +  It allows to enable each port independently when dealing with multi=
ple
> > +  PHYs=2E
>=20
> You need a '|' after 'description' if you want to maintain the=20
> paragraphs=2E

ok added | to all multiline descriptions

> > +
> > +maintainers:
> > +  - Hans de Goede <hdegoede@redhat=2Ecom>
> > +  - Jens Axboe <axboe@kernel=2Edk>
> > +
> > +allOf:
> > +- $ref: "sata-common=2Eyaml#"
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +        - enum:
> > +          - brcm,iproc-ahci
> > +          - marvell,armada-8k-ahci
> > +          - marvell,berlin2q-ahci
> > +        - const: generic-ahci
> > +      - enum:
> > +        - brcm,iproc-ahci
> > +        - cavium,octeon-7130-ahci
> > +        - hisilicon,hisi-ahci
> > +        - ibm,476gtr-ahci
> > +        - marvell,armada-3700-ahci
> > +        - marvell,armada-380-ahci
> > +        - snps,dwc-ahci
> > +        - snps,spear-ahci
>=20
> Install yamllint and run 'make dt_binding_check'=2E It's going to=20
> complain about the indentation=2E

you're right, i had no yamllint installed, so i have not seen these indent=
ion errors

> > +  ahci-supply:
> > +    description:
> > +      regulator for AHCI controller
> > +
> > +  clock-names:
>=20
> Group with 'clocks'

ok, already done in my tree because of krzysztofs comment

> > +  ports-implemented:
> > +    $ref: '/schemas/types=2Eyaml#/definitions/uint32'
> > +    description:
> > +      Mask that indicates which ports that the HBA supports
> > +      are available for software to use=2E Useful if PORTS_IMPL
> > +      is not programmed by the BIOS, which is true with
> > +      some embedded SoCs=2E
> > +    maxItems: 1
>=20
> A uint32 is only ever 1 item=2E Drop=2E
>=20
> IIRC, isn't the max here 0xff? Add constraints=2E

i've found it only set to 0x1 so i have currently set the maximum to 0x1, =
is this ok?
If some higher value is needed binding needs to be touched=2E=2E=2E

> > +
> > +  reg-names:
> > +    maxItems: 1
>=20
> Group with 'reg'=2E

ok

> > +patternProperties:
> > +  "^sata-port@[0-9a-f]+$":
> > +    type: object
>=20
>        additionalProperties: false

ok added to my tree

and needed to add phy-names because some marvell boards using this

arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot=2Edt=2Eyaml: sata=
@540000: sata-port@1: 'phy-names' does not match any of the regexes: 'pinct=
rl-[0-9]+'

now i have only the marvell-errors about incomplete sata-port subnode (wit=
hout phy/target-supply) like i mention in the patch=2E=2E=2Ehow to proceed =
with this?

regards Frank