Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <88d86ba1-65ba-0c95-6d46-c064eaa62856@kaod.org>
Date:   Thu, 3 Mar 2022 08:57:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 10/10] ARM: dts: aspeed: Enable Dual SPI RX transfers
Content-Language: en-US
To:     Joel Stanley <joel@jms.id.au>
CC:     <linux-spi@vger.kernel.org>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        Mark Brown <broonie@kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
        devicetree <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220302173114.927476-1-clg@kaod.org>
 <20220302173114.927476-11-clg@kaod.org>
 <CACPK8XeDBCMCEO4=w7qUQxsYiFUDKPAuBhXW5Sr6=UHM_GRsWA@mail.gmail.com>
 <CACPK8Xd6VJLuWsvSjYrQ-y=yS+yR7vjdWECfsd2W9_J7e09K-A@mail.gmail.com>
From:   =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <CACPK8Xd6VJLuWsvSjYrQ-y=yS+yR7vjdWECfsd2W9_J7e09K-A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/2/22 23:48, Joel Stanley wrote:
> On Wed, 2 Mar 2022 at 22:45, Joel Stanley <joel@jms.id.au> wrote:
>>
>> On Wed, 2 Mar 2022 at 17:31, Cédric Le Goater <clg@kaod.org> wrote:
>>>
>>> All these controllers support at least Dual SPI. Update the DTs.
>>>
>>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>
>> Thanks. I'll apply this to the aspeed tree now.
>>
>> Did you also have a patch to add a second flash chip to the AST2400 FMC?
> 
> That was a reference to the discussion on the openbmc list with Tao. I
> was mistaken; the flash chips are there, but they lack the
> spi-max-frequency property.

Yes.

I will include a patch in v3 for the second flash chip of the AST2400 FMC.

Thanks,

C.

> 
>>
>>> ---
>>>   arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++
>>>   arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
>>>   arch/arm/boot/dts/aspeed-g6.dtsi | 8 ++++++++
>>>   3 files changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
>>> index 9ae67e83cf60..31e6569db97e 100644
>>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
>>> @@ -64,27 +64,32 @@ fmc: spi@1e620000 {
>>>                          flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>> +                               spi-rx-bus-width = <2>;
>>>                                  spi-max-frequency = <50000000>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@2 {
>>>                                  reg = < 2 >;
>>>                                  compatible = "jedec,spi-nor";
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@3 {
>>>                                  reg = < 3 >;
>>>                                  compatible = "jedec,spi-nor";
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@4 {
>>>                                  reg = < 4 >;
>>>                                  compatible = "jedec,spi-nor";
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> @@ -100,6 +105,7 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> index c3e0a8e13c8a..29bf017899b6 100644
>>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>>> @@ -66,18 +66,21 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@2 {
>>>                                  reg = < 2 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> @@ -93,12 +96,14 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> @@ -114,12 +119,14 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
>>> index 1ad05dde19d2..ce93c56a21a7 100644
>>> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
>>> @@ -106,18 +106,21 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@2 {
>>>                                  reg = < 2 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> @@ -133,12 +136,14 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> @@ -154,18 +159,21 @@ flash@0 {
>>>                                  reg = < 0 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@1 {
>>>                                  reg = < 1 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                          flash@2 {
>>>                                  reg = < 2 >;
>>>                                  compatible = "jedec,spi-nor";
>>>                                  spi-max-frequency = <50000000>;
>>> +                               spi-rx-bus-width = <2>;
>>>                                  status = "disabled";
>>>                          };
>>>                  };
>>> --
>>> 2.34.1
>>>