Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d585748-7a41-13ca-60da-20eb4fe78374@baylibre.com>
Date:   Thu, 3 Mar 2022 09:07:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] clk: Use of_device_get_match_data()
Content-Language: en-US
To:     cgel.zte@gmail.com, mturquette@baylibre.com
Cc:     sboyd@kernel.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io,
        linux-kernel@vger.kernel.org, Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220303014856.2059307-1-chi.minghao@zte.com.cn>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
In-Reply-To: <20220303014856.2059307-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/03/2022 02:48, cgel.zte@gmail.com wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
> 
> Use of_device_get_match_data() to simplify the code.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
> ---
>   drivers/clk/clk-oxnas.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
> index 78d5ea669fea..cda5e258355b 100644
> --- a/drivers/clk/clk-oxnas.c
> +++ b/drivers/clk/clk-oxnas.c
> @@ -209,15 +209,11 @@ static int oxnas_stdclk_probe(struct platform_device *pdev)
>   {
>   	struct device_node *np = pdev->dev.of_node;
>   	const struct oxnas_stdclk_data *data;
> -	const struct of_device_id *id;
>   	struct regmap *regmap;
>   	int ret;
>   	int i;
>   
> -	id = of_match_device(oxnas_stdclk_dt_ids, &pdev->dev);
> -	if (!id)
> -		return -ENODEV;
> -	data = id->data;
> +	data = of_device_get_match_data(&pdev->dev);
>   
>   	regmap = syscon_node_to_regmap(of_get_parent(np));
>   	if (IS_ERR(regmap)) {


Acked-by: Neil Armstrong <narmstrong@baylibre.com>