Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Mar 2022 19:35:25 +1100 (AEDT)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Tom Rix <trix@redhat.com>
cc:     Joe Perches <joe@perches.com>,
        Bart Van Assche <bvanassche@acm.org>,
        kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
        shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, nathan@kernel.org,
        ndesaulniers@google.com, Konrad Kleine <kkleine@redhat.com>,
        megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid
In-Reply-To: <8dd05afd-0bb9-c91b-6393-aff69f1363e1@redhat.com>
Message-ID: <233660d0-1dee-7d80-1581-2e6845bf7689@linux-m68k.org>
References: <20220127151945.1244439-1-trix@redhat.com> <d26d4bd8-b5e1-f4d5-b563-9bc4dd384ff8@acm.org> <0adde369-3fd7-3608-594c-d199cce3c936@redhat.com> <e3ae392a16491b9ddeb1f0b2b74fdf05628b1996.camel@perches.com> <46441b86-1d19-5eb4-0013-db1c63a9b0a5@redhat.com>
 <8dd05afd-0bb9-c91b-6393-aff69f1363e1@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Wed, 2 Mar 2022, Tom Rix wrote:

> >>> Long term, it would be good have a reliable way to automatically fix 
> >>> either new files or really broken old files.
> >> That's really a maintainer preference no?
> >>
> >> Especially so for any automation.
> >
> > In practice everything is up to the maintainer.
> >
> > If some maintainer wants fix their formatting then clang-format should 
> > just work
> >
> > It isn't likely they will have time to hand fix every file.
> 
> A follow up issue in the clang project has been raised by Konrad, here
> 
> https://github.com/llvm/llvm-project/issues/54137
> 

Why request a "leave" option for every style rule? Why not just a "leave" 
option for the most contentious rules?

The response from the developers that anyone who wants to leave existing 
code unmolested by certain rules should "wake up and smell the coffee" is 
obnoxious, IMO.

Presumably clang-format must grow until it has sufficient program logic 
and config options to cater to every exception to every rule. How long 
will that take? Some carefully chosen "leave" options might make the 
program much more useful in the near term.

> Tom
> 
> 
> >
> > Tom
> >
> >>
> >>
>