Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp661888pxm; Thu, 3 Mar 2022 01:55:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7rZMOpo6ps9hrjTZEew5Ey4uIZEf/ik579JXamV/ktlYWDxt9ZKPnyk3ONyeCdEcTLgO4 X-Received: by 2002:a17:90a:eb07:b0:1be:f354:940a with SMTP id j7-20020a17090aeb0700b001bef354940amr4393889pjz.43.1646301318417; Thu, 03 Mar 2022 01:55:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646301318; cv=none; d=google.com; s=arc-20160816; b=FD7MhQ6PLeTqGGcndMthgSF1KjtyAySAwxjLQp/j1onHiLoTDS3s7MeAnsTxVH4Vwq jiBNQYluyPAI3dkvaKXYclN210H8uvyLF/TAOlbDoI03iHXuUsH4hP35i4SckQXkM1FP Y1slM3juluGROaluhJhiRquzoWrOg6DdGqJc2LpJVv//Ol0MW/0Ogd9+dXVEed/7JtGP yDrDEwv3aKan0ONyPFZUIeFfyppgONHkdH9C49eFkJL9kRypSVd24ZobAJ+b/zJW9jpw sLgUSvozB3j4iJ3NZItCUsEbtorZOxP7EuJRbpMxdH6KjAdoAtm11UjhyacK9Rw8+0os WsTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wGP1+9ihzrwQ9TfcPvJ6NeCN2rcP2AuXJCzLDDqjD7I=; b=cjKmgknyrSZNMxHs/o1WPi2yHqa1WffrRJJ88RdcwFF4c38DM7hFSDZkUwcCoWID8r IZ1cFHIFakC7ARxyqi+zm/+0edEaKwcdOwNf1Njj6mkkcbNEhuoYhsr+s8ZZF13KlZUz Wl1X3U4ZKudjTj9t94bXyymASdiVnrpcMHCKR1VsmzYPPOas0MSRuwa+IiLR3am6RI48 RQvYESGSZtGNCfInenT1LBSOEnAcudVeyhRPgTvZqA51QucnhuOPspMpMn5TBhcw6lPo cLCEalYtdQgBnaRIqBh955ndWV3ftIX5c4Q+Sjxh32S/PpWRBhNegULjvfzm5E1IIHyS cXZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020a656b82000000b00378faa5cbdesi1680067pgw.72.2022.03.03.01.55.03; Thu, 03 Mar 2022 01:55:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231814AbiCCJPh (ORCPT + 99 others); Thu, 3 Mar 2022 04:15:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbiCCJPf (ORCPT ); Thu, 3 Mar 2022 04:15:35 -0500 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D57CF119855; Thu, 3 Mar 2022 01:14:49 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0V67Be.m_1646298882; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0V67Be.m_1646298882) by smtp.aliyun-inc.com(127.0.0.1); Thu, 03 Mar 2022 17:14:47 +0800 From: Jiapeng Chong To: davem@davemloft.net Cc: kuba@kernel.org, gustavoars@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] net: ethernet: sun: Remove redundant code Date: Thu, 3 Mar 2022 17:14:40 +0800 Message-Id: <20220303091440.71416-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because CAS_FLAG_REG_PLUS is assigned a value of 1, it never enters these for loops. Clean up the following smatch warning: drivers/net/ethernet/sun/cassini.c:3513 cas_start_dma() warn: we never enter this loop. drivers/net/ethernet/sun/cassini.c:1239 cas_init_rx_dma() warn: we never enter this loop. drivers/net/ethernet/sun/cassini.c:1247 cas_init_rx_dma() warn: we never enter this loop. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/sun/cassini.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 947a76a788c7..153edc5eadad 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -1235,19 +1235,6 @@ static void cas_init_rx_dma(struct cas *cp) */ readl(cp->regs + REG_INTR_STATUS_ALIAS); writel(INTR_RX_DONE | INTR_RX_BUF_UNAVAIL, cp->regs + REG_ALIAS_CLEAR); - if (cp->cas_flags & CAS_FLAG_REG_PLUS) { - for (i = 1; i < N_RX_COMP_RINGS; i++) - readl(cp->regs + REG_PLUS_INTRN_STATUS_ALIAS(i)); - - /* 2 is different from 3 and 4 */ - if (N_RX_COMP_RINGS > 1) - writel(INTR_RX_DONE_ALT | INTR_RX_BUF_UNAVAIL_1, - cp->regs + REG_PLUS_ALIASN_CLEAR(1)); - - for (i = 2; i < N_RX_COMP_RINGS; i++) - writel(INTR_RX_DONE_ALT, - cp->regs + REG_PLUS_ALIASN_CLEAR(i)); - } /* set up pause thresholds */ val = CAS_BASE(RX_PAUSE_THRESH_OFF, @@ -3509,9 +3496,6 @@ static inline void cas_start_dma(struct cas *cp) if (N_RX_DESC_RINGS > 1) writel(RX_DESC_RINGN_SIZE(1) - 4, cp->regs + REG_PLUS_RX_KICK1); - - for (i = 1; i < N_RX_COMP_RINGS; i++) - writel(0, cp->regs + REG_PLUS_RX_COMPN_TAIL(i)); } } -- 2.20.1.7.g153144c