Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Mar 2022 12:54:32 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>, kbuild-all@lists.01.org,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Florian Eckert <fe@dev.tdt.de>
Subject: Re: [PATCH v1 1/1] docs: process: submitting-patches: Clarify the
 Reported-by usage
Message-ID: <20220303095432.GB9912@kili>
References: <20220127155334.47154-1-andriy.shevchenko@linux.intel.com>
 <87o83xrwk9.fsf@meer.lwn.net>
 <YfPzNNvK8Sy8YmGW@casper.infradead.org>
 <Yff9xoh873aEikY4@hovoldconsulting.com>
 <YfgBi9dn8LI8d/bo@smile.fi.intel.com>
 <YfgSpArfoL9LUaBO@hovoldconsulting.com>
 <YfgninPOaJhq7dsZ@smile.fi.intel.com>
 <Yfj0lb50vS3ssrsn@hovoldconsulting.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yfj0lb50vS3ssrsn@hovoldconsulting.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UY3pQI++Tiiu8n0rvs/BD8rvcbIiJeLvwTjLCltFvwEFrN4j3UNNdDfNCguX?=
 =?us-ascii?Q?hHyCtPeE40tQt8Ebc969D9KWGzt8RlF4wuzWftbDYLJ5mN4SaKaBplooCi55?=
 =?us-ascii?Q?4IWLFlZVpBRVOfbTLTVZRtbGb9elIgkU88/lg58ZxNyXz0QmEXtQCQGk9J1g?=
 =?us-ascii?Q?zZjSCd1eB6AwJtcWwHiMJdyslJ83jrFI8Yx4gsLFgcEqFDqRLhczX6Qte/eH?=
 =?us-ascii?Q?QZQf/dCVuzWH+GrXoYWCdORviJpN0+faVvCfdfruUFDy0reZUIYq42/xN0gF?=
 =?us-ascii?Q?UdDKHg+bsTVwz+qXMxzZfBjAYlDkCLJIepxB4IRQTi5p0W5/5mZswuoUdMRJ?=
 =?us-ascii?Q?YeshXYTNC0whex0cKPJdTHf71kn9eBdrXRI2vKOz1sseKilmNaYXQupqGppY?=
 =?us-ascii?Q?r0Ssgiff2A0wV3OfUeP/zygdyVefBRVWamTvUSd5Mtejnbael/ZLsvR9zcrY?=
 =?us-ascii?Q?fCktiM4soFewy10WR58t0frYwcoP7hLLxC/PnGNTtpSFNlsf2d9tNmZBNhom?=
 =?us-ascii?Q?SkLartGdqhT5Dg4dqBmWASM4c2BH8yIp4y8VXqMgj7Ebu0nEzYmNy7VNp3eO?=
 =?us-ascii?Q?gWkPsaQaZ4dr5DrUElnShKkoO2xmNQk9fdgyMMR0idL37TJVVwTLVnO3G79U?=
 =?us-ascii?Q?c5XWb1xpMunwlbJZX7AB7xHwGTAeRhNc6b1LMGmAlmydd9Pw4Aby//KL+gCS?=
 =?us-ascii?Q?4kMksbZLgcMjR2ilXidH7KxTL8SHT328wvGLQfenqlMAemsPAzXCDykZLsRg?=
 =?us-ascii?Q?QvWwUi1Co3zRz2Dxmx91vwHBwJXDo0FmJi3JoZ6+9uDo/KPEt5PpPaYdiBpA?=
 =?us-ascii?Q?xr2LNEy4QMK+88M8UDnIqTQAV4pdJWciqIHjTTlkkf6uCJNBK2FpRqplm/zv?=
 =?us-ascii?Q?vJd3MfyKQx25O3DDetGUwSdHnkciUCurcy5bwmEszdKfSFfdQLsMLMFjLrQD?=
 =?us-ascii?Q?94pkQmYPM7Gcu4ZrdWTAOTcQxASpkx5JDLCc+NxT1bcgEOQ6xNE+oVyV14lH?=
 =?us-ascii?Q?PL6LfayjKAQUl+E9YkOqLoHBX05WA0fMGVOMcCe1KgZ9zaAllR+8HPIanB3B?=
 =?us-ascii?Q?C/nBrIAHXlAuXzsC4G+7/9SfmJzBls+XCxIVKSW99u6nMwA8w0eonZHWn4Eo?=
 =?us-ascii?Q?S/lBl+3w7mUkm9lgaDgf+E2SYMQ+Tg7VKEpD9VLY8BWmKA5rVVUOhyM3E42H?=
 =?us-ascii?Q?Nfp25GBk6uSqs5TVEe82zI3LDw7OdgXThQ8ZNuJ3nnzuQrvRPpsuoYPsq7gI?=
 =?us-ascii?Q?l4P6/DhYxXFI08S5SnZ+ihJumMGGQHA3EAlk+hruYxOG2ZDU7KlOtZpP5VGU?=
 =?us-ascii?Q?uTtQYPr6TrowZZdaWJVHEfccbo+5lLsrA3lvBjU7QWCJpK3icZzcpePGt030?=
 =?us-ascii?Q?cn4uJIDAPufouKrVo8K/wWuFWyumJdUDb52vwXa7l9eD9/dQyzdJOvwtwJ4b?=
 =?us-ascii?Q?ZUzt3/aX6Iz3Z98UbjZlL3XvzBEQCtilQS8alJN2eu0AaAkJQ9rjR/AvjbhT?=
 =?us-ascii?Q?AMrD+5dN6h3BFD//7k1+YuPXf0vule8fA+Mm5MuW37nECAC7F1sDNEnbXxH2?=
 =?us-ascii?Q?L6SSOde9wrcrCz294V3QrFreM8loT6yJbRv5eQLMl4zCHVk84bE0QYrOOIXt?=
 =?us-ascii?Q?2J79n8yBndbOBsX22YbHKf7iRmIXHSfrb/Jr5W3SRrG94JNjeRQs2H1Lxrnv?=
 =?us-ascii?Q?7uuJGg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51fe4716-c233-4c2f-c903-08d9fcfbd7f0
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 09:54:44.1695
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jlaa2nBcJM0w9HkB63CCAK9uvpnXLcZT31vlLkCv59xuetZph3yFS1ehfnOSDcxsonR4A03dOV5UqVzeqpeSSns0j8SUtqSfwbxt7jykzDE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5481
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203030046
X-Proofpoint-ORIG-GUID: uHPY-0y8uYqqFLOjMYXmwYYX4oeQGxi1
X-Proofpoint-GUID: uHPY-0y8uYqqFLOjMYXmwYYX4oeQGxi1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 01, 2022 at 09:51:33AM +0100, Johan Hovold wrote:
> On Mon, Jan 31, 2022 at 08:16:42PM +0200, Andy Shevchenko wrote:
> > On Mon, Jan 31, 2022 at 05:47:32PM +0100, Johan Hovold wrote:
> > > On Mon, Jan 31, 2022 at 05:34:35PM +0200, Andy Shevchenko wrote:
> > > > On Mon, Jan 31, 2022 at 04:18:30PM +0100, Johan Hovold wrote:
> > > > > On Fri, Jan 28, 2022 at 01:44:20PM +0000, Matthew Wilcox wrote:
> > > 
> > > > > > I think this misunderstands the problem that Andy is trying to fix.
> > > > > > 
> > > > > > The situation: I write a patch.  I post it for review.  A bot does
> > > > > > something and finds a bug (could be compile-error, could be boot
> > > > > > problem).  That bot sends a bug report with a suggestion to add
> > > > > > Reported-by:.  That suggestion is inappropriate because the bug never
> > > > > > made it upstream, so it looks like the bot reported the "problem"
> > > > > > that the patch "fixes".
> > > > > > 
> > > > > > It's not unique to "new feature" patches.  If I'm fixing a bug and
> > > > > > my fix also contains a bug spotted by a bot, adding Reported-by
> > > > > > makes it look like the bot spotted the original bug, rather than
> > > > > > spotting a bug in the fix.
> > > > > > 
> > > > > > The best thing to do in this case is nothing.  Do not credit the bot.
> > > > > > Maybe add a Checked-by:, but that would be a new trailer and I really
> > > > > > don't think we need a new kind of trailer to get wrong.
> > > > > 
> > > > > It seems like the only way to fix this is to fix the bots. Adding more
> > > > > documentation is unlikely to help in this case.
> > > > 
> > > > Links to the documentation at least may clarify the point in case of a
> > > > review.
> > > 
> > > Sure.
> > > 
> > > > > Can't we file a bug to whoever is running the bots (Intel?) and ask them
> > > > > to remove the suggestion to add a Reported-by when the bot is testing a
> > > > > patch (as opposed to mainline or even -next)?
> > > > 
> > > > The granularity here is not a repo. It's a code itself and in some cases
> > > > it might be easy to distinguish new feature from the code modifications,
> > > > but when code is already there and feature is just an extension of the
> > > > existing file(s), it's hard to tell. And it might be true or not.
> > > 
> > > Not sure I understand what you're saying here. Perhaps you and Matthew
> > > are talking about different things after all.
> > 
> > I'm talking about your suggestion to fix the bots. It's not easy.
> > The problem is the same as Matthew explained.
> 
> Perhaps I'm missing something, but if you re-read Mathews description
> above, it still seems to me like the issue is that the bots are trying
> to claim credit for finding things that haven't been merged yet.
> 
> Your suggestion is to document that the bots should be ignored. My
> suggestion is to fix the bots.

Originally the kbuild bot used to not have that notice but adding it
meant that kbuild bot got a lot more visibility.  The truth is that
managers love metrics and it helps people get paid.

The whole point of kbuild-bot was to search the lists and test code
before it gets merged.  If they just waited and tested linux-next they
would get their reported by tags because most trees don't rebase.  But
we're punishing them for being better at their job.  It's a perverse
incentive.

We should create a new tag for finding bugs during review.

regards,
dan carpenter