Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <tencent_7E4716854F78B812C4FF16C83573486E1806@qq.com>
In-Reply-To: <tencent_7E4716854F78B812C4FF16C83573486E1806@qq.com>
From:   Matthew Auld <matthew.william.auld@gmail.com>
Date:   Thu, 3 Mar 2022 10:53:42 +0000
Message-ID: <CAM0jSHO=yudjZeWbVCwdVnaJ1kJ7k34unQVvyCBxTji=u3WnWQ@mail.gmail.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()
To:     xkernel.wang@foxmail.com
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
        kernel list <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 22 Feb 2022 at 13:32, <xkernel.wang@foxmail.com> wrote:
>
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrdup() is a memory allocation function which can return NULL when
> some internaly memory errors happen. It is better to check the return
> value of it to prevent further wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>