Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp730473pxm; Thu, 3 Mar 2022 03:33:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyM/oCacQA/2UpgMKDPQCcuHgpd1awH2z5PJkQiE+nHzYfIdsJJgoF0fStTEjNjQZDzqx/3 X-Received: by 2002:a05:6a00:1a0b:b0:4cf:9a9:5c5f with SMTP id g11-20020a056a001a0b00b004cf09a95c5fmr37914773pfv.45.1646307233882; Thu, 03 Mar 2022 03:33:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646307233; cv=none; d=google.com; s=arc-20160816; b=yez3bXyDQcD0NDee+uejsUfjL3aIsgPmAJx7xugMQTHQH0AiwJ4DWmoChDR6uDgpaI czFWI3T3BxT6m8ZRLAuvKRo92k0ZXzOjBOInNw7jPUa8E4jMSk6ezSMcyzGXfEPQgUmV 5j9ci5m5jBAzDnoHtr4Wj32ZHEb3B/OX9BbxkdhKjbXqWrET2feVezZ9lN8uE/KZWIES sFxGYAwQmFDhikPALgemeHa+jzm5YDinnO4K6qQ6Oc5woSXHcIYQi3z+uwoGqu1URPp6 /DlXjPuF2uznuj9c55J0zPlERvOKgrWDMlzNvMZt9qWKFbXjVyuIKbrO2FHuo5E+s9mQ N4+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ItwqajON/LrJzgljql/wbU0bQg1OV8QWQcJWne35c0c=; b=iiBB9TfRCZj1/3GSQT/WGZJ8Z5zMQ7AoC7/5WnjhN9GYBRS9tN0UTNz803fTSeOyve G3uhFwM4bxqeD+XmlUHNJjE87XXAer4yJsqxemVOaJl3r0dysb706tvEKJpSI/barcfx uB/t2bEmUnoMnouTW26wDHynynvmFhAekVg0L0dM8Kj+IkQlV2hyJ44+Jh8ABJ62lzyH YwGuSuoWEBJlnfwqxGuklRBiPaW2H8vs5IaZ6FNKNysDxm31kVQ13pTg61IqZvqQlbvO OnDbN7/yTOS/oPo00YQbOalUwMmc632qqYoCRklF9JlaAs7LH5OvWrtXCofBon82wOJk Ipiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lnYSUp0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a170902e80200b0014db0b9acf6si2050688plg.343.2022.03.03.03.33.37; Thu, 03 Mar 2022 03:33:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lnYSUp0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232360AbiCCKbw (ORCPT + 99 others); Thu, 3 Mar 2022 05:31:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232201AbiCCKbv (ORCPT ); Thu, 3 Mar 2022 05:31:51 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 222F1179A25; Thu, 3 Mar 2022 02:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646303466; x=1677839466; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wDq06r9kddhLaN6b+ChI1ivL51pnJ9aOuIAEFgqn6mo=; b=lnYSUp0qqmNSA63T6n/xfXtvIr0z3mkGz4B8Vs6jjRx8h12bnge7Dc7D 3lejfAETJQ4a7XumuwGrahBo9lda1MuYrgITu1pZZiGWBs0+A8MYMbDms zPUrt+awcBTLIcScVKhRMWt3JrjZDc3ZqEs0NSzC4+zeQKAohKjpaCmQN uAHT95PDl+xOvv3BbdS4bdG5wVPkxwJhph+Q9+MOmjNcAbSd7yHrnyBia Wvrl2HPv/fpLAIVTAllNBCtX/ZQhQtA7tzSZdLg2w8XRtQAP3PlmiGCn6 Og+ruJrDkf2YS6EnxSqKfKfEFOp1wBuxNdQmAoquX2VtO1s5ueEDSKXnZ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="253370222" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="253370222" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 02:31:04 -0800 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="545817308" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 02:30:58 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nPiio-00AjxS-JE; Thu, 03 Mar 2022 12:30:10 +0200 Date: Thu, 3 Mar 2022 12:30:10 +0200 From: Andy Shevchenko To: Tyrone Ting Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, yangyicong@hisilicon.com, semen.protsenko@linaro.org, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/11] i2c: npcm: Fix client address calculation Message-ID: References: <20220303083141.8742-1-warp5tw@gmail.com> <20220303083141.8742-4-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303083141.8742-4-warp5tw@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 04:31:33PM +0800, Tyrone Ting wrote: > From: Tali Perry > > Fix i2c client address by left-shifting 1 bit before > applying it to the data register. ... > - bus->dest_addr = slave_addr; > + bus->dest_addr = slave_addr << 1; 1. Why this is not using i2c_8bit_addr_from_msg() helper? 2. This is duplication of what npcm_i2c_master_start_xmit() does. Taking 2 into account, what is this exactly fixing? Sounds like a red herring. -- With Best Regards, Andy Shevchenko