Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] spi: cadence: fix platform_get_irq.cocci warning
Date:   Thu,  3 Mar 2022 04:50:54 -0800
Message-Id: <20220303125054.3574-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Jev8V2FqS33jJVH6mpFChuEkQhUQSlMAInlP3kfHyS+FQbtS95op0jMB3RKj?=
 =?us-ascii?Q?NH9kDrugbHD4HsF/xFxn1Ale2S6FcbzlTh3Q/hJ701nQjHKFsAUXHtMDFGtv?=
 =?us-ascii?Q?H/jxnsq1vlvbiKXTfbv4guabK0iV6jEeAMKW1uexnr77JYNs5NHwcw/Vdjn4?=
 =?us-ascii?Q?9X1PRzEuzs7+a4dqNoPHxzrgGTSVU7FxxyZ5ANcmPZyUL6hzFF6/L0wov8SH?=
 =?us-ascii?Q?Klkx5S2GP0qyfFSRN/hm6aiTGs3YTJHcjj65a062K3bdJGI69rPsd0xXbe6z?=
 =?us-ascii?Q?b+18362fe9XWREJbLdi+GFGFoj2Y+QgF4fkz1mssdHUEuYA43XXMj6o/gwNF?=
 =?us-ascii?Q?XkU+CiP01n2R9BP5vDOhT+NcndG43cWC5wApfbJ8wE22qBBRxuyCdMaVr356?=
 =?us-ascii?Q?Z7haxs7ENFPTiiWE1/41fcpC243qR79G+SpRfaECc0OtSE8GNTjP6OQAM0R9?=
 =?us-ascii?Q?aEKup7GX13EiIvEEc9PX/Be/7ldG+UVCNHzZmsdDu+PINmtOYgtwU9Svilgp?=
 =?us-ascii?Q?F8Tup9arkfLMKyBfGhGplCVjmjnBZkoOvX9SBSjyUmUJHipvZyl/smvjTKVD?=
 =?us-ascii?Q?Zyos7ukXnYHnXFTNOKd6Lu0IdE72o4IgNndbLToI8PMCAnz+2g/m2JD8ndU1?=
 =?us-ascii?Q?Fl83HqsIj8N0uPL9IxuHBLKY8SwQR6UMc06ueevSidc3IQg+9lxN2RF19vTP?=
 =?us-ascii?Q?mqrUs4BWDKOXbEn7P/egyap5TQWGvjR1majkSs4KC1FmeLyFaewEylvjRHpi?=
 =?us-ascii?Q?v0oTW9l4H7m2LfzYFdvL07uT6NeQ8lEe6ktWkaqNN7mR6ANX+XThubJ8ZfDD?=
 =?us-ascii?Q?1Ao8N6kQgvWRxVfLfSui1Tk9v7mLUYdt/PpqWtl8hB25BoR10qP1dluz+50l?=
 =?us-ascii?Q?Wwyd7zPQ/kkha9gJqdSMpE9DNX9WXsnkcXB7O/gbPTSATskqbZLoHC13cM0j?=
 =?us-ascii?Q?65i8n502trhYm/rYKHkCg7O+if/ZaOtYF79DADHN9QZ7309gqLEmiwPulP6C?=
 =?us-ascii?Q?w+uS9rctFgpDFkN771kzzVfvk3TpEanEiaVpcmZV0EKwSoCPl+Huob3USwXH?=
 =?us-ascii?Q?l+/TZwqlg6O/t1w3yx+tosQuskHbDmHVats0PNAiZ8S+Q495mDYlxfE9ta+f?=
 =?us-ascii?Q?p+R30Up4XBXyKtAwwf72x4je4K2NTLvjzGGZ5PRpdtcqMjeV1Ab59XG19VH5?=
 =?us-ascii?Q?PNuaS/nPnkcqTdhYjggk9ykjqEV5yf8ss9I+el9FwqK3gQw4SxBeVOgcyrwJ?=
 =?us-ascii?Q?uU+XOzWm7YFj9jNBsEzCaBwcH2zq1KUcg9zLxr4HD+GwetmVPPyTv9Qa5hNa?=
 =?us-ascii?Q?/MNJX91VqkZyPvdebvQK4hli8E3jvpxsyGkJVWUUiboFJkotdTOc0YLUy3Zw?=
 =?us-ascii?Q?KDdaK1+V7E5KYRFdPd7cvcDSgvpJsIrlamJtXysS7+YTBFp/W/4d1HBaJlop?=
 =?us-ascii?Q?fUyZ3ZUTDmvbfDEX9+pgFUm7C1WaFwtu2TjsS8sjGcrrNs/PQRWrFKHL8Xyk?=
 =?us-ascii?Q?3pnU+C7R0TA1+1OKkTSUdTIJIkOVDpcynjxkvjZcY28qnQpCqqyIKov24e1V?=
 =?us-ascii?Q?M+G95RoCLFPWtfUkAYfqH3dNRk9FF+sqyK2Abtu/xSH+/rIqgphlFqCuwWP9?=
 =?us-ascii?Q?psWIbWJIoIBmG/bV64MT410=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 601175c5-a52f-4069-fef2-08d9fd147b18
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 12:51:05.7607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OsTDQ1zRaiuCL9WinVB/YLAtMISfpnCoT0MrEjIXTFxCRLaaPOvQ5XCI03hG4Le42QgWJpXWlDfB5Fbb7L2utw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3869
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/spi/spi-cadence-xspi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c
index 4bc1b93fc276..3ab19be83095 100644
--- a/drivers/spi/spi-cadence-xspi.c
+++ b/drivers/spi/spi-cadence-xspi.c
@@ -578,10 +578,8 @@ static int cdns_xspi_probe(struct platform_device *pdev)
 	}
 
 	cdns_xspi->irq = platform_get_irq(pdev, 0);
-	if (cdns_xspi->irq < 0) {
-		dev_err(dev, "Failed to get IRQ\n");
+	if (cdns_xspi->irq < 0)
 		return -ENXIO;
-	}
 
 	ret = devm_request_irq(dev, cdns_xspi->irq, cdns_xspi_irq_handler,
 			       IRQF_SHARED, pdev->name, cdns_xspi);
-- 
2.17.1