Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 3 Mar 2022 07:42:43 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Chun-Tse Shao <ctshao@google.com>, devicetree@vger.kernel.org,
        frowand.list@gmail.com, jpoimboe@redhat.com,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        masahiroy@kernel.org, michal.lkml@markovi.net,
        peterz@infradead.org, robh+dt@kernel.org
Subject: Re: [PATCH v2] config: Allow kernel installation packaging to
 override pkg-config
Message-ID: <20220303074243.29ca40c2@rorschach.local.home>
In-Reply-To: <CAKwvOdkWcu5ZPADGieb1Vb+kTbfHNzFAa3FXTWC98xXtzuLwqQ@mail.gmail.com>
References: <20220302102705.15c32822@gandalf.local.home>
        <20220302193638.11034-1-ctshao@google.com>
        <CAKwvOdkWcu5ZPADGieb1Vb+kTbfHNzFAa3FXTWC98xXtzuLwqQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2 Mar 2022 13:48:01 -0800
Nick Desaulniers <ndesaulniers@google.com> wrote:

> I'm ok with this patch; a quick grep though shows a few more open
> coded instances of pkg-config.  Should we fix those up, too? i.e.
> 
> certs/Makefile:92:HOSTCFLAGS_extract-cert.o = $(shell pkg-config
> --cflags libcrypto 2> /dev/null)
> certs/Makefile:93:HOSTLDLIBS_extract-cert = $(shell pkg-config --libs
> libcrypto 2> /dev/null || echo -lcrypto)
> scripts/kconfig/gconf-cfg.sh

For this patch set, the above is probably good enough to do (and test
with a make allmodconfig).

> tools/perf/Makefile.perf
> tools/ in general

I would hold off on doing tools for a separate patch. With the
exception of objtool most of tools is not needed for the build process.

-- Steve