Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH v2] ACPI / x86: Work around broken XSDT on Advantech
 DAC-BJ01 board
From:   Mark Cilissen <mark@yotsuba.nl>
In-Reply-To: <43b0c275-e728-492b-c6a7-d054fae72117@redhat.com>
Date:   Thu, 3 Mar 2022 14:42:44 +0100
Cc:     linux-acpi@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <len.brown@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, kernel test robot <lkp@intel.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4BBB58DC-653C-4373-A5F5-9239C86C8AE8@yotsuba.nl>
References: <20220302040800.10355-1-mark@yotsuba.nl>
 <832a5b2e-d70c-f1a6-e377-7697b1eb7049@redhat.com>
 <7BD8A71A-95C7-4A10-82FD-BEAAE0B0DDE9@yotsuba.nl>
 <43b0c275-e728-492b-c6a7-d054fae72117@redhat.com>
To:     Hans de Goede <hdegoede@redhat.com>
Precedence: bulk


> On 3 Mar 4 Reiwa, at 14:38, Hans de Goede <hdegoede@redhat.com> wrote:
>=20
> Hi Mark,

Hi Hans,

> On 3/2/22 21:20, Mark Cilissen wrote:
>>>=20
>=20
> I think that there are a lot more boards that will have
> DMI_BIOS_VENDOR =3D=3D "Phoenix Technologies LTD"
> then that there are boards that will have
> DMI_PRODUCT_NAME =3D=3D "Bearlake CRB Board"
>=20
> So if you want to make the DMI match as specific as possible then
> IMHO dropping the bios-vendor match is best.

Of course, but just to clarify -- my proposal above is to drop

> DMI_MATCH(DMI_SYS_VENDOR, "NEC=E2=80=9D),

not

> DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board=E2=80=9D),

. :-)

Thanks and regards,
Mark=