Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp888701pxm; Thu, 3 Mar 2022 06:34:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW5zPIx+NmI9rlm61mLAcrAx1GeS8W4IDCuWs5Z1IXd073EOJDfas/WaZl7nMQ0tOSktza X-Received: by 2002:a05:6870:b402:b0:d3:3712:efa7 with SMTP id x2-20020a056870b40200b000d33712efa7mr4267279oap.88.1646318080779; Thu, 03 Mar 2022 06:34:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646318080; cv=none; d=google.com; s=arc-20160816; b=yQj+8uPSMhajDfmxCF+XHikoNmTNZISrqLlJfPgreCAL/4a9sVjuKCTseVlV+PORxQ uAW/nT0Yyrxdwh/9WOfbVNS6fv4lULnw7nderwMoDs6bOzMpZHyEJSfA7c+GI1XwpDzb 8eimGnpof+V7Ovmy8oGJ87oC4SE0Hf5ET45jX6CrOUmSc7OSnjnmLiEow8ltQrMdHB2y m+XpNN9JUTXvJP2WbaXP5IjRo2oENdAtmJLvQzUg8zvtmpJF64dfyVTT7P8XLXRW1r6P +w5iVWOmJcMRxtjo4zBPNyfWRAhgOJsfVnHJrn0OPsfSNeDzPXFx0a2PJWiqnoouXri8 2eFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FEVhRqa2ocuKXeElJ1GV1u7yPCnknSobAGsnmju/L8Q=; b=wr62NZr2IqP/GMJUDGbSMDeU+U58rEbMZ871zz6q7DL+/QSQ/mcbqmNDFiF+OKRUYv sqYN3PA369z1b2x6gW8xjgrJPowR2g85vInAANI4tWMSmJTFlKCzbCo6LxnUp21ovvXp phMOIrUghwpzlbaM7CACgLpdypwvPA/yBpHOq6bfOau0RXVuL1CAlDzY6Md6lxddBHFJ W/djzYj/jjbfrQGu8NK4Rs3EWu6IFtHTuF8Fe130pPHGH0hin2nu/T7VRWAFXxa2LxRb 6FsA5CfWuvQUr6B+d85luM6tILkJ930qhcZMSgtG8u129lLqi99aEOz75o9+F4I3A1eC fLgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GyK4t2LU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h3-20020a9d6f83000000b005af43f98977si1328779otq.126.2022.03.03.06.34.22; Thu, 03 Mar 2022 06:34:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GyK4t2LU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233730AbiCCNif (ORCPT + 99 others); Thu, 3 Mar 2022 08:38:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiCCNie (ORCPT ); Thu, 3 Mar 2022 08:38:34 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD64DE2EB; Thu, 3 Mar 2022 05:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FEVhRqa2ocuKXeElJ1GV1u7yPCnknSobAGsnmju/L8Q=; b=GyK4t2LUht31zC1Z6nUue7H8w/ Q/7L17Z2aC/7NT7JzSGTEOn/NQyH1q1I6oLaU9Usc73YL1fBIl8Q09jKMusLp5fHJdV4BLFRNx5Xr UaMqqcRlfc71q/moX4k2wR8I/w8iqGbE5hPJBxqA64L25MiTwWkc5XY+shoUllXWAFQGZ3giG1Bfd tDav4bKlGo+bj6oimX7t2i6FrIX0KwshXQgKPhQptCUzjot4J/qt+gtzlTbgaROPqXeoc3y/NfpT/ atUwfWFrt+ifBtojbO7PsNCPZx9H8H3KMNAU+PEgQlzG4z36mUPbreH/Z4aHysPz6c5T06HDP+NAq wHWm9IVQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPle5-006W8k-DL; Thu, 03 Mar 2022 13:37:29 +0000 Date: Thu, 3 Mar 2022 05:37:29 -0800 From: Christoph Hellwig To: Christophe Leroy Cc: Aaron Tomlin , Daniel Thompson , "mcgrof@kernel.org" , "pmladek@suse.com" , "cl@linux.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "atomlin@atomlin.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" , "jason.wessel@windriver.com" Subject: Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> <20220228234322.2073104-14-atomlin@redhat.com> <20220302161917.gx5icfszakoye4uh@maple.lan> <20220302203153.3kcmwu662szf3drt@ava.usersys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 08:56:23PM +0000, Christophe Leroy wrote: > Do we really want to hide the 'struct list_head modules' from external > world ? > > Otherwise we could declare it in include/linux/module.h ? I'd just move the trivial code that uses it from kernel/kdb/ to kernel/module/ as it is tied to module internals and just uses the KDB interfaces exposed to other parts of the kernel.