Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abdc4d16-b2b4-6343-39d6-9bc48e8be43b@gmail.com>
Date:   Thu, 3 Mar 2022 14:43:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        linux-power <linux-power@fi.rohmeurope.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Code Kipper <codekipper@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>
References: <CACRpkdZmax=QpwnfgOJOR-5P3wTyKegaDn=VvhVOYz_AChc7bw@mail.gmail.com>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: Question on expiring HRtimer in-kernel
In-Reply-To: <CACRpkdZmax=QpwnfgOJOR-5P3wTyKegaDn=VvhVOYz_AChc7bw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Linus,

On 3/1/22 14:19, Linus Walleij wrote:
> I have a problem with a premature expiring HRtimer.
> 
> The HRtimer hrtimer_set_expires_range() is used in two places in
> the upstream kernel:
> kernel/futex/core.c
> drivers/power/supply/ab8500_chargalg.c
> 
> Now I am testing the code in the latter, and it has seen some
> bitrot since merged in 2012. Maybe it was correct at one point.
> The timer is started like this:
> 
>      hrtimer_init(&di->safety_timer, CLOCK_REALTIME, HRTIMER_MODE_ABS);
> (...)
>      hrtimer_set_expires_range(&di->safety_timer,
>          ktime_set(timer_expiration * ONE_HOUR_IN_SECONDS, 0),
>          ktime_set(FIVE_MINUTES_IN_SECONDS, 0));
>      hrtimer_start_expires(&di->safety_timer, HRTIMER_MODE_REL);
> 
> What the author wanted to achieve is a very definitive callback in one
> hour relative to now +/- 5 min, and that is one hour later in the
> physical world,
> as this deals with battery charging.
> 
> However sometimes this fires almost immediately rather than in an hour.
> 
> My first thought is to pass HRTIMER_MODE_REL also to init as
> hrtimer_set_expires_range() could make things happen immediately
> if we have ABS set, but this is all just intuitive.
> 
> Any hints? Better ways to create a definitive event in one hour?
> 

_a lot_ of water has been flowing in the Oulu river since I last touched 
on any code like this. Unfortunately I can't go back to my old code as 
it was left in proprietary world. So no promises I am at all helpful here ;)

In any case, I remember few cases where I hit nasty issues because I 
used CLOCK_REALTIME - which (AFAIR) is subject to the time adjustments. 
NTP, GPS-time and so on can make the time tick in a strange way :) I 
guess you would have noticed if time was set when timer did expire.

Anyways, I guess the battery charging should rather be tied CLOCK_MONOTONIC.

No guarantees though - please ignore me if I make no sense. Oh, 
actually, please don't - please correct me instead :)


-- Matti