Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <edd464f1-916e-191a-3683-45b623604e4b@amd.com>
Date:   Thu, 3 Mar 2022 07:19:06 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] [RFC] ata: ahci: Skip debounce delay for AMD FCH SATA
 Controller
Content-Language: en-US
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Hans de Goede <hdegoede@redhat.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220303100453.30018-1-pmenzel@molgen.mpg.de>
 <20220303100453.30018-2-pmenzel@molgen.mpg.de>
 <0a7c8ee9-1e09-75a4-3241-883fc8540561@opensource.wdc.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <0a7c8ee9-1e09-75a4-3241-883fc8540561@opensource.wdc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVZWZUs1dktMMjRyL0xDdVFvcUVmNjA3RVhHRllaTUZkbTNuZWVPWkxRSWNW?=
 =?utf-8?B?SnJSR0kwaGlBa0xVTkNoWkNiOURFdlVRYTI0UWg3clQ5T3ZaRUlnMmdSZzFH?=
 =?utf-8?B?MHJFTzVYZHFYTUFBc1h3dWxiUVpWTldpWXU1MUh1YW1EZURmK2ltdm5IRmhl?=
 =?utf-8?B?eVlzSjZaNnVRM2Erd3ZIRXoyejZHOVZOMDZ4ZStLRTJYbFlndEJVaTg1b0Ny?=
 =?utf-8?B?TUZLME5rWTRKdUQ2aVJLVDNYL3I4SGc4Q0VPUnhCMG9iUXAvOVR3WmU0bGJB?=
 =?utf-8?B?QmVpOFh5NzJ3bWUxMkE4MVgveDMzT3c0cllnTmswajVDd1A0ejNmOGc5Rk5I?=
 =?utf-8?B?V1NhN1QzWXVJbWFyYUlBOHN6RWNTdWhhMk5BdnBCRHBpNUVBZ1RhR0xackhh?=
 =?utf-8?B?bDQyb1ZWak84NmR2N2trOEIrQkswRFVsWnJIUDF1WnhhU1NRRnpVMFdaUDBZ?=
 =?utf-8?B?SS9WVHFaQ2pmSDJJcmNZekR1bWNSOHExdUJ0SjdaMW5sL2NyYVNGdlZiME5v?=
 =?utf-8?B?YktJRUhhRW93RTh0Yy9qeTJnVk01NGRGZDhBODE4QURzNTdKUUZNN3ZubVRN?=
 =?utf-8?B?dGhmTXVlMGF1b05yckRkU1YyZ25FaWkzejE0cXhlTXkva0VUUlVOcmNhcy9Z?=
 =?utf-8?B?WHNLanRPclRCUi8rYU83ZkRPMmxnM0Y1b3l5cFZTclRZRU1FdXROUWZHbUpq?=
 =?utf-8?B?NkpnK3U3YW9YdVNBUXRCRjBjeVlNWFp0WUxldU9uY1FDb2NWMmRmSThicVFh?=
 =?utf-8?B?YVROR3ZBWFVQQUxYalB2SzVuazM5bnU0dSszdkw2VUNIYWkxUkhVTXpOVXpB?=
 =?utf-8?B?ek5nVnViWVBDNUFNL2ZEb2hNQXR0czkvckk5U1JQNi80WXNKbDE1anRxMWtU?=
 =?utf-8?B?VmFGbktuTHlHdEJjbDJtYXhjaktMcXNCbnVUNHR4eDRXVFJrL0RuWXBNRE9O?=
 =?utf-8?B?azBodGZydktUMUdHU0krVURESG5CTEVIU29RUGEweHNUdS81cC84N2k4dzht?=
 =?utf-8?B?bG9jMFFXc0Y4RHp1bzVjdHpGL1dMbmVBMGtlSVkrWjZpbjFQR1JEYzZCT1Jq?=
 =?utf-8?B?NVJGaUhMeXJtZm03cU1VOFo2ay9TYWFQZnNEemdMTnR2UXlmZ1pYQ2JZcVFL?=
 =?utf-8?B?UVBsQURYZGtDcG9ZV243dG50U0F5NVhEQ3ZiT0VEbkhIeVdHOFhnb3JFVGk4?=
 =?utf-8?B?WnNONnNreVFCVDk2Y0J5SzJvd1FVeGFaYVltckd0dWtlM2ZIbHhUa2NnRThO?=
 =?utf-8?B?ZDFmTnJqMTQrdkpvMVVEQkV2WWIzM1NodFVCZGh0Wk9zcklZcXZIT0NNUmNJ?=
 =?utf-8?B?U0FVTXJLUHNycjVucjhnYnp5ZkhyN1Brek9VQWFZK2srVkFZY2o2RVJ6d3cw?=
 =?utf-8?B?d0FIR3R1YUJUc1VOUjdQbm8rblUyR2dTOWVUbWFXUnF4L0tVcHpkdXVsZG5t?=
 =?utf-8?B?SC9BOVFjS0dOWkl3ZUtwaHRNaUpFbUtjUmFnZTFBSjJac1FCcmhHYzJjRTZu?=
 =?utf-8?B?ZXVhcEdFS1A1dWUwUEdYZzdqY3prRGJRWEVWSTYvc1ZZbnNNZEV2bTR1eENw?=
 =?utf-8?B?cnM5alQyZGx0MjQ5R2xORW43YVExRmJoMHlvaUFoNGlSL3RKNkZvWEtUbk83?=
 =?utf-8?B?Wm5xNGxQNHZ4V3dEU1JIek9xQTJKRUpmZytYL1YyaG9UVXpZSjNRYThCTzdy?=
 =?utf-8?B?WjJSTkRBazh2WCs1TExtbUNzWDB6TjdoYStPd3Z6RkdOSmIwa0p0ZHlsY3Ba?=
 =?utf-8?B?NXltK2o1a1FHVTJDbTJzejlMYjJTZ1doUnp4aXZUbFhiVzhyWTIvZGtOQnU3?=
 =?utf-8?B?cStXcWpPSGNrekcra003RnZCelZSQ0NlT2RCWWppd21sN2xDRHZpd2lSTDhC?=
 =?utf-8?B?ZXRkRk5WcE1KcVFsRkdkdk0zREtqYlI1QzlLbGtYVzc0RVF2OHlFdkhVY3ow?=
 =?utf-8?B?bnZnUUFTOU15SHhPZEgxUmJPRm1jci8zSXFoaVFwTkdDLzBHNDlaUEw1QW51?=
 =?utf-8?B?RVI5bGt0emhHYmtqbFZXMVAyVytPaElqellYdXZKVnJkcVBLREJVS2dFTy9n?=
 =?utf-8?B?MHBHRkIwcUNoQ0FpRlVrc1JYK1lpb0ZnbTNoSjJWaVdKSXNyaEcvenhGK0ty?=
 =?utf-8?B?cm53ZUYzeWtDSzIvanJ2OThDOVB5THl1ZFNsZnoyQStCUmhWSXVidTVJU3dn?=
 =?utf-8?B?M2xXQjhsVkxDT2llaGN3TEd1Nnk2UldROXNiODI4aG13TmJOeVFvQmc5QVJh?=
 =?utf-8?Q?DwBnoIjGfQ0I5vRGk3NzGFe5dJz0BPpZCGJHbcIsp4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13282db8-ac05-413b-6c15-08d9fd18646c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5157.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 13:19:05.7692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C8j0U/xFVhguBY0rMV7/IM/IzKaCx1r9IYfdWY2mY2F34cG6LXFobQtf7YeyJkruAmIQAoIGQFrSlqjyj7t21g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3775
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/3/22 06:23, Damien Le Moal wrote:
> On 2022/03/03 12:04, Paul Menzel wrote:
>> AMD devices with the FCH SATA Controller 0x1022:0x7901 do not need the
>> default debounce delay of 200 ms.
>>
>>      07:00.2 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD] FCH SATA Controller [AHCI mode] [1022:7901] (rev 51)
>>
>> So skip it, by mapping it to the board with no debounce delay.
>>
>> Tested on the MSI MS-7A37/B350M MORTAR (MS-7A37).
>>
>> To-do: Add test details and results.
> 
> Please squash this patch together with patch 1. Since you are adding a new board
> entry definition, it is better to have a user for it in the same patch (this
> avoids reverts to leave unused code behind). >
>>
>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> I am travelling so could not test this exact patch just yet, but I ran
>> something similar for several weeks already. It’d be great, if the
>> desktop and AMD folks could also give this a try.

As we are trying to drop the low power definition for 5.18, maybe can 
this wait until 5.19 so we can see if that sticks so this doesn't get 
caught up in possible reverts?

>>
>>   drivers/ata/ahci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>> index 0fc09b86a559..44b79fe43d13 100644
>> --- a/drivers/ata/ahci.c
>> +++ b/drivers/ata/ahci.c
>> @@ -456,7 +456,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>>   	{ PCI_VDEVICE(AMD, 0x7800), board_ahci }, /* AMD Hudson-2 */
>>   	{ PCI_VDEVICE(AMD, 0x7801), board_ahci_no_debounce_delay }, /* AMD Hudson-2 (AHCI mode) */
>>   	{ PCI_VDEVICE(AMD, 0x7900), board_ahci }, /* AMD CZ */
>> -	{ PCI_VDEVICE(AMD, 0x7901), board_ahci_low_power }, /* AMD Green Sardine */
>> +	{ PCI_VDEVICE(AMD, 0x7901), board_ahci_low_power_no_debounce_delay }, /* AMD Green Sardine */
> 
> Really long name, but I cannot think of anything better...
> 
>>   	/* AMD is using RAID class only for ahci controllers */
>>   	{ PCI_VENDOR_ID_AMD, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>>   	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
> 
>