Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp928213pxm; Thu, 3 Mar 2022 07:15:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFbPaFHaDFOA+aiKyIHzuetLmsyP6/Wgh47di5Us8A/M/OMlsu1WwGE9kUgYKr9+9EuJzx X-Received: by 2002:a17:902:ce8a:b0:14f:fd0e:e4a4 with SMTP id f10-20020a170902ce8a00b0014ffd0ee4a4mr37230453plg.47.1646320518592; Thu, 03 Mar 2022 07:15:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646320518; cv=none; d=google.com; s=arc-20160816; b=KS1MIZzbRsmyW52PsPaD2l2KVVyJKUEDt77Z+mkfWeDJjVRzusI9iOhDn2buYataMl kTnMFmnTV4HiYtcUBESJKR0tFhQQix1w3Ltk39IHMMlkYfW6vVMF5xayM3rEzZeSop7J hJWal2GDpUsBstC/uonz9F7GOyEItyH1feGqLqVfpvMJno8eZSGaLbW7bE+ms+XD/d+l +k6Xq16cyY5Zc8/9fjNNNkAcMT5Sc0QSqZlXooPtMn51IvBfbfmF6Pt20G6QtV4oTSBt qZ8Vk0+2BIYBbxc2cL36WuDNI5EFJ6rO59HTOn2+3HA65urW2nusS5fOcNeVChOlPzZd IY0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5c4pTCYuRwuOQvexSJv3ZrY0ewqsjXzHl0G2qACotPs=; b=m0P9imRampdd39J5C+IXHDHMX9Eme3TqVOrObtQODxnv88+mZ8hSfYHl3sJ0N6GA/r Hr2ZeM59FUpk1H6JNgXKqxfZ/oaXjn+uut4tsr6SfL09sfl0ZK4KkizBHJBW4lYFzSmB PqSuP//THIYNcma1LcBbXIJjjwEcsxCx89wY72iBb+hcfgnkrr2QLyqOx/6Jhbo+Ir7t cottnLDB7WzHLao1qXEXy7vwNjnlodJpsDqXhz7YAbf/uZtpQyf/NKG0Yw3OrKKLpLV7 tpPx71w5L30oDLzrJp/IUUIBXYJyqhxtJaJ+sGHa+0y1H2jLeWSzGV+aLXpjW+7Dk1kV yILA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=ktLkkAp6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020a65610c000000b00373dd4e83f8si2571210pgu.168.2022.03.03.07.14.59; Thu, 03 Mar 2022 07:15:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=ktLkkAp6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233697AbiCCN1M (ORCPT + 99 others); Thu, 3 Mar 2022 08:27:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233722AbiCCN1L (ORCPT ); Thu, 3 Mar 2022 08:27:11 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCA64188A2D for ; Thu, 3 Mar 2022 05:26:24 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 223CnFvX023911; Thu, 3 Mar 2022 07:26:19 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=5c4pTCYuRwuOQvexSJv3ZrY0ewqsjXzHl0G2qACotPs=; b=ktLkkAp6nXn2INvSuJdOhCT66XzVi6mh4Oaq8efaNQOwmUs1N7LtAtm/LBaZQbSNuKj0 a2nlpOpyFPW/iJFMO1plapl3ssQAIzDeAOM9taKv2H+wEVG0VwW5Kg4fFAnE8xYVjWgf XuB9VFr44ou5zd4Q8xRO0cBk8JhIjX2cIVrEwSScLXj2az0+8q6q2fKWJUWECczCK95+ 9RfP4AVo0FftwE6zkbhh+MJrG0ap+DnWGItxngJ4VSwVog7DKmWIKHOZtBGgdY2tagFt fNnfA+h8ntkvTDUkCBoqIs1gCahOP06iUOH/7BX9yVAkqA2S59RzoS/fZjeREPFuoyuX kQ== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3ejsv20bys-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 03 Mar 2022 07:26:19 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Thu, 3 Mar 2022 13:26:17 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.18 via Frontend Transport; Thu, 3 Mar 2022 13:26:17 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 3BD4D2A1; Thu, 3 Mar 2022 13:26:17 +0000 (UTC) Date: Thu, 3 Mar 2022 13:26:17 +0000 From: Charles Keepax To: Jiasheng Jiang CC: , , , Subject: Re: [PATCH] power: supply: Add missing free in free_charger_irq Message-ID: <20220303132617.GN38351@ediswmail.ad.cirrus.com> References: <20220303094322.342569-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220303094322.342569-1-jiasheng@iscas.ac.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: 78xQPOv72v0n1v4wGd3ez_R9RUHigCRX X-Proofpoint-ORIG-GUID: 78xQPOv72v0n1v4wGd3ez_R9RUHigCRX X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 05:43:22PM +0800, Jiasheng Jiang wrote: > In free_charger_irq(), there is no free for 'WM8350_IRQ_CHG_FAST_RDY'. > Therefore, it should be better to add it in order to avoid the memory leak. > > Fixes: 14431aa0c5a4 ("power_supply: Add support for WM8350 PMU") > Signed-off-by: Jiasheng Jiang > --- Acked-by: Charles Keepax Thanks, Charles