Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp962486pxm; Thu, 3 Mar 2022 07:54:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgdLewXWpbX7ZEE0xf5H66i9npPvrP8SrZNxhyTSUOQiIxVGrm0kUR2lwPaN2TwNQsuhCc X-Received: by 2002:a17:906:fb8a:b0:6ce:c3e6:2ac4 with SMTP id lr10-20020a170906fb8a00b006cec3e62ac4mr26660476ejb.40.1646322852414; Thu, 03 Mar 2022 07:54:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646322852; cv=none; d=google.com; s=arc-20160816; b=x2TKjjIXN0qiEECW+GR4TYGaHvDGxuXFG612hivjUQwMwGVy7VyKKTIx3DUaPGhwyB EE67Xa6nM2aVhixCfyRy1hKSqKRPMGiNBEDyY4TM7eXrp/eXx3Nzma1H7FdbKUTBhbg3 IcpB4xs6xzD3WYBi/Dgbww2om5ht/xq+k/5rQ8TtfX8wNO0YCPT+f5ddmzILWxWY3bbQ TMYPlNnbDBqAVTMIy0nizKXxj7pY++dE/1o/g+bEBG4xVl6/3fvAE5U5rSNcBBuyv4qI ir8R3YBIGuHxpljNxqbP+I0kv9C/xR0ohmCvzCa0HwsQEbABAXOk5z9gsk3KliXsZTAl 8/4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TBjkZF+VASeBBFI1OAc29aFrXNteY0hfl/8xpsAGj6I=; b=hzS48P306a2wL7be3QPsacNIgpumYux68jo4DDAK7lKbU1AJMtzii9DG0MTJRXuzcp I1QT80B5KOSvQZ647d6uUM2+zpVfb77xtzy8d6rfEv+GtcYU5ou3U7LgL2ra96EdHXM7 hfY3XzuTAfF9fPYqBDzvHBOKYGViNh3imV04LUtLSI5XWm/45mnrj4nnk9jb8cis4MeD E8EdaSsoQZciVs38CNoWb7RWBgdPgDhvjuqhCcIOmRuPC/j+M/Gz1GpinO6YrGBuKi8I D6nJu0UjspUsRqdE1nci0NAd698eD2kcKKO7I0synfjEW1W/TdeYH7Ve1NGlKuPNfG1j wBfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b="KB/bX83c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j4-20020a50ed04000000b0041306593696si1414431eds.456.2022.03.03.07.53.49; Thu, 03 Mar 2022 07:54:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b="KB/bX83c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234487AbiCCPhk (ORCPT + 99 others); Thu, 3 Mar 2022 10:37:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234503AbiCCPhi (ORCPT ); Thu, 3 Mar 2022 10:37:38 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5002919414F; Thu, 3 Mar 2022 07:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646321813; x=1677857813; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ktAuPeikT5yIzQagKaEvWRybAOSvIjqqN73SIJDSJFk=; b=KB/bX83c+va8zVCODtM/PFp3ciJlBIT7c806LoEhigR3z6F8kDm9UGAZ nZogSnkj/o12lgJLGgX15n2XdG29JaXqW/zcyQAS28y/JdsU2gm5fe72v ZqIOwWEFI5OVFs+upIFGsIh2p0GtXgSisYxFz/DJb5y5C/G8xft+vZryh mRIq7hV1aTs5lJmvxb6pp0cdq+Af76jIyi4/Dj5oFr4P9NPmbALU1tSTp xueb0BzcB990oNy6p6p+d+SInr/wZAl1mm+lamjyGMd/QKKGYO6eLx+76 MlZlUJoCIcNhFVhuoYa/qt0zebpil87hZnaowhzumBd8LwIjgtop/ZCPN g==; X-IronPort-AV: E=Sophos;i="5.90,151,1643698800"; d="scan'208";a="155595980" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Mar 2022 08:36:52 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 3 Mar 2022 08:36:50 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Thu, 3 Mar 2022 08:36:42 -0700 From: Eugen Hristev To: , CC: , , , , , , Eugen Hristev , Hans Verkuil Subject: [PATCH v6 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Date: Thu, 3 Mar 2022 17:36:07 +0200 Message-ID: <20220303153618.2084156-3-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303153618.2084156-1-eugen.hristev@microchip.com> References: <20220303153618.2084156-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY, not check if it's streaming to return the busy state. Suggested-by: Hans Verkuil Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index d2cc6c99984f..67b4a2323fed 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv, { struct isc_device *isc = video_drvdata(file); - if (vb2_is_streaming(&isc->vb2_vidq)) + if (vb2_is_busy(&isc->vb2_vidq)) return -EBUSY; return isc_set_fmt(isc, f); -- 2.25.1