Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp963539pxm; Thu, 3 Mar 2022 07:55:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwVUHa57w+yC34ohGkNG30eXW8bxBubEyQzrUybATIwD5ceVqh+MCGp91lj1P43s62WPGDz X-Received: by 2002:a17:906:3ec9:b0:6bb:2eb9:84f with SMTP id d9-20020a1709063ec900b006bb2eb9084fmr27345876ejj.86.1646322924357; Thu, 03 Mar 2022 07:55:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646322924; cv=none; d=google.com; s=arc-20160816; b=PYe5fOY/2qvbvnYdo+Ph7qBQcvMaLud8qxhJNttPHd2acM1Bm1QF8nKRuww6oM48q9 z1deIOKzkeJTeKFtB1sMRZzEKe8apdIP8saALudefrZe0CfzaR8njFyuhAKyiXKnQErY l8XrxmdYxIuTrqaKx9VLg7L+USw0A/TD6la3hb5kaODBkotkXnA0qVSvOyl3X7FfcdY0 mh5mgVb8/SoJOYJ9Dvdk1SzD/VRE7XWyCW8eb3TrOZGhftvpUXGbIB3AUBPgrCwOuTSb pBYiZYr8x+CeJWbdQ+tCB0kgdmmL3jurg2lPpTzR0q45cWyH//BhWYY6f3tn1vrAZcb9 8bdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+XmXyDdzXTmYSkLqHU9R3AoYt+Mv+MfQmKLG3KLVNn4=; b=IKMq7mbTfxuw+bLqhIHm+uTfrraFfZD8HBYRPTaAJN1lizjNYsXHyhm1uHXvKDzN7x BWoP7pYHiBnM0c5PqNijA6M6rKN1oxwh6COO39CkUB6aMwuV83DN04dxHBpqdf+GJqNW 2ysIeHRM8pK7PxVy1ViV/OnKFYsMT3foRHxO0ILms7R38F8vZ8A+uzN8ADwIwX3HCn0U cibjE8QfkDfdYvXAY7Im8WdZVeFLIIb8hg7AbPV/haReCfJUaGqbgf8rXrPiScCT23uc xwxHOe/oO4u7FdJT1x8KEF97lvCAUAiNl3TZGjELCUzzo/sZWAOWfDUST3QuHU8L3thy y6GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=HzCuyWh7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb24-20020a170907961800b006da6507eda0si1489487ejc.633.2022.03.03.07.54.56; Thu, 03 Mar 2022 07:55:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=HzCuyWh7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234529AbiCCPiT (ORCPT + 99 others); Thu, 3 Mar 2022 10:38:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234607AbiCCPiG (ORCPT ); Thu, 3 Mar 2022 10:38:06 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 769B5192E08; Thu, 3 Mar 2022 07:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646321840; x=1677857840; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Iu9Y9l00LK8qD2HMPVyxqsR2snkJn5NMx606dNlvBmQ=; b=HzCuyWh7inT618VhgiawiGjrPl3UCgNSKA+fYkJD6Bjc7ZAiH+6JPB38 1xBcIG+77Zuu6ZGwxFN9YyhAzUVJqpH8zaDr7vFLECgZruOKa/0WmEFy3 II8m7zUbnkLBEsJU2kPRBwCyp4yp61rVNos9M1sBZogNU9w8eph32GRsn UeXzfgWcg0ADPr0b/MF3HeasJ+H+oqkYYrVSxTJVOKC8HYI7WMt1xQYK3 PPh0c2gIFhHMaINtsO7/J2DxH7rHo9lRTxY6avjSWMml53tSkHwbovHVB qGTrq4IbtlBRlCt9CBPg5i0g2Z93yXBLGCfjBsvkrgqX/RTMLOdLPDy8R g==; X-IronPort-AV: E=Sophos;i="5.90,151,1643698800"; d="scan'208";a="155596028" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 03 Mar 2022 08:37:19 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 3 Mar 2022 08:37:18 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Thu, 3 Mar 2022 08:37:10 -0700 From: Eugen Hristev To: , CC: , , , , , , Eugen Hristev Subject: [PATCH v6 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Date: Thu, 3 Mar 2022 17:36:10 +0200 Message-ID: <20220303153618.2084156-6-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220303153618.2084156-1-eugen.hristev@microchip.com> References: <20220303153618.2084156-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While this does not happen in production, this check should be done versus the mask, as checking with the YCYC value may not include some bits that may be set. Is it correct and safe to check the whole mask. Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index c244682ea22f..025c3e8a7e95 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -291,7 +291,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) * Thus, if the YCYC mode is selected, replace it with the * sama5d2-compliant mode which is YYCC . */ - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; rlp_mode |= ISC_RLP_CFG_MODE_YYCC; } -- 2.25.1