Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp973045pxm; Thu, 3 Mar 2022 08:04:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaAhy9v85+NKp2Vfc6P7wH8ccJfBkZ0bNvSJRV0iBgF8+I1dCMECYoUE0ugLTHFmBWBT2m X-Received: by 2002:a05:6402:2549:b0:415:c31c:f9c2 with SMTP id l9-20020a056402254900b00415c31cf9c2mr7585720edb.335.1646323495116; Thu, 03 Mar 2022 08:04:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646323495; cv=none; d=google.com; s=arc-20160816; b=USHiu/Ey0Tc6G4DtZFv3QfyveecSXsZ9MJ+mKqjEYhhGCuGNyoJsapDYPlBusnqnZf RxLee1hSmfQnSbHUQp3by8sasxaf+uz+UQ9Why3nxO3pg2ejAiB1vNlabnUiffgU1gRb iENBv/KZaQhk50lJ0A4dEG6gv9grnTeeEDBhh+uEJWTFdMoU3K3A2vfEZOBi1USb3osY VgGjoUpjREbeSIZ2aIzGZ0vHYKIeCepJ7taxgTYFZxDmhyr8kIoXySxUfrE7tZT5goLe 45C1CxrE+Mh7EttPXbFTisJ5fubiMPrsfmfzxoO2fBaLa09SimQFuh7+YYRwUZDEH8VB EyIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=nTOmvpJSqckbzDf6eNL7+28B+F+UJStxYN/hNpPhOJs=; b=XH3t4irjm/ziu50cnU2YIrCM0NDobG2smFRaKEK2Sj6DXjKIgb0VZ7r+X2+d2Vmzyu 9WwRp37RIZR8JaaFp4cI3jgAWRpt6qpgUmNNfGPWFSUqBTiOqroTjw/DJEp/MhAtnbSM d87UPzxDpOhmT7Mcbh9Hi9pCFJvoG3rGJWChF3AOR4Vd4MN3S7jA5s5d13b4UHI5jGA6 tJGP1VZKTowNY7LyeDxSDFxPx6JGRSvxsjIBTDH01ZypKERUb+9Xw4ul4+C2x09/Fl85 qSzT7Z4snam96Xnk07TmHhsCHiv59LzY/smPToeSC0+Pud66ml1fg1AdAgv70TFAH7WJ SsQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2hK1c4rR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a50d886000000b00412e14c653asi1734093edj.40.2022.03.03.08.04.29; Thu, 03 Mar 2022 08:04:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2hK1c4rR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233059AbiCCO6V (ORCPT + 99 others); Thu, 3 Mar 2022 09:58:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233890AbiCCO6S (ORCPT ); Thu, 3 Mar 2022 09:58:18 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA4F18FAF9; Thu, 3 Mar 2022 06:57:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nTOmvpJSqckbzDf6eNL7+28B+F+UJStxYN/hNpPhOJs=; b=2hK1c4rR4aVG0ad7mKz7MpWxDj x6Elg54vNkqJj+F/azQVGGzqo/Qf08ilktEoaP2BYNe8WJ/7ibQMOJtPLE9rYoqtChmuJ9/v0RYZM W6VeyNcyhWO3ldIEVBaB5ha56PHJFwGCTNj7iat+XgkOYPkU64D78XfHsWNdcsqOEjrBmk+Q+30qV tNEUNZtjNmgJpHKZymDRAR1LO7Itq+FYqPZafs++O8hGrqDYHsxt/SgmqyYJqHo45So8F3yRuobz8 N9yu3tGeWjw8LWKyW1XR3/JgdKEyp+g1v+pIzlSSalPP0UBPwICyq21Hqc7ZwxjgKIuIUWrcyD1jh 5JV27RdQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPmtL-006j7N-Eo; Thu, 03 Mar 2022 14:57:19 +0000 Date: Thu, 3 Mar 2022 06:57:19 -0800 From: Luis Chamberlain To: Aaron Tomlin Cc: Christophe Leroy , Daniel Thompson , "pmladek@suse.com" , "cl@linux.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "atomlin@atomlin.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" , "jason.wessel@windriver.com" Subject: Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> <20220228234322.2073104-14-atomlin@redhat.com> <20220302161917.gx5icfszakoye4uh@maple.lan> <20220302203153.3kcmwu662szf3drt@ava.usersys.com> <20220303104404.crqt7oz4kydq36fo@ava.usersys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303104404.crqt7oz4kydq36fo@ava.usersys.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 10:44:04AM +0000, Aaron Tomlin wrote: > On Wed 2022-03-02 14:46 -0800, Luis Chamberlain wrote: > > Since we are doing this to help with the cleaning this crap up > > the natural thing to do is have the code be a helper which only > > built-in code can use, so writing a helper starting with > > list_for_each_entry() which prints the modules out. I'm > > surprised we have no other users of this. There is nothing > > kdb specific about the functionality in that code. So it should > > just be moved. > > Hi Luis, > > Good point, albeit is it really worth it since the only external > user is kernel/debug/kdb/ code? Yes, no need to be exposing that list out anywhere else. And if the list is needed better to have a helper for the users. Luis