Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1150946pxm; Thu, 3 Mar 2022 11:18:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkp6+g6x4/SaLvkdQ934X/Y9XqF1AXwqFiaJSut2B5M/yCInarMmK1AFOk3VZ03mf81biW X-Received: by 2002:a17:902:dacd:b0:150:4f5:1158 with SMTP id q13-20020a170902dacd00b0015004f51158mr36971806plx.67.1646335101611; Thu, 03 Mar 2022 11:18:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646335101; cv=none; d=google.com; s=arc-20160816; b=dWjX1naGc3Y8omq6WNEbTebw2kK/z/NbDcYc5xuskdfvPTKzQo/MIP1Ag+EP38dZd0 eLs054N/dKHoX82teuSzp3yeLGij5MO35N4sWkrB6ijybKwpmQLY8D2QcLE7SFSbIvTl vUTUsKvtFPIFc6m47rcHKzuCKODm7mMxE/cYOdNx+tXyQUVwm7TnlITZbfZiasO+mdOA K85+3xmi5iiKgHWPVTZUPWhXgoIPgevwp/SRIE3zU5dGJKpTJM8QaEEqsSQrN2Qqf+Me YxgPQygTJ1m4Mbf2rxgcqlPkoddRqPbBa18ghu1voV/3jiW4iysnVajDRfhygnJt4Mhv 6obA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4etORIg2Q6KJ92tEY8v0D9IqX+zqC98LN3nMR0UBOqA=; b=HXM57aYSI0AriEDdUmt+mK8U9uqBvM4KFcUARhU/5CGXO+bkWuCrzwdu6UtugWC/0M O3LDf14RTjtg/IuFEKz1+8GZirhvFhdiUl8fS7M47H6j+UO1iSVFDHo7Lk3TR2nz65jm bDR/DuVlL2aSL1ZCPW69j6276PI0vfu0WNij4EH2dXEtvt3ikzoNGgrBSfM9XdeODyQL UU1OX3FNT9QAMQrHbfcGYsHlBH+9wK1uaZdFw23RxzyTABSdIZJV0acefzw97d+x18Yn deHZHRVfFfAUiH0QrXNg4QYEyOm9+VYviS6DVxfZry5E5RhnZcix0pPCA6lbNeHN9lHK BTag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=dWOeNnBF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k27-20020a635a5b000000b00368ea83cae4si2817506pgm.682.2022.03.03.11.18.02; Thu, 03 Mar 2022 11:18:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=dWOeNnBF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbiCCLwN (ORCPT + 99 others); Thu, 3 Mar 2022 06:52:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbiCCLwK (ORCPT ); Thu, 3 Mar 2022 06:52:10 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5BA7F94FD; Thu, 3 Mar 2022 03:51:22 -0800 (PST) Received: from nazgul.tnic (nat0.nue.suse.com [IPv6:2001:67c:2178:4000::1111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 237E61EC032C; Thu, 3 Mar 2022 12:51:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1646308277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4etORIg2Q6KJ92tEY8v0D9IqX+zqC98LN3nMR0UBOqA=; b=dWOeNnBF7RaxfscWLq+DFbNU8NUKF85I2GUUohS4muRNYSW163/4jCh3x+ITc+ckdPvo25 IE2nqZFAlPScH8tklRX9QRDxdTDsBSMRVehoLhn7MH62b6JEmH3JS66iXecq7agtZpVVFC SWiu4T172cJ4CdTwu49FO/VBRl8WN1M= Date: Thu, 3 Mar 2022 12:51:20 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v11 39/45] x86/sev: Use firmware-validated CPUID for SEV-SNP guests Message-ID: References: <20220224165625.2175020-1-brijesh.singh@amd.com> <20220224165625.2175020-40-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220224165625.2175020-40-brijesh.singh@amd.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 10:56:19AM -0600, Brijesh Singh wrote: > Also add an "sev_debug" kernel command-line parameter that will be used > (initially) to dump the CPUID table for debugging/analysis. No, not "sev_debug" - "sev=debug". I'm pretty sure there will be need for other SEV-specific cmdline options so this thing should be a set, i.e., "sev=(option1,option2?,option3?,...)" etc. See mcheck_enable() and the comment above it for an example. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette