Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cef16c0a-c0a8-3ed2-c35b-09fda2068073@linaro.org>
Date:   Thu, 3 Mar 2022 16:28:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n
Content-Language: en-US
To:     Vinod Koul <vkoul@kernel.org>
Cc:     yung-chuan.liao@linux.intel.com,
        pierre-louis.bossart@linux.intel.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        quic_srivasam@quicinc.com,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
References: <20220303110321.23666-1-srinivas.kandagatla@linaro.org>
 <YiDlBevX3/BrXmwb@matsya>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <YiDlBevX3/BrXmwb@matsya>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 03/03/2022 15:55, Vinod Koul wrote:
> On 03-03-22, 11:03, Srinivas Kandagatla wrote:
>> Fix below build failure
>> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
>> but not used [-Werror=unused-function]
>> by marking the resume swrm_runtime_resume() with  __maybe_unused attribute.
> 
> A patch title should reflect the change and not the cause. So i have
> taken liberty to fix it as:
> 
> soundwire: qcom: use __maybe_unused for swrm_runtime_resume()
>   
> swrm_runtime_resume() would not be defined when CONFIG_PM=n
>   
> This causes below build failure
> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
> but not used [-Werror=unused-function]
>   
> Mark the resume swrm_runtime_resume() with  __maybe_unused attribute.
> 
> With this i have applied

Thanks Vinod,

--srini
>