Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1200685pxm; Thu, 3 Mar 2022 12:20:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAZtRIw5F6rSVjrNSwmM9w+B8H8YvcIvvZXixqHXdRehGhmI7uikiPu0AwtvKO1Y+90lGZ X-Received: by 2002:a17:906:2991:b0:6cd:ac19:ce34 with SMTP id x17-20020a170906299100b006cdac19ce34mr29021052eje.746.1646338856870; Thu, 03 Mar 2022 12:20:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646338856; cv=none; d=google.com; s=arc-20160816; b=g9OMhJIE/K3E37rJwD0cCpvx2aSS00TZVSPfwqhSLR02am6JlgaJIiylq7bYBQBfET So4ku41EeRZAP/ouNiejP7rrvXXxIBSx88thn3TrqF5G1OaM0Nv/7dgsAL7h9sMl4KER JKSHtkSCGZHfgHZhYzOcZDSiEOoubrKffITdkkPrGwsBMnP2jmAOs7yzQ3z6QIwYDG1F UAR3ZYqutS7z8OsAiCIa9nL0HY2rCh5VIzcOgeUKs2nG4d2NIfY3ScgOy/9h1mIkvswy RJ4m2dgofvqLE/9tG3KlYhMxXSfYBcNZfYdPr5X2IyZ6e+HrWfIqXiwaWC7Qu4gySP0K SSDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mYrrOG/s2mjfio75s3dq/dKVQ4hb6AKuIgv4XF18k5o=; b=TqR8aOc1eKdd1rmAhlarNi1TiHkdNIOD2TGGuQORMgvZrIruNn4aaHhWTl/OQE2SWH 32EynCOfa2lR2z7nzRBLWuacc+ulo7qH7WR6Q2yBT8yhGeztQnRGJVkD0D+eNrRLY4Tf 7BDQSQQijaV4gQiF6xvyxyLa8Tnfxas/EKt2iAKiZA5QlxXZN5R8EpiHlAqwEBlYORmD C9tbN0utKnfVfKzpeUSnSAln2n+Jzy7T0XChQevpQ07r+cRxlAL/jgLmQe1KJ6CBvzLj lDemvy8jsllyitT6i543yTUXV4SFp9Bsf1AU/KKVLZFYjOzw41lKDKUpJ85y6snOPW3Y 3NIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=puVBQooX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020a170906a28400b006cd99022ddfsi1897271ejz.362.2022.03.03.12.20.29; Thu, 03 Mar 2022 12:20:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=puVBQooX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235513AbiCCTBj (ORCPT + 99 others); Thu, 3 Mar 2022 14:01:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbiCCTBi (ORCPT ); Thu, 3 Mar 2022 14:01:38 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0142719F452; Thu, 3 Mar 2022 11:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mYrrOG/s2mjfio75s3dq/dKVQ4hb6AKuIgv4XF18k5o=; b=puVBQooXBZePIB2vmMTSbXd57s p17MgatBJCjBKtRJ+UT1TBodIBURDW/LOhzMJ50muFzytAz8XxJ/BrFPLQ4prU8hIxdCLVJ2wCJH9 TZlwm3rAbg9eJGfQi+uBcbCqS9bstks2nG8cEyx5xEVVy9hZXbSACSKhfmtrS1JMAIGb2Nm7ujVm7 fEAr2epRFpKIzcV4yR7wr7k0C5+ORqH73Md/qogC3eWDJmwJbhh+WbqhyOkk/cvqdd1G8emGY0Wq+ IUDmTg9cCbO+gDzXRygN3zXeeV05WeYo1IodMQrwzObhU5ZJHPFZoUt5BlHoU/WrJzCmPcW0I4q74 EvEhJhzw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPqgl-007WTc-Tq; Thu, 03 Mar 2022 19:00:35 +0000 Date: Thu, 3 Mar 2022 11:00:35 -0800 From: Christoph Hellwig To: Christophe Leroy Cc: Christoph Hellwig , Daniel Thompson , Aaron Tomlin , "mcgrof@kernel.org" , "pmladek@suse.com" , "cl@linux.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "atomlin@atomlin.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" , "jason.wessel@windriver.com" Subject: Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> <20220228234322.2073104-14-atomlin@redhat.com> <20220302161917.gx5icfszakoye4uh@maple.lan> <20220302203153.3kcmwu662szf3drt@ava.usersys.com> <20220303145949.inaz2tecmfuek2hf@maple.lan> <5b582422-ef36-009e-7cb7-b85b5022c9aa@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b582422-ef36-009e-7cb7-b85b5022c9aa@csgroup.eu> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 06:16:58PM +0000, Christophe Leroy wrote: > Well .... The idea at the first place was to get rid of the #ifdef > CONFIG_KGDB_KDB in modules. > > Here you propose it the other way round. Why not, in that case that > would mean a dedicated file in kernel/module/ as part of the series > https://patchwork.kernel.org/project/linux-modules/list/?series=618917&state=* With the series you can of course move it to a new kernel/module/kdb.c. But I don't have a tree with the series applied at hand and just want to show how kdb_lsmod can live outside of kernel/debug easily.