Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 5jhaWPT0AYHRJOJk0MEWImZVg8pA3F0pZLk2M65ZDibT4+L/27JuSkQUw5ZV+Q2OH+6MGWKKC9
 XT+OnlGjKVUjjUMdEJfREMDaAY/wQ9S3DV1yMDekmbivbeKhBe4cPKW6sQTnR8+15lVqocv6hH
 Tf7lDKuwyhY7zH1NmIQsrp7CpqpyyDo8s6XLfnCxH+PD0zDpl7OLwQpls2TjoQpjutUwPBj8zu
 ssmMPLgwCTXqiys2BYlAneRdWmCkIZ264F8UEojwyEjsZ2C/zyHKO6jxQe933Q9SRMBMJyNF/o
 RDrrN/7tErima1OyX2fYR/Gl
IronPort-SDR: XhwvEsLQm19irvlA43zAXyoA4d7N2YC+neCZTcg5rEyvJNLR8mZwKbfAzCh4dyDGk7u7UGK8mu
 1krBX8KOLboj7hX8J0sZKcVuBt9crWsa0ZZ2Hl02xFFnfpoFC/o+GGySOOCCYcYWU92GPsJS6E
 NqCyczn7YCFfdlphZv1WWqHG8THZw/OL4B4Uf91KgOi6fI4yu6v2+CqIzF+rOIeTnMjukOCyj4
 qgeD/08cc8ZezUXZzfoVTk8UrZtN/zYmH4zUQcZqLKq47lg8RBu5A0J34+lE8l9Jh73xVKhPOv
 Zj0=
WDCIronportException: Internal
Message-ID: <eb107f83-373f-c489-502d-a1655271c06b@opensource.wdc.com>
Date:   Thu, 3 Mar 2022 18:29:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH 0/4] scsi: libsas and users: Factor out internal abort
 code
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ajish.Koshy@microchip.com, linuxarm@huawei.com,
        Viswas.G@microchip.com, hch@lst.de, liuqi115@huawei.com,
        chenxiang66@hisilicon.com
References: <1646309930-138960-1-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1646309930-138960-1-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/03/03 14:18, John Garry wrote:
> This is a follow-on from the series to factor out the TMF code shared
> between libsas LLDDs.
> 
> The hisi_sas and pm8001 have an internal abort feature to abort pending
> commands in the host controller, prior to being sent to the target. The
> driver support implementation is naturally quite similar, so factor it
> out.
> 
> Again, testing and review would be appreciated.

John,

Traveling this week so testing will be difficult. I will try this first thing
Monday next week.

> 
> This is based on mkp-scsi 5.18 staging queue @ commit f2ddbbea7780
> 
> John Garry (4):
>   scsi: libsas: Add sas_execute_internal_abort_single()
>   scsi: libsas: Add sas_execute_internal_abort_dev()
>   scsi: pm8001: Use libsas internal abort support
>   scsi: hisi_sas: Use libsas internal abort support
> 
>  drivers/scsi/hisi_sas/hisi_sas.h       |   8 +-
>  drivers/scsi/hisi_sas/hisi_sas_main.c  | 453 +++++++++----------------
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  11 +-
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  18 +-
>  drivers/scsi/libsas/sas_scsi_host.c    |  89 +++++
>  drivers/scsi/pm8001/pm8001_hwi.c       |  27 +-
>  drivers/scsi/pm8001/pm8001_hwi.h       |   5 -
>  drivers/scsi/pm8001/pm8001_sas.c       | 186 ++++------
>  drivers/scsi/pm8001/pm8001_sas.h       |   6 +-
>  drivers/scsi/pm8001/pm80xx_hwi.h       |   5 -
>  include/scsi/libsas.h                  |  24 ++
>  include/scsi/sas.h                     |   2 +
>  12 files changed, 368 insertions(+), 466 deletions(-)
> 


-- 
Damien Le Moal
Western Digital Research