Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 2/2] kselftest/vm: fix tests build with old libc
To:     Chengming Zhou <zhouchengming@bytedance.com>,
        akpm@linux-foundation.org, shuah@kernel.org
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220227055330.43087-1-zhouchengming@bytedance.com>
 <20220227055330.43087-2-zhouchengming@bytedance.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <ed6cc632-8209-0afe-fdff-ee179610d73d@linuxfoundation.org>
Date:   Thu, 3 Mar 2022 14:27:41 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220227055330.43087-2-zhouchengming@bytedance.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/26/22 10:53 PM, Chengming Zhou wrote:
> The error message when I build vm tests on debian10 (GLIBC 2.28):
> 
> userfaultfd.c: In function ‘userfaultfd_pagemap_test’:
> userfaultfd.c:1393:37: error: ‘MADV_PAGEOUT’ undeclared (first use
> in this function); did you mean ‘MADV_RANDOM’?
>    if (madvise(area_dst, test_pgsize, MADV_PAGEOUT))
>                                       ^~~~~~~~~~~~
>                                       MADV_RANDOM
> 
> This patch includes these newer definitions from UAPI linux/mman.h,
> is useful to fix tests build on systems without these definitions in
> glibc sys/mman.h.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>   tools/testing/selftests/vm/userfaultfd.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
> index 2f49c9af1b58..3fc1d2ee2948 100644
> --- a/tools/testing/selftests/vm/userfaultfd.c
> +++ b/tools/testing/selftests/vm/userfaultfd.c
> @@ -46,6 +46,7 @@
>   #include <signal.h>
>   #include <poll.h>
>   #include <string.h>
> +#include <linux/mman.h>
>   #include <sys/mman.h>
>   #include <sys/syscall.h>
>   #include <sys/ioctl.h>
> 

Looks good to me.

Andrew,

If you want to take this through your tree or I can apply it.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah