Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965662AbXBTAVu (ORCPT ); Mon, 19 Feb 2007 19:21:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750947AbXBTAVq (ORCPT ); Mon, 19 Feb 2007 19:21:46 -0500 Received: from kanga.kvack.org ([66.96.29.28]:35713 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbXBTAVn (ORCPT ); Mon, 19 Feb 2007 19:21:43 -0500 Date: Mon, 19 Feb 2007 19:21:09 -0500 From: Benjamin LaHaise To: Chris Mason Cc: "Ananiev, Leonid I" , Zach Brown , linux-aio@kvack.org, linux-kernel@vger.kernel.org, Suparna bhattacharya , Andrew Morton Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event Message-ID: <20070220002109.GG31205@kvack.org> References: <20070219203527.20419.68418.sendpatchset@tetsuo.zabbo.net> <20070219215048.GI6133@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070219215048.GI6133@think.oraclecorp.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 24 On Mon, Feb 19, 2007 at 04:50:48PM -0500, Chris Mason wrote: > aio is not responsible for this particular synchronization. Those fixes > (if we make them) should come from other places. The patch is important > to get aio error handling right. > > I would argue that one common cause of the EIO is userland > error (mmap concurrent with O_DIRECT), and EIO is the correct answer. I disagree. That means that using the pagecache to synchronize things like the proposed online defragmentation will occasionally make O_DIRECT users fail. O_DIRECT doesn't prevent the sysadmin from copying files or other page cache uses, which implies that generating an error in these cases is horrifically broken. If only root could do it, I wouldn't complain, but this would seem to imply that user vs root holes still exist. -ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: . - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/