Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220303173935.100622-1-cmirabil@redhat.com>
In-Reply-To: <20220303173935.100622-1-cmirabil@redhat.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 3 Mar 2022 21:20:58 +0100
Message-ID: <CANiq72mcVrnm2bBP530c6rKfGzQj1vAJXgizQgk7f5G4X0SkGg@mail.gmail.com>
Subject: Re: [PATCH v7 0/6] Raspberry Pi Sense HAT driver
To:     Charles Mirabile <cmirabil@redhat.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Serge Schneider <serge@raspberrypi.org>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Mattias Brugger <mbrugger@suse.com>,
        linux-rpi-kernel@lists.infradead.org,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        fedora-rpi@googlegroups.com, Daniel Bauman <dbauman@redhat.com>,
        Mwesigwa Guma <mguma@redhat.com>,
        Joel Savitz <jsavitz@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 3, 2022 at 6:58 PM Charles Mirabile <cmirabil@redhat.com> wrote:
>
>         - Changed userspace layout of the display driver to rgb565 triples
>           and removed the gamma table lookup and the associated ioctl. If
>           the user wants to recreate linear brightness scaling, they can
>           use a lookup table on their end. Doing this also removes a lot
>           of error checking and general code complexity, so I think removing
>           this feature is actually for the better.

Sounds better indeed! If I understood correctly how it worked in the
previous round, it should also allow to use the hardware to a fuller
extent.

>         - Replaced if statement with call to `min_t` function in display
>           read and write functions.
>         - Replaced the custom llseek implementation with a call to
>           `fixed_size_llseek`. Thanks to Miguel Ojeda for all of these
>           great suggestions.

You're very welcome!

Cheers,
Miguel