Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d3b27eb1-6da5-0fee-0d06-fa39c44ffd3f@amd.com>
Date:   Thu, 3 Mar 2022 13:41:19 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH][next] drm/amd/display: Fix Wstringop-overflow warnings in
 dc_link_dp.c
Content-Language: en-US
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
References: <20220303172503.GA1731116@embeddedor>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220303172503.GA1731116@embeddedor>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm9WeFlnVUVEV3R5aVhycFpHaldqU25JM0o3eDQ4QVhJVXVaQktVWTFrQ0ZZ?=
 =?utf-8?B?bDJtcVcvS0REWGQ5Uko1U1NLRWo5Z0EyaDZoUXFvejJZNjd2TWczdk9ha3hK?=
 =?utf-8?B?K1RlS1hKSm1qemFHRGtVNjV5dVdLM2laY09lMW9EUjdHbFNZSU5RWk4rWkpy?=
 =?utf-8?B?N0R6RWErZUNqeE9LSjBsSFpRZEJJUzhsUGc2ektpMzVWbTgvWlpEdGdXUVBm?=
 =?utf-8?B?NXc1N0Q1SkFHQzg2alBPMk1UZXRrTDhHZlRWY1IzeTY2Z3BHR1MxY1NaZnBO?=
 =?utf-8?B?S3NEVkZXbmxmeTEzZDVHNXIySnBJS1NnVmtYL0toTXIyUkx5VmVEemFkaUJH?=
 =?utf-8?B?cW9TOUFhVDV2aml6bHFhOW56cWRVaDJvR0Nnb3VHczk5djhCTVUrMmRGb2Uw?=
 =?utf-8?B?ZnRxMm1Ma3pIbDNLanJaVDI4eWcwMFZpMGpaWkJrNHprWE9hT2tPL0xKN2JJ?=
 =?utf-8?B?Nld0UFE0dmxTZEtKQ2hVNzdKd3FyeXZHYUJyVWZ2NkVCejh6a2t2Yi8vdGt1?=
 =?utf-8?B?eGdtbTQzeVVkeEdQakpnQlBGeXBkWWVId0Yrd1FJNktuL3l0N1NJa3FSWld5?=
 =?utf-8?B?UXlEeW9KQlk2eXl5cS9NeFBqY1J5NjcvOGN2eENDRWVNODhaRzY5WTMwNVNG?=
 =?utf-8?B?amFqV0xqVW9ydCtsUWtjZVNLSDhCQVFsZU1COGVVZkZRSStQckx2NzMxbTI0?=
 =?utf-8?B?SjhTY3NHQjl6NzlsN3VKMWxiUW9JVFQyakR2YU92cS9GYzlDNnB0eU1KejlL?=
 =?utf-8?B?VHNMVzF0a3p6TWRkTnRndTZ0ZnlPa0lKSWlXdHAwMU15OGsxTWFIZTRJRHQv?=
 =?utf-8?B?bHF0aXNkOXhnKzlsUU5UNC9LRVhRNG84RitRQUQza2pIMzlYRXVKWWxXUEds?=
 =?utf-8?B?cGJPRU5UbXV2R2d1RnBsQ0dwWEFlUHhvbnk5TEdWMFBQNWFYMUNEZCt4cW5p?=
 =?utf-8?B?QnZhd0hBVVFWcEtLbm9vcVpDRDZ0TFdxYkpaV3lBMWIvNjhrUE5EQmxZRk9v?=
 =?utf-8?B?UTVEeFVDN2s2ZFY0TVcycFFmODdNKzBiM3N3cXcwNlpIS1ppL25MaHdXOExh?=
 =?utf-8?B?NEdMMEJRcXc3U1Z5RmxjNWdDbmtPSFgra0lTYXJMT3libGVxalVFYjNGYVkz?=
 =?utf-8?B?SjMwNUNZZDVxSkhPajcvcHpGa0pmNUxaZWlseDR5S3FuZ1RtY1paVG9PeXNv?=
 =?utf-8?B?R1hYUzEwY21TSU1ubGlnaUZEdWUxRXQyZlNKbzdGbURXamhvb29saXMxY3Ra?=
 =?utf-8?B?c2h6eWM4NmtMYjg3cm9IUXo5bmlkQ3E2eDJVSTlZeDlad3VtU2RVcks4Vkdm?=
 =?utf-8?B?ZTVsak5ZVHE5ek5sNEJwcTV6ZzRYeGM0U2VZWmlxYzhzcEMweUtZR0Mwcmtj?=
 =?utf-8?B?cVRGSmpSbXFkbkVhd29UNE9PMEVWMHk0Z0hpN1lIOXpkTjVrZXFWQU82c3A1?=
 =?utf-8?B?MGJRN0VlTG4ydDBjMjBxaU9qdkF2TCs3b2NYeTBrTEdlQ3ZVUWQxd1VKRzVQ?=
 =?utf-8?B?MXBXQy9GZHF1RG51TmFPeWNGWjRsek5wRE96elVEYVJjRXlON2lQYTkxN2ww?=
 =?utf-8?B?b0NPNllGMnhSYW9KVDQ2QldWbmhid3VXN1dvOWJVSEpDL1hZdHBQdjcyWVQ5?=
 =?utf-8?B?bE52ekFQUWR4bUVzWG9aeVV0clBmM3EydllMVkhUdzBjUHYyNDBPQkV6blk1?=
 =?utf-8?B?V0dEMXVuUnZpdEphaEVMeWRucXNQMFhGUTl0SFovZlJxL1RTS0x1eGNIV3hY?=
 =?utf-8?B?M0h5Rko4SXBPcnlRc0w3OEQwSDFqZllsSURDbk1EeERnMWNtSU5lRFlrSm0z?=
 =?utf-8?B?djFIZmtyWjMyK3VSdkVQVTRtS255blBRYkhUcXZTT1kzMnZRUW5qOFpHNkFy?=
 =?utf-8?B?UUFoZUdPdUhvcmhrRFNFQThvMHNhNVhjSDVwa1pIRGRzc3NRNDVsRWpSdlo3?=
 =?utf-8?B?anE5V0k3SmkvaXNqWnNpczdzdVJmbXFNN2Zsd3VRaVpVSUxnOUNLa0NhaDNz?=
 =?utf-8?B?OEYwVmZRT0ZsOGgxQzdtS0M2R3JTdkFGajV3NThZbkRYamZCamdUNXh0S296?=
 =?utf-8?B?bmlNZHdGT09OT0VFK2JjTEdYRWRTVlV5cithRWVNYW1aWTEvWEZ0SjJsTlZz?=
 =?utf-8?B?bGhNSFp4QmpocWh2UDRHVlYzWUhOelBnd1NXVTR5OHlvSEdJcXdwMmNhZVox?=
 =?utf-8?Q?zgcnjnsvL9Ne3qljdEDRHYI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a374700-4be1-47dc-a576-08d9fd456adb
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 18:41:23.9030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t6V2m39zq3exGefbvtEJT7Za5u3A6aoT6yYRtnIe6WqgWJX7PlN7GffKQvBsLy9JhllPFt6krNGDYeNoW35/ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3479
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-03-03 12:25, Gustavo A. R. Silva wrote:
> Fix the following Wstringop-overflow warnings when building with GCC-11:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:493:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:388:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:388:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:388:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1491:17: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2613:25: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:2613:25: warning: ‘dp_decide_lane_settings’ accessing 4 bytes in a region of size 1 [-Wstringop-overflow=]
> 
> by removing the over-specified array size from the argument declarations.
> 
> This helps with the ongoing efforts to globally enable
> -Wstringop-overflow.
> 
> Link: https://github.com/KSPP/linux/issues/181>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Acked-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++--
>  drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index f11a8d97fb60..81952e07acf6 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -823,7 +823,7 @@ bool dp_is_interlane_aligned(union lane_align_status_updated align_status)
>  void dp_hw_to_dpcd_lane_settings(
>  		const struct link_training_settings *lt_settings,
>  		const struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],
> -		union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX])
> +		union dpcd_training_lane dpcd_lane_settings[])
>  {
>  	uint8_t lane = 0;
>  
> @@ -853,7 +853,7 @@ void dp_decide_lane_settings(
>  		const struct link_training_settings *lt_settings,
>  		const union lane_adjust ln_adjust[LANE_COUNT_DP_MAX],
>  		struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],
> -		union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX])
> +		union dpcd_training_lane dpcd_lane_settings[])
>  {
>  	uint32_t lane;
>  
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h b/drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h
> index ab9939db8cea..0d00da1640a7 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h
> @@ -147,12 +147,12 @@ bool dp_is_max_vs_reached(
>  void dp_hw_to_dpcd_lane_settings(
>  	const struct link_training_settings *lt_settings,
>  	const struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],
> -	union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX]);
> +	union dpcd_training_lane dpcd_lane_settings[]);
>  void dp_decide_lane_settings(
>  	const struct link_training_settings *lt_settings,
>  	const union lane_adjust ln_adjust[LANE_COUNT_DP_MAX],
>  	struct dc_lane_settings hw_lane_settings[LANE_COUNT_DP_MAX],
> -	union dpcd_training_lane dpcd_lane_settings[LANE_COUNT_DP_MAX]);
> +	union dpcd_training_lane dpcd_lane_settings[]);
>  
>  uint32_t dp_translate_training_aux_read_interval(uint32_t dpcd_aux_read_interval);
>