In-Reply-To: <20070220002109.GG31205@kvack.org>
References: <20070219203527.20419.68418.sendpatchset@tetsuo.zabbo.net> <B41635854730A14CA71C92B36EC22AAC83B044@mssmsx411> <20070219215048.GI6133@think.oraclecorp.com> <20070220002109.GG31205@kvack.org>
Mime-Version: 1.0 (Apple Message framework v752.3)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <998821DA-955A-4F4E-A3C5-4BEAE6FFF90B@oracle.com>
Cc: Chris Mason <chris.mason@oracle.com>,
       "Ananiev, Leonid I" <leonid.i.ananiev@intel.com>, linux-aio@kvack.org,
       linux-kernel@vger.kernel.org, Suparna bhattacharya <suparna@in.ibm.com>,
       Andrew Morton <akpm@linux-foundation.org>
Content-Transfer-Encoding: 7bit
From: Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event
Date: Mon, 19 Feb 2007 16:26:18 -0800
To: Benjamin LaHaise <bcrl@kvack.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 885
Lines: 23

>> I would argue that one common cause of the EIO is userland
>> error (mmap concurrent with O_DIRECT), and EIO is the correct answer.
>
> I disagree.  That means that using the pagecache to synchronize  
> things like
> the proposed online defragmentation will occasionally make O_DIRECT  
> users
> fail.

Well, only if the pages couldn't be invalidated.  Arguably ext3  
should be trying a lot harder to invalidate before giving up and  
returning failure from invalidate_page().

Hopefully this all goes away in the long term with Chris'  
"placeholder" work that stops insertions into the radix tree while  
dio ops are in flight.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/