Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Mar 2022 10:29:36 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support
Message-ID: <20220304022936.GA4164495@anxtwsw-Precision-3640-Tower>
References: <20220223102353.3833578-1-xji@analogixsemi.com>
 <20220223102353.3833578-2-xji@analogixsemi.com>
 <Yh9dBlrWm3OicQWa@kuha.fi.intel.com>
 <20220303024757.GA4159259@anxtwsw-Precision-3640-Tower>
 <YiC+/ccRvR/+mAkT@kuha.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YiC+/ccRvR/+mAkT@kuha.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KcIXb3mKp8HrxTzcs9ZJQ2oamPvuRd9fSyhN8FfYynIuPdZQwtfKRt8ypc3A?=
 =?us-ascii?Q?/z2AUoJHqXhWCtRiInuOHAS6w+TVRYlNivGXoJnkPpowh+Yeganu4aKTBoHY?=
 =?us-ascii?Q?xmzGK/k9XllQTB2e60tPAJ3M05gTJZVAulKZUsCuQSFIZPIgPvMOid58xi1R?=
 =?us-ascii?Q?fNuOlLOiNDsTk4HxCCY2kWBwMcAYKx87NPBKYg3SIdXlsptW/YgS+ltdssKm?=
 =?us-ascii?Q?PPB7fNOKyqlF1TLiPM1YIZAKmC4B+BpBdw+Q0siN5AKlrJMT32n0OpbvzUa+?=
 =?us-ascii?Q?NmS2OU86XihVUAIy8bpXCugiMnonLAi+5/P+KRn2xw8nhpNtrk5Nfnp13GQq?=
 =?us-ascii?Q?HHsXfWPgmIIYahDoA6sy5tOkj1jsb2xC2Qx3GHJRu2ZgxWl/9m/Akpe0kQ8g?=
 =?us-ascii?Q?Ft1FsUEv1ld4dO0CCLpviJKOJ76mEWw7Xa7JSz0Kl9BNS9q/9ZCKgmqpClKL?=
 =?us-ascii?Q?TFoGmLqvNSXOEwEVpWGfHe5mMCSe4UbGqljlB+axiVg1ItJFMmM3lsu/tNV7?=
 =?us-ascii?Q?fdpuINkeHKAG8T04gGvMSdXa+6RlnuTXShZmyNqfDdB28CVy4hs7Yl/Xsk07?=
 =?us-ascii?Q?KtKMCX+saJ7ZI8wtIcz13InLUNLZgb//7nHt5UL4g0HbMyEoHdA8QnF68KIL?=
 =?us-ascii?Q?fmXdHC89zfzJyy7J00okyzGoy5JoigiH4OsZZYQ71x/IRIttXwjNUn5tb3Pw?=
 =?us-ascii?Q?SUR0Z+tfc8TxdNG9UYRFzIzXMso3KZy5wSJ4zfy8ZAjROqvzhbuK6M76d+2n?=
 =?us-ascii?Q?5rEeCjSEWdBSPnHVciXGYqO0pZIjrxb2ASPtqomXmdRqYBeiZ7OvW0a5/Jh+?=
 =?us-ascii?Q?vULERkllP37MelQ5cRDA2CKoGNSw7GRL5RhmZ2FGjGReJozOcPj0RzCqki+7?=
 =?us-ascii?Q?z13S+3zWT3SmxAGdDphAs6R19mZRrWccXRqseIhCvqqFp7U91i6kUoR1yuh/?=
 =?us-ascii?Q?j7vyuvgX+UbCM3nem/BGb1Pusv3xLkB4qK72DjlrfQRJh6YVLsz8NVgPg2Zz?=
 =?us-ascii?Q?DGlr2u5w8T81ACBn/N/tQ9AFJBqH14frCuSum6aRwSSC99uXR1Y4zrrlDIQD?=
 =?us-ascii?Q?zlhhzNBwG2Lc4r7Ac59DczawmDL6Y63J8eV+YDHB02KSLYnGaqK4FbQH3cAL?=
 =?us-ascii?Q?fnrh7hh6IAfvA1VfKmiyPVjKjINWMcRj3TWj1FzEsrsO2iqHgA1fkx1SYJl8?=
 =?us-ascii?Q?cYajxDy/PtTxPvw+U+mEYkCkcjIxuMA78v0DmJqTu9WQWRzTHuH1tj6HYZHI?=
 =?us-ascii?Q?scJlWPe0wIdcVJwg4ykaxuyY1NGJyfjF0O9INOJ6oEd8BAQ/waw5Ct0AUIik?=
 =?us-ascii?Q?zz/pE8ItDF8tTAPXRV0GPX9r2lq7FS2m5kCoyJCGgBo/pt1gHKeWnfFrFbbT?=
 =?us-ascii?Q?oID9H+CPeTdp13AfdG6YSeMnE/0wpQDazV83TlIlfT71WZMWsvggyEqLmZyT?=
 =?us-ascii?Q?aPAWzHI2n4Z7k5eKR5jbnjwGiVPOLFMA3A+o4tx3GwaAuSuO7TNoWbnqln6d?=
 =?us-ascii?Q?oLrBJBDWneU/FAXaPaxa9PJQlPWwyq7AcCqmtTQSgJuZbVAA7Mfopd8onanT?=
 =?us-ascii?Q?DjIrqF/FFs+oVJPzseZ6KkBCKZHRr+ZcluPqbLQ4S1lQ5GwrgGuFBYebUyNT?=
 =?us-ascii?Q?AjOzzriLwJiKgAVvlC47MLI=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28eb0f48-3d1b-433f-84cf-08d9fd86d76a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 02:29:43.3350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5a0xjABRwgP2IB0dLl57fQkxbKOkD1J7UoVjRij64bR7eZPY3WZIg9prEC+dtEhAfESDPLhAKIxvBoWKX21TpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0841
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 03, 2022 at 03:13:33PM +0200, Heikki Krogerus wrote:
> On Thu, Mar 03, 2022 at 10:47:57AM +0800, Xin Ji wrote:
> > On Wed, Mar 02, 2022 at 02:03:18PM +0200, Heikki Krogerus wrote:
> > > Hi,
> > > 
> > > This does not apply on top of Greg's latest usb-next branch. You need
> > > to rebase this. There are also a few more nitpicks below.
> > 
> > Hi, I didn't found tcpci.h in include/linux/usb/
> 
> I'm asking you to create the file.
> 
> So create a separate patch where you move the register definitions and
> command definitions from drivers/usb/typec/tcpm/tcpci.h to
> include/linux/usb/tcpci.h
Hi heikki, I'm confused, do you mean move total tcpci.h to
include/linux/usb/ directory or just move our driver patch used register
definitions and command to "include/linux/usb/tcpci.h"?

And I think the other way is, our driver patch just include
"tcpm/tcpci.h" is better(no need to create new file). What do you think?

Thanks,
Xin
> 
> thanks,
> 
> -- 
> heikki