Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dongli Zhang <dongli.zhang@oracle.com>
To:     netdev@vger.kernel.org, bpf@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
        joao.m.martins@oracle.com, joe.jin@oracle.com, dsahern@gmail.com,
        edumazet@google.com
Subject: [PATCH net-next v5 0/4] tun/tap: use kfree_skb_reason() to trace dropped skb
Date:   Thu,  3 Mar 2022 22:33:03 -0800
Message-Id: <20220304063307.1388-1-dongli.zhang@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jLzyKBgFqrywfqnCeg00oDSqAezRG6TUR/yl+pEY1pQMUFP11oCLKcNq1PWh?=
 =?us-ascii?Q?OTJXHdhSD6O4BE6oUDVeNtS68FqA/x891JnQ+vWYqClZkHaQE2ujzwwsDU6R?=
 =?us-ascii?Q?VvZ9bamQc9X8ad0Z7anh+C8LRxTcWI5f4XfgxZ7dHeq+ZutyUzS41KM2wfdN?=
 =?us-ascii?Q?m98n1QztjQwwV25P6D2sjyvHHfVGMpjvqqYnlhIO1g8I0MylJP5XDonChC0D?=
 =?us-ascii?Q?luWmx3jS8YHzBGYozdyUMvI1kQoWUqo/yGCUX06EREA9hq6wbNJYhDYhZQEp?=
 =?us-ascii?Q?OebUFVhnBPducq1AXXfa5ITq5AAlwmpkN5IdY/aljzsYi812X0WCrE/fjpYv?=
 =?us-ascii?Q?q3dSwcoIqOIZAPYkdJBCGMt51nx/zwCzZ2oEAEdDEGmpvrtWxcSdfcVqYP4f?=
 =?us-ascii?Q?+8WnIPfV/I3j/5kSHcX1Goql85+FqY2n/ayW/Ma/7A424xPttyWORNFuPRTr?=
 =?us-ascii?Q?Qeuvhcwf7bHxcXvvr40gB+Uj/VmwpV9SxhfWY50Mt5ETTsJwCCfqr9CuqYK/?=
 =?us-ascii?Q?A4VMEHL8f/MZL0O7RB5GazJA1YM5eqXUN+M2HQb6KFvM+R8Or9pyiWfkjCPs?=
 =?us-ascii?Q?/r/5I20goUu8sXqbru/K5pSDcfaFWxJqUpwcwBkibuuZ0tirWGmoQt+9ttjT?=
 =?us-ascii?Q?ZDJxK5Y/Iprx6qNQkG7pXP5b1iJQbD9mYRObGw4k6+8Y02IiWIAKimMzcUDZ?=
 =?us-ascii?Q?IH4NJT9/2tPUDIBO7lz/W/34gT3+ZdbHugehfWJFbj4xBCxXw/fFwJ/yL/6X?=
 =?us-ascii?Q?mkwwmb3FUusdUcq56WThHMR/31Vei2mTZa9MLL1J3NPArCe4aGCChU6SoIBX?=
 =?us-ascii?Q?Q2JYGseeJk/5E8ncoTUA1Y9U62g5ZU+f//FaxqAWH9gaSb8JmuPSK84kEMIT?=
 =?us-ascii?Q?9Eh5aeaFaVzTDU+gLa9qPE8y2vpC3jDbOiv0i6RjYV3GE4vNArJhWZjRps1x?=
 =?us-ascii?Q?aNRZkJbEA+iTTAL2BuEAqdsfO27/FYd4AysRQucxlPjOpogaJQdDW+3brxFV?=
 =?us-ascii?Q?r2MjWnZorr7cr3M/HDi0nYw4gep+V38yMzQXMOb+tBjoluqFAuDWurnX7W+z?=
 =?us-ascii?Q?mzDmuTfh8q539H/cqWtT2jPN+hHBUpXj5jKKHYCkZvx7bK4dRPzmm2KgvyNP?=
 =?us-ascii?Q?7wvH4kyAMvvGg51WJlmse7DFFYoheifyT7CuRzVY9/aoWzRLgDEVxKZ6ylf2?=
 =?us-ascii?Q?I8PaHZ+ejlriet+JAaAJDZsU+UTSP7lW4pP8BeR1joEOHFDM/VPPTOLV0G5X?=
 =?us-ascii?Q?GV1S/PiPLdyiPwmY1fwT4s9M27vxmbsCwM/GQGSzcSUXfkZC39+VW2ZUvu7s?=
 =?us-ascii?Q?Kza/QJUkuXAV4MTwxf17A2Vl/Nyz9XU54FVj/PXivgDnijmHZoj4/aqNIUbh?=
 =?us-ascii?Q?Vt04cRunYx2UWZfNrEC+irt6cHF7ByiFcxzDjLLSuX6XQdO2DT4fM7zbac3c?=
 =?us-ascii?Q?WG2+6T6UwfiKTBUPO4VPk4fWRaCzFZsOCFCoZ7cmCT6+pLLGWlJA3+ohwBYH?=
 =?us-ascii?Q?RceN15ILFgI2aJOAwsmP7ByGMNAW5A21Pn/6tysgwFYjy+ghZv9nPz4/GuRU?=
 =?us-ascii?Q?IP2KaHZZhmwdNF3DOzBjiXkzuqbszHuc7RYinRajIzC6OlxOwVg84gEv1Yqa?=
 =?us-ascii?Q?FyAnN5Wy3ycr/BKLMtIEINA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26ff2c9c-f23e-498b-bc76-08d9fda8ded7
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 06:33:18.6055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LrFqqulQ4M31ELZ8jJwx+uuxqAFujWlCQqqumoeMqvwaHS/deH4gN/tiQCASTL/sgaO3fkgZnWE+GGDtM0Dccg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4603
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10275 signatures=686983
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203040031
X-Proofpoint-GUID: QkblvfiVWbO1g8esSYWU5rlNJqe0Q69R
X-Proofpoint-ORIG-GUID: QkblvfiVWbO1g8esSYWU5rlNJqe0Q69R
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The commit c504e5c2f964 ("net: skb: introduce kfree_skb_reason()") has
introduced the kfree_skb_reason() to help track the reason.

The tun and tap are commonly used as virtio-net/vhost-net backend. This is to
use kfree_skb_reason() to trace the dropped skb for those two drivers. 

Changed since v1:
- I have renamed many of the reasons since v1. I make them as generic as
  possible so that they can be re-used by core networking and drivers.

Changed since v2:
- declare drop_reason as type "enum skb_drop_reason"
- handle the drop in skb_list_walk_safe() case for tap driver, and
  kfree_skb_list_reason() is introduced

Changed since v3 (only for PATCH 4/4):
- rename to TAP_FILTER and TAP_TXFILTER
- honor reverse xmas tree style declaration for 'drop_reason' in
  tun_net_xmit()

Changed since v4:
- make kfree_skb_list() static inline
- add 'computation' to SKB_CSUM comment
- change COPY_DATA to UCOPY_FAULT
- add 'metadata' to DEV_HDR comment
- expand comment on DEV_READY
- change SKB_TRIM to NOMEM
- chnage SKB_PULL to HDR_TRUNC


The following reasons are introduced.

- SKB_DROP_REASON_SKB_CSUM
- SKB_DROP_REASON_SKB_GSO_SEG
- SKB_DROP_REASON_SKB_UCOPY_FAULT
- SKB_DROP_REASON_DEV_HDR
- SKB_DROP_REASON_FULL_RING
- SKB_DROP_REASON_DEV_READY
- SKB_DROP_REASON_NOMEM
- SKB_DROP_REASON_HDR_TRUNC
- SKB_DROP_REASON_TAP_FILTER
- SKB_DROP_REASON_TAP_TXFILTER


This is the output for TUN device.

# cat /sys/kernel/debug/tracing/trace_pipe
          <idle>-0       [029] ..s1.   450.727651: kfree_skb: skbaddr=0000000023d235cc protocol=0 location=00000000a6748854 reason: NOT_SPECIFIED
          <idle>-0       [000] b.s3.   451.165671: kfree_skb: skbaddr=000000006b5de7cc protocol=4 location=000000007c2b9eae reason: FULL_RING
          <idle>-0       [000] b.s3.   453.149650: kfree_skb: skbaddr=000000006b5de7cc protocol=4 location=000000007c2b9eae reason: FULL_RING
          <idle>-0       [000] b.s3.   455.133576: kfree_skb: skbaddr=000000006b5de7cc protocol=4 location=000000007c2b9eae reason: FULL_RING
          <idle>-0       [000] b.s3.   457.117566: kfree_skb: skbaddr=000000006b5de7cc protocol=4 location=000000007c2b9eae reason: FULL_RING


This is the output for TAP device.

# cat /sys/kernel/debug/tracing/trace_pipe
          arping-7053    [006] ..s1.  1000.047753: kfree_skb: skbaddr=000000008618a587 protocol=2054 location=00000000743ad4a7 reason: FULL_RING
          <idle>-0       [022] ..s1.  1000.778514: kfree_skb: skbaddr=000000002c1e706c protocol=0 location=00000000a6748854 reason: NOT_SPECIFIED
          arping-7053    [006] ..s1.  1001.047830: kfree_skb: skbaddr=000000008618a587 protocol=2054 location=00000000743ad4a7 reason: FULL_RING
          arping-7053    [006] ..s1.  1002.047918: kfree_skb: skbaddr=000000008618a587 protocol=2054 location=00000000743ad4a7 reason: FULL_RING
          arping-7053    [006] ..s1.  1003.048017: kfree_skb: skbaddr=000000008618a587 protocol=2054 location=00000000743ad4a7 reason: FULL_RING


 drivers/net/tap.c          | 35 +++++++++++++++++++++++++----------
 drivers/net/tun.c          | 38 ++++++++++++++++++++++++++++++--------
 include/linux/skbuff.h     | 39 ++++++++++++++++++++++++++++++++++++++-
 include/trace/events/skb.h | 10 ++++++++++
 net/core/skbuff.c          |  7 ++++---
 5 files changed, 107 insertions(+), 22 deletions(-)


Thank you very much!

Dongli Zhang