Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        linux-mm@kvack.org (open list:MEMORY MANAGEMENT),
        linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK),
        linux-kernel@vger.kernel.org (open list)
Cc:     Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] userfaultfd/selftests: fix uninitialized_var.cocci warning
Date:   Fri,  4 Mar 2022 16:23:32 +0800
Message-Id: <20220304082333.9252-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L3bMJsFDBGVaDOe+YjcGCAzpk+bBjEHfJdzqdyE6rWjV+owO+0vSAVBPxjcI?=
 =?us-ascii?Q?rubGf5GtxcSAVbf+7XT97hO+Hviz3knwhbzk7RguTEbikLVkeGNawhNSzz/2?=
 =?us-ascii?Q?6xIHIKMxMOfvFPlPpW0RFhG89VQRVrIn1hu5UJOnLhV9F97DOaMhRCqQsAHa?=
 =?us-ascii?Q?r6t2mq/quDbzowHEoKmNWaq1kqSxedQiI9h0W5Q4bNdQBbYi6HYW8mKwVjp9?=
 =?us-ascii?Q?jtDb0Ezn3GJ0xMPpwZNrm+oP1dleLTnqqu/vqHp6aAyeC3FzwmYpT7flWcvx?=
 =?us-ascii?Q?3JcISu3qEEqDlwLIvbNfFDPVGFNUMO17x84ho8QnRz0+VVE5PTy1u4NMTIQ7?=
 =?us-ascii?Q?d4WwQyCz5uJd2PbWM263kcAX4Sb+fPF6OoTdkwaYvYchLvY91JyUcJ4r5IxA?=
 =?us-ascii?Q?v5ySCcyQa6+pECV/i1Fdcj/TlXr+EQfys6VU8kdAMy89jbquI/jrOgwRBp77?=
 =?us-ascii?Q?Csbcwt0ZyRfsOX5GjcE+AyCf/lft7knSn3W5FXbB2UgRxBRGa3XOBlwCgSzA?=
 =?us-ascii?Q?MfCOiF9OiGzEmLf3F5Ob7wWABtdmkn+4vJdcNNYNymxk6xqk7sQTnO1Wn8R2?=
 =?us-ascii?Q?ykLa08gMM2jIpL50K5pPW9dTyLdhdGJq3K8drZPQu9lf0oG4D4clDER39DAu?=
 =?us-ascii?Q?8dZuWcgssbgIKCEQZPZU1dLVfIOHrbrZkqd5vhuO/WNqmJi0ykw3FDZI2aDb?=
 =?us-ascii?Q?FZpJoKU4g0sgrGoe3k86AGtyHcgFoFeD17nkGwGqBnVNKI2NLyGm4Vl3bJPP?=
 =?us-ascii?Q?rNT3zP3lqBem+aJEClYN+Zjz5T8RjpNGrqAfOQMC4sN0m9hQYf0SvwK3wX1H?=
 =?us-ascii?Q?VwmlUAmgNm3mrDb/+dcHxFNb7qUOoTZMoV6UkvfO1pS3TUF5TNSgseQu5bOg?=
 =?us-ascii?Q?i/mEhOitTBIHFzdTnlXq7Z6djUICHA8JvTivxpSiQsiux18ZBCNkXm03bbRw?=
 =?us-ascii?Q?meHnJ1hN9w3eizD9j1h1Kr8NtZIkDCMS5/12uFDkcXW2xBbb98nRYF+Lt1jY?=
 =?us-ascii?Q?snX24zev+QAKLZtZWZrAEXcZNHVeDvxV1h5pMkSKeW4TNlnPBKEgeyTpKqKE?=
 =?us-ascii?Q?nQ9axKpNYNYpZSJeLKUEDSccW0xye6w3mfFdQu/76Gyh7narzyCRm3t6/ePa?=
 =?us-ascii?Q?KvdbXrCQKniyN08vJ1d2Qz1Op4I3zbUbJbosKdLykj12MJujPYtiMcM6Z6NF?=
 =?us-ascii?Q?y+MLE3QJDiDao/N0XdAfTIA4G6xYkGvl6halgudLF+DP9rAwGB9B7d+E9teT?=
 =?us-ascii?Q?9c4U4sIiGxyMHDOQ1qVGO5Y4VHroMMXm7JfdtUGB9k5zInTo+K3rgIux80b9?=
 =?us-ascii?Q?Ycl0J9FICD+gYXh+IxDCAZJ7YEjf0R1Lidn9KmD9nwMiAF/VnMlGEYyN6Eki?=
 =?us-ascii?Q?P7W0GBwf0Mmo8h7IfyvUnMCYQg7Mk5DpaB0W39CHxNCxmJr15llCB8+kZ1OH?=
 =?us-ascii?Q?+uVVODHBbSxK8acBQp6dmZ8Q1ubizEjQjwgu28Qj6vDJA5MIafnNA77DUy4O?=
 =?us-ascii?Q?W765BMEgwXuXnmPehH9mHhEDmdPqkyOQcnDQfx/cSXtxO05zasxIaKbnXF4C?=
 =?us-ascii?Q?o5ITwtEJQ5xNJ9CcinSA43l5a0WHlqOa3IO/UY8wuY4j79ncxt4FmuD6GYzN?=
 =?us-ascii?Q?MP7BEJhimLCju3p49CZwU+c=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bffcd8f-fcd3-447e-d5d0-08d9fdb854bf
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 08:23:59.1678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sVAwrjlod2jobgz6NL5mLANNAIfibddx1keXHO8tXaJGjdFN2QzhOIzeSXQ4LlhazMuDSV4wSW7RH2BF0BFF6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5160
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

fix following coccicheck warning:
tools/testing/selftests/vm/userfaultfd.c:556:23-24:
WARNING this kind of initialization is deprecated

`unsigned long page_nr = *(&page_nr)` has the same form of
uninitialized_var() macro. I remove the redundant assignement. It has
been tested with gcc (Debian 8.3.0-6) 8.3.0.

The patch which removed uninitialized_var() is:
https://lore.kernel.org/all/20121028102007.GA7547@gmail.com/
And there is very few "/* GCC */" comments in the Linux kernel code now.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 tools/testing/selftests/vm/userfaultfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
index fe404398c65a..203c4a2c2109 100644
--- a/tools/testing/selftests/vm/userfaultfd.c
+++ b/tools/testing/selftests/vm/userfaultfd.c
@@ -553,7 +553,7 @@ static void continue_range(int ufd, __u64 start, __u64 len)
 static void *locking_thread(void *arg)
 {
 	unsigned long cpu = (unsigned long) arg;
-	unsigned long page_nr = *(&(page_nr)); /* uninitialized warning */
+	unsigned long page_nr;
 	unsigned long long count;
 
 	if (!(bounces & BOUNCE_RANDOM)) {
-- 
2.20.1