Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dongli Zhang <dongli.zhang@oracle.com>
To:     netdev@vger.kernel.org, bpf@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
        joao.m.martins@oracle.com, joe.jin@oracle.com, dsahern@gmail.com,
        edumazet@google.com
Subject: [PATCH net-next v5 2/4] net: tap: track dropped skb via kfree_skb_reason()
Date:   Thu,  3 Mar 2022 22:33:05 -0800
Message-Id: <20220304063307.1388-3-dongli.zhang@oracle.com>
In-Reply-To: <20220304063307.1388-1-dongli.zhang@oracle.com>
References: <20220304063307.1388-1-dongli.zhang@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wvgoLWuePYptnIroTFXjMs2trM7wheiEFVFOq57XWq+RUM6gs+p6BC3NOsCb?=
 =?us-ascii?Q?oZUgjlYwM5Ft96eSfG6Ozg69GpiUJ+cW7sGKx5y1VB/QC+lwdpIFHxP14Kdm?=
 =?us-ascii?Q?VSYZjWstTCnfTsgXIQXhIm1vW/tdb0ymqblmdKn+nDIi2EI3ai44HwaGoANE?=
 =?us-ascii?Q?6MC6oUgYjskekFCD2PRuDBmP+vzA1iUzJHOwmu1D7FbQseXV5kMT03n0NneM?=
 =?us-ascii?Q?xTLl9HGUW6BTzn4jkpzxsiy6TWqrtkG//4dTRqr3MXzYbe+T30Q8SgjGyslo?=
 =?us-ascii?Q?IbEj9Eg2pJ9vi1i0m+ouvl+K0nsL3NPWm9wd6jPsoYjaxVbqy4IORoA+CyNp?=
 =?us-ascii?Q?e2vJx1q+dvFunuFmK09AFNd1a24fhvn8dXGBrHBMRMMnfBreWUb4CO8jqjAp?=
 =?us-ascii?Q?VfHITecOSkU+u2gw0qHX4ygjs2oHADD/27ytse6xy9XuKS9ehwimTteZA1iq?=
 =?us-ascii?Q?o/HSu8SJ90XrY8jqm/eXC3a4pv9wdJr/E72ZSVnnZ/26o0h7RMrmPbtEqtz1?=
 =?us-ascii?Q?bgzrcBLVYfvODXL2DJUbw7lZKwNwrYq6+KleZZLE/kBcQo3uI4VkGbxJjIy4?=
 =?us-ascii?Q?sEursTfiLYfl5dMHZSggYFvPmDYTx4fv9REwZrvih04lpg+pWh9kLWa2uQUH?=
 =?us-ascii?Q?UzeFzR+ECpwzikwTcuKwEZh/R7FyK9bNp5wbHag6Q/4pZ7RQSmQTIg1F74Em?=
 =?us-ascii?Q?6ryhJovZUyjwxSvgz2DEM4lLif8RUgor02n9OpGx0Hi25j97KLNnzp+wagn+?=
 =?us-ascii?Q?ueE+ripxVn0MWirhcEeMFt7hYSQ/Wgr95XDwlI0nB+HTe6XA8C4v56UJt4Eu?=
 =?us-ascii?Q?lsSoy0Knji8Swk8hxlNXs9AsOlIQcU1V00nu3a3VKDrOEzDXvuSkLPHcz5fS?=
 =?us-ascii?Q?HhR+FpUCNCRWkMBN0flSgLa4ZpvhiM3tCbbQDJvOuI60qzVrkMTct/ZYyH+h?=
 =?us-ascii?Q?G/NTK7Ze7XjzlnwvZP82IdOx3tjCy1wJqwNRGd5MkkiN5+Oy1pGV+cHLXVda?=
 =?us-ascii?Q?P+lYjkCq9a0OU//+oxkxipvn2MvITRgRpNjbd2oRTag9nrJKhIq3lW1yQgxU?=
 =?us-ascii?Q?ox7Xd05noNkqJft3u1PZN+dtuT+Bb1lbL1QUBjYdJDyHpH31gpxp0dU4hx28?=
 =?us-ascii?Q?SvQM04ruyFW3NsxVOuzvk6KgutF1I8ce6VTpAk8mLj//ppMxSINoxXyX8Ugx?=
 =?us-ascii?Q?8o+5FPZ37hEStlJuqA4W+8CirhJdLV3l+OCQcrngcB45TLFpI0WoMse74lnX?=
 =?us-ascii?Q?DOiW4pLR+c3Z6y4Gs9jesq3b7dGoZLUNoBY97eme2mC5d9t9t3yuo7JO7Dhn?=
 =?us-ascii?Q?LgPYdJ0FweULD1qf4rV3V7e3XhPrOlxnDXDI3fB2Jloy26IJXouu58kXSCRu?=
 =?us-ascii?Q?GEycvMzRpBJdRN+3fSw2dWV+k3GZQ6dOI8r6Nc0XS82iPRsvOa5V287pRM3s?=
 =?us-ascii?Q?w92Yl8irmFvgCnr3pRtDNbFCCD83fa4UOF6uQXraPyy1psDpcVBU0YHyn/7S?=
 =?us-ascii?Q?wDPVCvA2DFpc74x44yHIkt89l5+BqNBwWbLEV4bEzDg8p3KNRQUR1Vtb+l/I?=
 =?us-ascii?Q?KJfjU8hHik1ws5ERXeM291zezvqMW6BiD53Bz2JYDEKwC43R30jab2zOxySt?=
 =?us-ascii?Q?pAIW/rxLptOSWwt1omwtTbY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d84bde0-36c7-4abc-bf98-08d9fda8e10c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 06:33:22.3240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ff4q/TRW/jX5lwgvXvx+jzfIG82APFiAsIHYOrzk4g7Mq2XXld8c5lcj2xou5kcsJdxlxC91WP6kzpj/iGbLbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4603
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10275 signatures=686983
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0
 malwarescore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203040031
X-Proofpoint-ORIG-GUID: 5nMh1HXMf75N2yo2w1GoiqOhgPhB40Zn
X-Proofpoint-GUID: 5nMh1HXMf75N2yo2w1GoiqOhgPhB40Zn
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The TAP can be used as vhost-net backend. E.g., the tap_handle_frame() is
the interface to forward the skb from TAP to vhost-net/virtio-net.

However, there are many "goto drop" in the TAP driver. Therefore, the
kfree_skb_reason() is involved at each "goto drop" to help userspace
ftrace/ebpf to track the reason for the loss of packets.

The below reasons are introduced:

- SKB_DROP_REASON_SKB_CSUM
- SKB_DROP_REASON_SKB_GSO_SEG
- SKB_DROP_REASON_SKB_UCOPY_FAULT
- SKB_DROP_REASON_DEV_HDR
- SKB_DROP_REASON_FULL_RING

Cc: Joao Martins <joao.m.martins@oracle.com>
Cc: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Changed since v1:
  - revise the reason name
Changed since v2:
  - declare drop_reason as type "enum skb_drop_reason"
  - handle the drop in skb_list_walk_safe() case
Changed since v4:
  - add 'computation' to SKB_CSUM comment
  - change COPY_DATA to UCOPY_FAULT
  - add 'metadata' to DEV_HDR comment

 drivers/net/tap.c          | 35 +++++++++++++++++++++++++----------
 include/linux/skbuff.h     | 13 +++++++++++++
 include/trace/events/skb.h |  5 +++++
 3 files changed, 43 insertions(+), 10 deletions(-)

diff --git a/drivers/net/tap.c b/drivers/net/tap.c
index ba2ef5437e16..c3d42062559d 100644
--- a/drivers/net/tap.c
+++ b/drivers/net/tap.c
@@ -322,6 +322,7 @@ rx_handler_result_t tap_handle_frame(struct sk_buff **pskb)
 	struct tap_dev *tap;
 	struct tap_queue *q;
 	netdev_features_t features = TAP_FEATURES;
+	enum skb_drop_reason drop_reason;
 
 	tap = tap_dev_get_rcu(dev);
 	if (!tap)
@@ -343,12 +344,16 @@ rx_handler_result_t tap_handle_frame(struct sk_buff **pskb)
 		struct sk_buff *segs = __skb_gso_segment(skb, features, false);
 		struct sk_buff *next;
 
-		if (IS_ERR(segs))
+		if (IS_ERR(segs)) {
+			drop_reason = SKB_DROP_REASON_SKB_GSO_SEG;
 			goto drop;
+		}
 
 		if (!segs) {
-			if (ptr_ring_produce(&q->ring, skb))
+			if (ptr_ring_produce(&q->ring, skb)) {
+				drop_reason = SKB_DROP_REASON_FULL_RING;
 				goto drop;
+			}
 			goto wake_up;
 		}
 
@@ -356,8 +361,9 @@ rx_handler_result_t tap_handle_frame(struct sk_buff **pskb)
 		skb_list_walk_safe(segs, skb, next) {
 			skb_mark_not_on_list(skb);
 			if (ptr_ring_produce(&q->ring, skb)) {
-				kfree_skb(skb);
-				kfree_skb_list(next);
+				drop_reason = SKB_DROP_REASON_FULL_RING;
+				kfree_skb_reason(skb, drop_reason);
+				kfree_skb_list_reason(next, drop_reason);
 				break;
 			}
 		}
@@ -369,10 +375,14 @@ rx_handler_result_t tap_handle_frame(struct sk_buff **pskb)
 		 */
 		if (skb->ip_summed == CHECKSUM_PARTIAL &&
 		    !(features & NETIF_F_CSUM_MASK) &&
-		    skb_checksum_help(skb))
+		    skb_checksum_help(skb)) {
+			drop_reason = SKB_DROP_REASON_SKB_CSUM;
 			goto drop;
-		if (ptr_ring_produce(&q->ring, skb))
+		}
+		if (ptr_ring_produce(&q->ring, skb)) {
+			drop_reason = SKB_DROP_REASON_FULL_RING;
 			goto drop;
+		}
 	}
 
 wake_up:
@@ -383,7 +393,7 @@ rx_handler_result_t tap_handle_frame(struct sk_buff **pskb)
 	/* Count errors/drops only here, thus don't care about args. */
 	if (tap->count_rx_dropped)
 		tap->count_rx_dropped(tap);
-	kfree_skb(skb);
+	kfree_skb_reason(skb, drop_reason);
 	return RX_HANDLER_CONSUMED;
 }
 EXPORT_SYMBOL_GPL(tap_handle_frame);
@@ -632,6 +642,7 @@ static ssize_t tap_get_user(struct tap_queue *q, void *msg_control,
 	int depth;
 	bool zerocopy = false;
 	size_t linear;
+	enum skb_drop_reason drop_reason;
 
 	if (q->flags & IFF_VNET_HDR) {
 		vnet_hdr_len = READ_ONCE(q->vnet_hdr_sz);
@@ -696,8 +707,10 @@ static ssize_t tap_get_user(struct tap_queue *q, void *msg_control,
 	else
 		err = skb_copy_datagram_from_iter(skb, 0, from, len);
 
-	if (err)
+	if (err) {
+		drop_reason = SKB_DROP_REASON_SKB_UCOPY_FAULT;
 		goto err_kfree;
+	}
 
 	skb_set_network_header(skb, ETH_HLEN);
 	skb_reset_mac_header(skb);
@@ -706,8 +719,10 @@ static ssize_t tap_get_user(struct tap_queue *q, void *msg_control,
 	if (vnet_hdr_len) {
 		err = virtio_net_hdr_to_skb(skb, &vnet_hdr,
 					    tap_is_little_endian(q));
-		if (err)
+		if (err) {
+			drop_reason = SKB_DROP_REASON_DEV_HDR;
 			goto err_kfree;
+		}
 	}
 
 	skb_probe_transport_header(skb);
@@ -738,7 +753,7 @@ static ssize_t tap_get_user(struct tap_queue *q, void *msg_control,
 	return total_len;
 
 err_kfree:
-	kfree_skb(skb);
+	kfree_skb_reason(skb, drop_reason);
 
 err:
 	rcu_read_lock();
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index bb00f86791e0..e5d5371a543b 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -394,6 +394,19 @@ enum skb_drop_reason {
 						 * entry is full
 						 */
 	SKB_DROP_REASON_NEIGH_DEAD,	/* neigh entry is dead */
+	SKB_DROP_REASON_SKB_CSUM,	/* sk_buff checksum computation
+					 * error
+					 */
+	SKB_DROP_REASON_SKB_GSO_SEG,	/* gso segmentation error */
+	SKB_DROP_REASON_SKB_UCOPY_FAULT,	/* failed to copy data from
+						 * user space, e.g., via
+						 * zerocopy_sg_from_iter()
+						 * or skb_orphan_frags_rx()
+						 */
+	SKB_DROP_REASON_DEV_HDR,	/* device driver specific
+					 * header/metadata is invalid
+					 */
+	SKB_DROP_REASON_FULL_RING,	/* ring buffer is full */
 	SKB_DROP_REASON_MAX,
 };
 
diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
index 1977f301260d..9d91ec9755b8 100644
--- a/include/trace/events/skb.h
+++ b/include/trace/events/skb.h
@@ -45,6 +45,11 @@
 	EM(SKB_DROP_REASON_NEIGH_FAILED, NEIGH_FAILED)		\
 	EM(SKB_DROP_REASON_NEIGH_QUEUEFULL, NEIGH_QUEUEFULL)	\
 	EM(SKB_DROP_REASON_NEIGH_DEAD, NEIGH_DEAD)		\
+	EM(SKB_DROP_REASON_SKB_CSUM, SKB_CSUM)			\
+	EM(SKB_DROP_REASON_SKB_GSO_SEG, SKB_GSO_SEG)		\
+	EM(SKB_DROP_REASON_SKB_UCOPY_FAULT, SKB_UCOPY_FAULT)	\
+	EM(SKB_DROP_REASON_DEV_HDR, DEV_HDR)			\
+	EM(SKB_DROP_REASON_FULL_RING, FULL_RING)		\
 	EMe(SKB_DROP_REASON_MAX, MAX)
 
 #undef EM
-- 
2.17.1