Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jiasheng Jiang <jiasheng@iscas.ac.cn>
To:     ckeepax@opensource.cirrus.com
Cc:     lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, patches@opensource.cirrus.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: Re: [PATCH] ASoC: wm8350: Handle error for wm8350_register_irq
Date:   Fri,  4 Mar 2022 10:41:12 +0800
Message-Id: <20220304024112.391990-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, Mar 03, 2022 at 09:38:34PM +0800, Charles Keepax wrote:
>>  	if (ret != 0)
>> -		return ret;
>> +		goto err;
> 
> I would probably just leave this as a return, nothing is gained
> changing it to a goto.
> 
>>  
>> +	ret = wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_R,
>>  			    wm8350_hpr_jack_handler, 0, "Right jack detect",
>>  			    priv);
>> -	wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_MICSCD,
>> +	if (ret != 0)
>> +		goto free_JCK_DET_L;
> 
> Probably better to use non-caps here, having caps in a label is a
> little unusual.

Thansk, I have submitted v2 to solve the problems.

Jiang