Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 04 Mar 2022 09:51:25 +0100
Message-ID: <s5hsfryrtgy.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] ALSA: echoaudio: remove redundant assignment to variable bytes
In-Reply-To: <20220302170728.1094633-1-colin.i.king@gmail.com>
References: <20220302170728.1094633-1-colin.i.king@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 02 Mar 2022 18:07:28 +0100,
Colin Ian King wrote:
> 
> The variable bytes is being assigned a value that is never read, it
> is being re-assigned inside a following if block. The assignment is
> redundant and can be removed.
> 
> Cleans up clang scan build warning:
> sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored
> to 'bytes' is used in the enclosing expression, the value is never
> actually read from 'bytes' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied.


Takashi