Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e25e595-cccb-0970-67b3-fc215bfd5b14@amd.com>
Date:   Fri, 4 Mar 2022 09:10:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] i2c: at91: use dma safe buffers
Content-Language: en-US
To:     Wolfram Sang <wsa@kernel.org>, Michael Walle <michael@walle.cc>,
        Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        stable@vger.kernel.org
References: <20220303161724.3324948-1-michael@walle.cc>
 <fff424e7-247c-38d8-4151-8b0503a16a7d@amd.com> <YiHIIjSs03gDJmHV@shikoro>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <YiHIIjSs03gDJmHV@shikoro>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXNrS25BcVB6K0VkdEcrQ29qMzU4YXFtc3F2Y1M3d2tGbjRsUFJzVzBIL3dB?=
 =?utf-8?B?S1pKUlcwK0p6emVsRWtHaDhzY0xlTm5FSENMcDlhN29PcWxYRTJFemNobktZ?=
 =?utf-8?B?OFNVa21udUQyWVRJRHJaL2JPVWJUdkpHTmZLd25kSkR1cUhrMVA2aTcyYkoz?=
 =?utf-8?B?MmxEVFJWaCt0RlFjYjlvYUpMMHJvQXF4Yk9NbExkZFM0dVVzS3hpS3JMbFhz?=
 =?utf-8?B?VHJ0aG1WVlRpYUZ2QllUbkVmRi9QbHVmdnRUSDFSRC8zWVE2NnZqMmJjMDJZ?=
 =?utf-8?B?dFBYaDI5akJZY2JFOXExM2Nwam9HdWIwTkxEc0d5OEVDYTE2V2kzbUxyQ2Qw?=
 =?utf-8?B?dC9XcWE1MEF6b3NtNlRWbUg4YWZkK1pQeXJJSmxoYnFzVTVtMzI1QmEyWkVR?=
 =?utf-8?B?eWtsTnp0Vy90ODZvY1d2SUxXamZuMlhEL3dBNy8vT0pHWGRRTzFyYVYzQ3Qv?=
 =?utf-8?B?UDRSaWZnY0U5a2VuV1ZYbjhYR3lrYkVZVHIvT1RoOURVdnRmM2RsSHIxT3o4?=
 =?utf-8?B?dGVwMk5qRGsreXJ4T3RhSEwvaCtpUlVQVmV4WHUzR3F4c2Z2V3Z4WnJ0UUwz?=
 =?utf-8?B?NFVXTmlaNzFqOFVTK1FnOWZuckNIYTIydE0vWXp4MzBrOFpQVFRodWtZOGZw?=
 =?utf-8?B?WktiSk5WcTlIYktGdlFzbzRjaFdrZ21CQkR6enNQUWs1bFNVSTNaeGJnZXlX?=
 =?utf-8?B?SG0wOGtIVU8rcTBIcVViamYrcDdSYTdoYko2T2hrODVZNldsS2QrY0RGOXk0?=
 =?utf-8?B?WTRVV1QyMW1aNFBNcDUvZWkxNExiNnVneWh4TGh4ejdSV2xKUkgxY2F0N21u?=
 =?utf-8?B?a2dvWjVNcEhod05vNFFHV2VYakdaOE5FNXZGN0JOZExzNWIvbHBlQWpTamlr?=
 =?utf-8?B?aVd6RUF1Q2kyZWpKK1FlL3l6WVc3Y210dTlzcmFxTVk4SHVDbWk4WjFXc3FH?=
 =?utf-8?B?RVlCMUdmK0R6VkJuYnhZaHNRWXRHL1BjV2xSMEJ4WGpxS2FiZmdMSCtBdzVH?=
 =?utf-8?B?Ry8wb1RLeDlORk5pMElid1V2SXF6aDdVU3FRaTJDMHF0UlpsRzByNmY2RWRq?=
 =?utf-8?B?QWZaajhwTklGK015ZjFBaVI1YzFaQzl2WjlxK2ZsVGc0cU1Tam1DRXNlZWt4?=
 =?utf-8?B?aFZZcU9zWDJseUVpMjhMcHlrNVlmNEE5WkNlVHMxd0JwRkh0d05pK0l0U0F6?=
 =?utf-8?B?VHI5UkpmZTZGcGczdG1LM2FpUC93amwwOS9qaXZCSjNzSTN3ZkhLNWpXaGVs?=
 =?utf-8?B?elFDZXpFRGRGS3J4SFJOT0l1eWxJcmg1Nmh3SmpjOFplN3FFdWxTUVVmaDFS?=
 =?utf-8?B?Mlo4VHV4Y3ZnRHFGcEs3NDdNWjhOUmpnaUljWUEvVnk3Z1R1OTNPaE5UR3gr?=
 =?utf-8?B?SGszckdXcEJhNGFMdTBESDhEbzhub2RBdnFLUnVpZ0plZUxKWnpoVnU2SHpa?=
 =?utf-8?B?QldLL0tIZ3JBOFFER0F5eDBGZ2dFYkZsc1ZnR1VaN24vdWtabDdXRFczT0Q1?=
 =?utf-8?B?enZHS2N5MllYR05CbytIWE4wM1k5K3NhMlNJeU5BQ2dNTDhpM0d3SW9ybzcv?=
 =?utf-8?B?SUMxQUVmenduU3JmMmhQSGg1ekpWbW1jbVRnamJTQ3loTkZzVy9mRWdQVHZz?=
 =?utf-8?B?STRQb0M2bXJUYVByeHFXdGRaUkJwVklXT1Zxdm5nOGZVNzVtUHdNT3p6MmFL?=
 =?utf-8?B?ZEhodDNiYVZQWnBrSURPVmgzQU9jVDJTbTR5dGwya3g2cUlPUnFIY2RLMlAr?=
 =?utf-8?B?S0hPdUw3Q1d6aUdTKzE3ckwwczJOalZmTnZhY3hvTnM3MWkzSU5TeTJ3VWFr?=
 =?utf-8?B?TEptRGYwNFZINDdWTmowLzdjNUovOGxoTmZuTFNnQjVtRjNsWVFTZFplQXNh?=
 =?utf-8?B?R2VCOWdRaHk2R010dmdPcjRTeU9wLzlhUHJUd1hGN0hxekFHa2E2dmpjUUQx?=
 =?utf-8?B?Wno4bjhLeCtMNFFXWVZBdHBaSVpWaU9rdFR4cVV3blY5RWFEY3UrVXlRSTU0?=
 =?utf-8?B?SThvcWlKOUY3dnZqZ002Rk5lbDB1ZTZUK2t0RmJpbWtEaXNObFJBMW45eU4w?=
 =?utf-8?B?S3pNenB1SVNLZjZCOThFWVJzZmt3c2JxU3h1MktUTWMxK3Y4ZDU0d2YvQjFZ?=
 =?utf-8?Q?pjS4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1c5f600-518d-4a61-06d6-08d9fdb6884b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 08:11:06.4785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zNGTFvnf/GNOmGMVgf/iLOW7uA5WgvxggWicxWcBFeN4tUvyK8+VIhzxTU3iHGbd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5933
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 04.03.22 um 09:04 schrieb Wolfram Sang:
> Hi Christian,
>
>> Maybe call your variable differently. DMA-buf is an inter driver buffer
>> sharing frame we use for GPU acceleration and V4L.
>>
>> It doesn't cause any technical issues, but the maintainer regex now triggers
>> on that. So you are CCing people not related to this code in any way.
> Frankly, I think the 'dma_buf' regex is a bit too generic. 'dma_buf'
> seems like a reasonable name to me if some subsystem has to deal with
> different buffers which can be DMA or non-DMA, like I2C. If you git-grep
> the tree, you will find it in quite some places.
>
> We could now think of renaming the variable to 'dmabuf' but this is
> a strange and kind of arbitrary rule to remember IMO.
>
> I wonder if you'd miss a lot of patches if we remove 'dma_buf' from the
> regex and keep 'dma_fence' and 'dma_resv'? Or extend it to 'dma_buf_' or
> 'struct dma_buf'?

Yeah, I'm already considering something similar for a while.

I'm getting quite a bunch of unrelated mails because the regex is not 
the best.

On the other hand the framework is used in a lot of drivers and I do 
want to be notified when they mess with their interfaces.

Going to take a another look at that when I have time.

Thanks,
Christian.

>
> All the best,
>
>     Wolfram
>