Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
        "'Daniel Lezcano'" <daniel.lezcano@linaro.org>,
        "'Thomas Gleixner'" <tglx@linutronix.de>,
        "'Rob Herring'" <robh+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>
In-Reply-To: <20220225153650.289923-3-krzysztof.kozlowski@canonical.com>
Subject: RE: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to
 MCT
Date:   Fri, 4 Mar 2022 16:27:12 +0530
Message-ID: <000201d82fb6$9b672090$d23561b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQJxTl5cVJJB5hst+orov2J0YUHPrQLp50vPAtRiSaerTt2kcA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20220225153650.289923-1-krzysztof.kozlowski@canonical.com>
        <CGME20220225180502epcas5p4a8126555d09513b92fb1947669529176@epcas5p4.samsung.com>
        <20220225153650.289923-3-krzysztof.kozlowski@canonical.com>
Precedence: bulk


>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Friday, February 25, 2022 9:07 PM
>To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
><tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski@canonical.com>; Alim Akhtar
><alim.akhtar@samsung.com>; linux-kernel@vger.kernel.org;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Subject: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to MCT
>
>One compatible is used for the Multi-Core Timer on most of the Samsung
Exynos
>SoCs, which is correct but not specific enough.  These MCT blocks have
different
>number of interrupts, so add a second specific compatible to Exynos5433 and
>Exynos850.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 3 ++-
>arch/arm64/boot/dts/exynos/exynos850.dtsi  | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>index 661567d2dd7a..017ccc2f4650 100644
>--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
>@@ -806,7 +806,8 @@ tmu_isp: tmu@1007c000 {
> 		};
>
> 		timer@101c0000 {
>-			compatible = "samsung,exynos4210-mct";
>+			compatible = "samsung,exynos5433-mct",
>+				     "samsung,exynos4210-mct";

Just a though, do we still need to keep Samsung,exyno4210-mct compatible?
In anyway:

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> 			reg = <0x101c0000 0x800>;
> 			interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> 				<GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
>diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi
>b/arch/arm64/boot/dts/exynos/exynos850.dtsi
>index d1700e96fee2..12f7ddc6fd0a 100644
>--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
>+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
>@@ -181,7 +181,8 @@ chipid@10000000 {
> 		};
>
> 		timer@10040000 {
>-			compatible = "samsung,exynos4210-mct";
>+			compatible = "samsung,exynos850-mct",
>+				     "samsung,exynos4210-mct";
> 			reg = <0x10040000 0x800>;
> 			interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>,
> 				     <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH>,
>--
>2.32.0