Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1974577pxm; Fri, 4 Mar 2022 07:09:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJzp5SdHFu0agEYXBe7YGVzalfJgqKw0SK9n58Nu82/Ob02R/kXgnbszA88o9C8LNtdUsThP X-Received: by 2002:a17:902:9690:b0:14f:fc09:fd02 with SMTP id n16-20020a170902969000b0014ffc09fd02mr40425694plp.66.1646406545632; Fri, 04 Mar 2022 07:09:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646406545; cv=none; d=google.com; s=arc-20160816; b=vSVvVm/IQZnHH29TGkQNSsNpDCDEXdzanfZDp4CmGWDdqmdyRqnTpG+LdnxbN5PLg/ v4a03mvrDOwSDLrXD9y+Y4GOJdoG74XvmzwE+0R6Atpyx30jPsF99Oz5mI3syT7R7yRx o/bictlNsI5LHFC4QdbpVq+lEmXbjWopuYfNBEiH7U7FjcSaBNfC1mocvP0Juisz7c+u k5gGV5kV4geaL/KJZTtNDnJMCpRVAWbX5VVv/pFC0pW185aHq0Lbsy3JOPPvLQsR11Bu 5CwoOcvFmUsiZXJuOIxas4IlOflOElBOjPOHMqfEYcSJD7qr8cGfcT03SxpTYkMwkoIy 16BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=KSebtyyRf30BTfF5Bhq3cmTJEd13K2ShT4ls/huBX3g=; b=rENzcKWDwoC88xIOKHIhB9W8XkpG1kvCJ/CJ7G7LfGWLZMyk0z8OqNIkolgC3WURw2 L0IV4B9cbI9Zr1RFEC0wWzlehzvuiTz88avBIhTSfUjE8QJ+uYBJhN2cAfSygLKM7NXg sQBu+DHE/zlo7X1U3Oc4SZwzbGo7cGxDj1NYsuAAXgXHuUpN0AFLinAk2m/v0PG+25Mi ikrRsjyowaqxV2+8LD3pF3j+Z4FVMkSX/tOKliEuf09LX8nytslRclB7Ufji0GiGL6c2 k4fEwby7fUKWx4UU6PsblVKsGZ4xpP+fr6Vs0/VYDFg6QD1V06sq0VeZqOVGQQ2om+BV StiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=R+0oKKBC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t69-20020a638148000000b0037c996f5056si1733955pgd.735.2022.03.04.07.08.48; Fri, 04 Mar 2022 07:09:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=R+0oKKBC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233844AbiCDMmQ (ORCPT + 99 others); Fri, 4 Mar 2022 07:42:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233456AbiCDMmN (ORCPT ); Fri, 4 Mar 2022 07:42:13 -0500 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8AE51B3A59; Fri, 4 Mar 2022 04:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646397685; x=1677933685; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tZrjSMkfDyWAM7wbgcIABphTmPYo+UOvDzf3GPP57ow=; b=R+0oKKBCnyJDqjegr5ATZSEOhYBYNz/+bDiXoQ6O+9U5+1KlKP+iXMg3 cWhcbPOs8G4QTSsrl/l5L6+R4PM42LEWMX2wNBysnWGNiCTfg7V0A8czU Kk0HrIW7hC2Twq04bt0PDVT9hxCxdbsOjczekBXPvl89MgprPO9he66Qz t2zNW5WNVcIqKibSS62RF9+HBkE9a9DEPuXdLLv9mhSsj4y2vJ/YVK/TM 1bbx95mlDKbUMQjXokZPeNi+gAC8AOEWwUaZTFP2+ASLbRkydxZMB2qFo NukUM/N1PKghDhW9PwS1OFqS1XP7i6l+cPSPsmgjMDlgiAJRMfm2GDaKC w==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="314682514" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="314682514" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 04:41:25 -0800 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="642499892" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 04:41:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nQ7Eb-00BDer-WF; Fri, 04 Mar 2022 14:40:38 +0200 Date: Fri, 4 Mar 2022 14:40:37 +0200 From: Andy Shevchenko To: Horatiu Vultur Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, colin.foster@in-advantage.com Subject: Re: [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing Message-ID: References: <20220303203716.3012703-1-horatiu.vultur@microchip.com> <20220303203716.3012703-3-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303203716.3012703-3-horatiu.vultur@microchip.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 09:37:16PM +0100, Horatiu Vultur wrote: > In the blamed commit, it removes the duplicate of_node assignment in the > driver. But the driver uses this before calling into of_gpio_dev_init to > determine if it needs to assign an IRQ chip to the GPIO. The fixes > consists in using of_node from dev. ... > - irq = irq_of_parse_and_map(gc->of_node, 0); > + irq = irq_of_parse_and_map(info->dev->of_node, 0); Why platform_get_irq() can't be used? -- With Best Regards, Andy Shevchenko