Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3918fcc-3132-23d0-b256-29afdda2d6d9@amd.com>
Date:   Fri, 4 Mar 2022 09:39:16 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v11 44/45] virt: sevguest: Add support to get extended
 report
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20220224165625.2175020-1-brijesh.singh@amd.com>
 <20220224165625.2175020-45-brijesh.singh@amd.com>
 <YiDegxDviQ81VH0H@nazgul.tnic> <7c562d34-27cd-6e63-a0fb-35b13104d41f@amd.com>
 <YiIc7aliqChnWThP@nazgul.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
In-Reply-To: <YiIc7aliqChnWThP@nazgul.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2NwMmUzOVQyY3hPcnNXdmFXQW9rK2p4UUZjSVFEU3ppL0NYL3ZjRXQrMDJa?=
 =?utf-8?B?NHYwRW41a0V3b1dQK2NzS1pLVDJWQ28xcWdyVlB6c1JOUFF0NFo3Rm9VWjRZ?=
 =?utf-8?B?bmRtbWIzWFhPaDFsaDdOclR6WTVnWTZsd290V2Z6N0hsbkpFZi9qMmFsei80?=
 =?utf-8?B?dzFFSnE3alkyYVJwM3JYN2c0OVBKTEE3RmFtMGkzR2xSc3h1bVJEMHNlWmc4?=
 =?utf-8?B?VWNlbjZGTFkySWxuRjUzeGJFcUJmTS85K2hMd09FMFFOdnlUWG5hbTFaNE9X?=
 =?utf-8?B?WXNUd2Y0WURZZVA0MmxMK3hFMFQ0eWhxN2x3eUw2UWtsSmxibWQyYlgyWEUw?=
 =?utf-8?B?TTBOZFNIUWN3U0RWNS8wbWZqeHJxTTZDUk1nWkxYakN1c1FQbE9yTHJEbCtl?=
 =?utf-8?B?a2x4b2JFR1VBQ2w2MTJQQUVFbHZWb1BPQTlNZzl2bEUxcTdScUh6VDZLeW9i?=
 =?utf-8?B?c3gvdEMxck9UcFRkWlZUcFBHOFE1Z1VwQUNKK2gxSjdEYWdVbWFHOGJjcjIy?=
 =?utf-8?B?V1lkS3A5TEdEUEJEMHdGNmwyeFVPSzA0RWFsZW54enhvcGVOMVNkUVR1WWJ5?=
 =?utf-8?B?b3BaSVVYWjhTSVJyN0VjRWFwcGtuVURncVBpd1ZySzgxZktGOTEvSTRjS0pW?=
 =?utf-8?B?VzQ4RUM3cEMwd1VsS3JkbDUwV3lXTndJK1Y3ZHpXbDZWYkVBL3NvQW1nN1Rx?=
 =?utf-8?B?NXJ2ZVVpN2htcmxweGl2RWt5T0tlZW1sK1BlWTJiRytzendXOUdZUDBPNCtw?=
 =?utf-8?B?VTZ6OUxiOFZnQkZMVC9wZVBhVkVLV3RqbCsxdjU5VGJOWmJqejlPaHltMER6?=
 =?utf-8?B?ZkRJc2pPSCtJd01tRnc3NWNWKytPTHFhWmI4MllSVzdVQmxRSHYvVTRGRFV2?=
 =?utf-8?B?ZVB6L3VSUEZkQnhmNE9pZ2Vyc21RYVdLcTlKYmprY3EzQm5NbXFmWnVLaGRE?=
 =?utf-8?B?QzlUUmxPVTRZeVUwRUhLQ3JDQ2dGVElhWWJudENBSHc5d2hpQVRQeVFqUThy?=
 =?utf-8?B?bE5hUExmaTJYTGxuY3cyNnJjZmc0RFFESGlDckVGMTd3L2FYcGQzRnVnbWtx?=
 =?utf-8?B?RzJ6OS9ObXpyc3oxeml1MkxhUDQvZUIxalVSWnBZbVNWQzUxeHF6bTBWUmo3?=
 =?utf-8?B?VS9YNHNZc2RTb3dKNSsrUGU1SkJKZDdnUHB6bGx1b2podEY0NjZodUo0KzBu?=
 =?utf-8?B?clZhUFQrUFJib2Q5N0oyZFNvU1YvbXhrVUZ6aVhhYjgxdjNDbUlhVjJqZ1Av?=
 =?utf-8?B?STZ6c3NQQzlMTXFONTBZNTA1b0ZBNk9WWnNjaFhGeGJVVmxSeUVqVmRKVGdE?=
 =?utf-8?B?NWJsejYwTWgxdDhEVktGaHlZUlE5bEwyQVlZMGQ5c0N2QXVTYURHZzZBdXFK?=
 =?utf-8?B?RHVYeExjSEZXYWtwVnFVN1dQbkJDWDQwbi9lN1ZMeE1zaXRFZUJtMExvRmpl?=
 =?utf-8?B?MGtSTXQyM1Uxc2k4NHliU2xGaWF0N0V4ZmxnTWZTQ2RUWkZQUnl4aUJGU0k0?=
 =?utf-8?B?UWZETW4wRWVrMHNBK0tMWTcvRzB1UGN5bXhRR21TcGNVZHl3TTVOdWtkem41?=
 =?utf-8?B?RnhCRGV2dWF0WFFvNERoOGdkSVNKTUJML0F1VTlob0ZkWGN5VzVhdnR0Z0pt?=
 =?utf-8?B?QXAzem11NlBOeXYxa0JlTWoxaXRGWHhUNlhDb1pGZEdWZ3JjbDFwTng0dFE0?=
 =?utf-8?B?R1dtSTlRNklUYnNKS2hQaldxL3lHbUloWkZnckVIU2JOWkFNWW45MmIzR2Nk?=
 =?utf-8?B?ck8reStPNTFPcTczekcvUldEMUx4MlR2Q2F3eVpaeDRZZ1V4cE5IQ2xyZFNy?=
 =?utf-8?B?TlBxbHA5SEFwZGVKM0dPbWE3SlhNZDlwUUNHRXFiZ3dwREczaS9SOW9UNFow?=
 =?utf-8?B?ZVhMN0lHTEVFL2dsdVAxQ1NvcjI2dWRRWDhadnBOaXljRGpNcXN6VVE5TSs0?=
 =?utf-8?B?TFdqVFRYL2dSTUh5RW1vYTlPYzRFT0RRa2hTdzJ6RXRRQXhrYS92WlYrQ29m?=
 =?utf-8?B?bW95RlRreVFhTnVrcG9NVnllcGxibGlDbXRJWUk3ZWVWMVN2MFRsdGp3eFhT?=
 =?utf-8?B?eGpoQlNETWYyVUpmMjQveng5MmNwUVE0cEt2cjZFTmh4UGpvUS9zNi85c1hV?=
 =?utf-8?B?RnFTODBUNm1yMzhielhGNUVZYnFLcjFHV0NsZ0JFTHVFeWRKUXFvWjNBMVg3?=
 =?utf-8?Q?S6P0rmRRaZc+31lMhQ8GsyQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9df500c4-65cf-403a-0c3d-08d9fdf527fd
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 15:39:23.1064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pj6m1VVMmD0iHzyO7Z0wUR/lrKaTvB0NAJnDDHZMFAZLgg/66WHJk0aaYeYLaOl07IgBcmc6BUGFOWIcc72A3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3198
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/4/22 8:06 AM, Borislav Petkov wrote:
> On Thu, Mar 03, 2022 at 10:47:20AM -0600, Brijesh Singh wrote:
>> I did not fail on !req.cert_len, because my read of the GHCB spec says that
>> additional data (certificate blob) is optional. A user could call
>> SNP_GET_EXT_REPORT without asking for the extended certificate. In this
>> case, SNP_GET_EXT_REPORT == SNP_GET_REPORT.
>>
>> Text from the GHCB spec section 4.1.8
>> ---------------
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.amd.com%2Fwp-content%2Fresources%2F56421.pdf&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C10f73f9bd6524f9f9c4e08d9fde843d5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637819996563585169%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=GS3iyUCAOmaPuxN4sRi%2B%2FFTsRGF7QC1jISc%2B25c4XtY%3D&amp;reserved=0
>>
>> The SNP Extended Guest Request NAE event is very similar to the SNP Guest
>> Request NAE event. The difference is related to the additional data that can
>> be returned based on the guest request. Any SNP Guest Request that does not
>> support returning additional data must execute as if invoked as an SNP Guest
>> Request.
>> --------------
> Sorry, it is still not clear to me how
>
> "without asking for the extended certificate" == !req.certs_len
>
> That's not explained in the help text either. And ->certs_len is part of
> the input structure but nowhere does it say that when that thing is 0,
> the request will be downgraded to a SNP_GET_REPORT.

The decision to downgrade will be done by the hypervisor. See the GHCB
spec (page 36), if RBX (aka number of certificate data pages) is zero
then section SNP_GET_EXT_REQUEST section (4.1.8) say that hypervisor
must treat it as SNP_GET_REQUEST.


>
> How is the user of this supposed to know?

Depending on which ioctl user want to use for querying the attestation
report, she need to look at the SNP/GHCB specification for more details.
The blob contains header that application need to parse to get to the
actual certificate. The header is defined in the spec. From kernel
driver point-of-view, all these are opaque data.


>
> And regardless, you can still streamline the code as in the example I
> gave so that it is clear which values are checked and for which does the
> request get failed...

Will do.

thanks