Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc048c18-0ba7-1cb9-90a0-0bc049997c23@kernel.org>
Date:   Fri, 4 Mar 2022 16:37:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] tracing/osnoise: Force quiescent states while tracing
Content-Language: en-US
To:     Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        mtosatti@redhat.com, paulmck@kernel.org, rostedt@goodmis.org,
        Juri Lelli <juri.lelli@redhat.com>
References: <20220228141423.259691-1-nsaenzju@redhat.com>
 <78d798aa-388c-70bc-4227-985ba76c1d7e@kernel.org>
 <b5e1f0d14a48c0815863af623cedbdc8c1bc255f.camel@redhat.com>
 <abb789c3-0d1a-28e9-3b8d-e4a68e3f57f5@kernel.org>
 <2b47679c6248a0d113b556ed6118e8ed72c74b29.camel@redhat.com>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <2b47679c6248a0d113b556ed6118e8ed72c74b29.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/4/22 16:28, Nicolas Saenz Julienne wrote:
> Some comments:
>  - You're not exiting/entering EQS on IRQ/NMI entry/exit. See
>    irqentry_{enter,exit}() and irqentry_nmi_{enter,exit}().

hummm, right!

>  - See this series[1], if we ever pursue this approach, it's important we got
>    through context tracking, instead of poking at RCU directly.

I had a test patch with context_tracking as well... entering and leaving using
it. Lemme find it.... but it basically works in the same way as for RCU (or
pretend to work).

> 
> [1] https://lore.kernel.org/lkml/20220302154810.42308-1-frederic@kernel.org/T/#t