Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2039393pxm; Fri, 4 Mar 2022 08:17:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJw53UABH95q2EKYKvViGHwEAzm3TngugAyIw3/kMz5b/u4v8E3N7F4R8SuXc5OcLT4rEACp X-Received: by 2002:a63:8648:0:b0:37c:8fc8:ae4 with SMTP id x69-20020a638648000000b0037c8fc80ae4mr4293828pgd.482.1646410669990; Fri, 04 Mar 2022 08:17:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646410669; cv=none; d=google.com; s=arc-20160816; b=V3r9gY56Zc3wZtqexDESmQ4SzMfCxPXRHDVzJfOeA6kD0IX6hgtXlohjQgMBvhWuzg AduwGICSkDJn8pG401q8R927xgLHt0XR3Qm0WMSO+QDTN1pptxDoiNnXmgz9vaJ0u5TE AvG+6h+80YYAIcDZgB0K5Q3MXLdzc8yZDye4LDJUL91twYoTxlJV5CwLuXXR2Qq+3tX8 O5/4pCNDiTJfWRNAN6IMBaQRFI6E0dtpCs2sN/G1/5NZtUYlMT9cyEvqw14+feDQ7Vpc Z2WB+YRUMJbdqD19a2PTbYHsp7rEeohoGCdO9hcmaI7krmwfsUolZckiH+vDJHAtIo0D xR6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QWEErRiRWN1/TNCzeHf5WfEfHdlTZ8X8iK6zXZlSBlM=; b=AmHA7iXCeDozRry6ak2pmZIUn6AEzyjjjYIepZTS4bY+QuSlN3zHO/E3BTOTRXEIBi g+e2CSIl+joqkVnaJGgOpnpK9iv8HTSRlECOVPxQ2EMLglsAZu3PHuQbsSsa/4ZMM9FP zlWbRU2Yam7qg7yDf5KaHWnTvjM7sYLDeY9+EHNv1onzbBMYIdFSkgXDz8zjojhxTqFX CpEkkCpUg6MBR7Flj8Ztmjj/Jzz+eD8/ajd+Sj29Zp6f4fceobuCdF/sobDvBqFKXLxr C+OlxsLUwtcAGS2mPHmwOT+TapvgbCbdqoQBD31VdA1+6D5M+xtN0E0q+g+gQ5g4dFBL Qa0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=kBi4q7QO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k185-20020a6384c2000000b0037c68d441dasi3992811pgd.192.2022.03.04.08.17.32; Fri, 04 Mar 2022 08:17:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=kBi4q7QO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239142AbiCDKCF (ORCPT + 99 others); Fri, 4 Mar 2022 05:02:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236543AbiCDKCE (ORCPT ); Fri, 4 Mar 2022 05:02:04 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6189E199E18 for ; Fri, 4 Mar 2022 02:01:17 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2247b5Ct008062; Fri, 4 Mar 2022 04:00:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=QWEErRiRWN1/TNCzeHf5WfEfHdlTZ8X8iK6zXZlSBlM=; b=kBi4q7QOyrZYtE4asa+JrOP/uCGNM4996vND6b7BSAcxnLmLBJLanx5ea97ZmPQW9ODM dGd3jX2y++2Djd4x8vFmOtQtqvEa6NDbjjkR1cGNJCR6VYyeIBOzjVjVpgp9W/9Q0jYV 7ZhccuNs1qSNC2c7EP7VfQnIx2xZB1/8i+g5zncR4A3RozxaMKn54idDOUpgIZx3UU7l WzECScygZeOTL+kJdd/q0h+aVYM9sMNIRWZyakLYOSUd+1nHh3mmvaSMygywkgy2CM2S 7G0wpX/k4adIDWO3pDxyUkxu5rxG/axg3kvy0rNVx/EP34ymeAzQMHAzh5Q4wQo7y0UM 8w== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3ek4j1rs2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 04 Mar 2022 04:00:29 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 4 Mar 2022 10:00:27 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.18 via Frontend Transport; Fri, 4 Mar 2022 10:00:27 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 6675A7C; Fri, 4 Mar 2022 10:00:27 +0000 (UTC) Date: Fri, 4 Mar 2022 10:00:27 +0000 From: Charles Keepax To: Jiasheng Jiang CC: , , , , , , Subject: Re: [PATCH v2] ASoC: wm8350: Handle error for wm8350_register_irq Message-ID: <20220304100027.GV38351@ediswmail.ad.cirrus.com> References: <20220304023821.391936-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220304023821.391936-1-jiasheng@iscas.ac.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: 2KrBtTRaR9Ej1GARveBYJN7a8ldIOiBw X-Proofpoint-ORIG-GUID: 2KrBtTRaR9Ej1GARveBYJN7a8ldIOiBw X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 04, 2022 at 10:38:21AM +0800, Jiasheng Jiang wrote: > As the potential failure of the wm8350_register_irq(), > it should be better to check it and return error if fails. > Also, use 'free_' in order to avoid the same code. > > Fixes: a6ba2b2dabb5 ("ASoC: Implement WM8350 headphone jack detection") > Signed-off-by: Jiasheng Jiang > --- Acked-by: Charles Keepax Thanks, Charles