Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2100293pxm; Fri, 4 Mar 2022 09:22:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnCxxVU+iFZG5H5wmG9lb7R0NAy8XJhXosED0e/vPzRMrq5rO+jjLpfODj6luRUOmSO//J X-Received: by 2002:a17:906:3e90:b0:6b6:829b:577c with SMTP id a16-20020a1709063e9000b006b6829b577cmr33469781ejj.711.1646414524198; Fri, 04 Mar 2022 09:22:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646414524; cv=none; d=google.com; s=arc-20160816; b=OrOBOL+KmAqTOQm9WwYxLImLh7sbnrQBNyeepNWnCOqgb4kPcnLjgTTRNrQbz5XNLy Q33YRjhYMiPTaHuZBzdnCu2RmL2SyLKMPDXMK6+NR3jp+zpK51m6KC3TsbpV2RN/hUos GoPBB1woVmRxVYzWWSmTsGv1+ZJOKdgyO4D7iQccdB6ak/jKvLDtoOf+vPaAT38eiKUQ GWSaTEAOi5ZGifgQJkXP/8+vQePB8Ptd5CKrVhMVD8uBFp35Ut8CaFqU6eXIY35cNoap 9fgLqH8Mw2bvr04PKr8UPc9rMpYIhY+7U9+25i//clJt8yAFj5VxBO7e0/QYUN40exuL OiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=fQnxl0eqs4bZW5zPw9qVTxkPmfJfmM4RO01wXd5QUQQ=; b=MLCzeConWu9y9zh35bnUzYHgt182DP9Eg81HIgliqPca3SH72mA7kMyTJ+98ZfhBZM vQDRBOcZePFLXRaNluVVYQC13N1BVnwJSDVz+IWLQjdJYAxg4iJ9OuRQ+3eLhrce7zdr mmXB/upZG+DjSbmlJNPcB/zOrLerLWtTDqgv/amePVF1jEPyrwQg0PRubgNUsGLp2S5X iFwalxjEm+QKJ2f1RjsoPobfPOUrk4OAADXUPupK0c/oyId+fRavByHsFoKAznBo18U9 stqDx8/UjD3NfDSPCQFV5fWK2lmSm5Wgh/XS5wtiEcK3yz6RK9g5OKNiGtR2j5EmEDKH eQVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=EF2IE8a9; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="/IUqc6Bh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb20-20020a1709077e9400b006da8f2ab6c5si3503350ejc.937.2022.03.04.09.21.40; Fri, 04 Mar 2022 09:22:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=EF2IE8a9; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="/IUqc6Bh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238586AbiCDPjj (ORCPT + 99 others); Fri, 4 Mar 2022 10:39:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232483AbiCDPji (ORCPT ); Fri, 4 Mar 2022 10:39:38 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B6E47065; Fri, 4 Mar 2022 07:38:49 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C76D921124; Fri, 4 Mar 2022 15:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646408327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQnxl0eqs4bZW5zPw9qVTxkPmfJfmM4RO01wXd5QUQQ=; b=EF2IE8a9r/nl6g8fM+ZC95CZCxjVmOxMilo6b1d/slFk5tHxyhxh5aM7OgeRJy4o8I82la punlcJSNBD4zqXIj5f/6A47Rx0cNzuZEDztXtQmzJguqISeENc8yZVXa9IxRRuUa5G4gV8 QhNX08P/btaAwJfi7FvptAYUa+GpCfY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646408327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQnxl0eqs4bZW5zPw9qVTxkPmfJfmM4RO01wXd5QUQQ=; b=/IUqc6BhQy0N2yctMiiIV7VHLvt7EftsqxKvWCPSBWMDQdv1vETb6L5/e2BpzV/bj5h9SA QtdtgWvhudTSh3Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B8C3B13B64; Fri, 4 Mar 2022 15:38:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JOwDLYcyImLCMwAAMHmgww (envelope-from ); Fri, 04 Mar 2022 15:38:47 +0000 Date: Fri, 4 Mar 2022 16:38:47 +0100 From: Daniel Wagner To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke Subject: Re: [PATCH 1/2] block: remove commented out code from diskstats_show Message-ID: <20220304153847.bannj7cgo4z7vonl@carbon.lan> References: <20220120105248.117025-1-dwagner@suse.de> <20220120105248.117025-2-dwagner@suse.de> <83b281e5-16c2-d659-172d-3a2c911c7ff0@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83b281e5-16c2-d659-172d-3a2c911c7ff0@suse.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 20, 2022 at 12:02:49PM +0100, Hannes Reinecke wrote: > On 1/20/22 11:52 AM, Daniel Wagner wrote: > > The diskstats format is ABI, so we just can't add a new header. The > > code snippet has been commented out since at least v2.6.12-rc2. > > Remove it. > > > Reviewed-by: Hannes Reinecke Any change to queue this patch up?