Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Mar 2022 14:28:40 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Xin Ji <xji@analogixsemi.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support
Message-ID: <YiIF+PpuIeJMY+/T@kuha.fi.intel.com>
References: <20220223102353.3833578-1-xji@analogixsemi.com>
 <20220223102353.3833578-2-xji@analogixsemi.com>
 <Yh9dBlrWm3OicQWa@kuha.fi.intel.com>
 <20220303024757.GA4159259@anxtwsw-Precision-3640-Tower>
 <YiC+/ccRvR/+mAkT@kuha.fi.intel.com>
 <20220304022936.GA4164495@anxtwsw-Precision-3640-Tower>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220304022936.GA4164495@anxtwsw-Precision-3640-Tower>
Precedence: bulk

On Fri, Mar 04, 2022 at 10:29:36AM +0800, Xin Ji wrote:
> On Thu, Mar 03, 2022 at 03:13:33PM +0200, Heikki Krogerus wrote:
> > On Thu, Mar 03, 2022 at 10:47:57AM +0800, Xin Ji wrote:
> > > On Wed, Mar 02, 2022 at 02:03:18PM +0200, Heikki Krogerus wrote:
> > > > Hi,
> > > > 
> > > > This does not apply on top of Greg's latest usb-next branch. You need
> > > > to rebase this. There are also a few more nitpicks below.
> > > 
> > > Hi, I didn't found tcpci.h in include/linux/usb/
> > 
> > I'm asking you to create the file.
> > 
> > So create a separate patch where you move the register definitions and
> > command definitions from drivers/usb/typec/tcpm/tcpci.h to
> > include/linux/usb/tcpci.h
> Hi heikki, I'm confused, do you mean move total tcpci.h to
> include/linux/usb/ directory or just move our driver patch used register
> definitions and command to "include/linux/usb/tcpci.h"?
> 
> And I think the other way is, our driver patch just include
> "tcpm/tcpci.h" is better(no need to create new file). What do you think?

I would prefer that you just introduce the global header for them.

thanks,

-- 
heikki