Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <34833549a995fa3325f4ceb9b42cd01de0921c14.camel@redhat.com>
Subject: Re: [PATCH] tracing/osnoise: Force quiescent states while tracing
From:   Nicolas Saenz Julienne <nsaenzju@redhat.com>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        mtosatti@redhat.com, paulmck@kernel.org, rostedt@goodmis.org,
        Juri Lelli <juri.lelli@redhat.com>
Date:   Fri, 04 Mar 2022 16:55:06 +0100
In-Reply-To: <bc048c18-0ba7-1cb9-90a0-0bc049997c23@kernel.org>
References: <20220228141423.259691-1-nsaenzju@redhat.com>
         <78d798aa-388c-70bc-4227-985ba76c1d7e@kernel.org>
         <b5e1f0d14a48c0815863af623cedbdc8c1bc255f.camel@redhat.com>
         <abb789c3-0d1a-28e9-3b8d-e4a68e3f57f5@kernel.org>
         <2b47679c6248a0d113b556ed6118e8ed72c74b29.camel@redhat.com>
         <bc048c18-0ba7-1cb9-90a0-0bc049997c23@kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2022-03-04 at 16:37 +0100, Daniel Bristot de Oliveira wrote:
> On 3/4/22 16:28, Nicolas Saenz Julienne wrote:
> > Some comments:
> >  - You're not exiting/entering EQS on IRQ/NMI entry/exit. See
> >    irqentry_{enter,exit}() and irqentry_nmi_{enter,exit}().
> 
> hummm, right!
> 
> >  - See this series[1], if we ever pursue this approach, it's important we got
> >    through context tracking, instead of poking at RCU directly.
> 
> I had a test patch with context_tracking as well... entering and leaving using
> it. Lemme find it.... but it basically works in the same way as for RCU (or
> pretend to work).

Yes, agree, it's fundamentally the same.

-- 
Nicolás Sáenz