Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9e940637-1381-f51c-afef-9c78d463ace1@fb.com>
Date:   Fri, 4 Mar 2022 08:07:21 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH bpf-next v2] bpf: Replace strncpy() with strscpy()
Content-Language: en-US
To:     Yuntao Wang <ytcoode@gmail.com>
Cc:     andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
        daniel@iogearbox.net, john.fastabend@gmail.com, kafai@fb.com,
        kpsingh@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, songliubraving@fb.com
References: <e1e060a0-898f-1969-abec-ca01c2eb2049@fb.com>
 <20220304070408.233658-1-ytcoode@gmail.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220304070408.233658-1-ytcoode@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U09PSXZONVk3dTdxQi9PYXZuaUN5TVlXaklTcno0QnMyamlTb1RvYXl6U0NH?=
 =?utf-8?B?MThLK1RyNGtmSnZJYlZuRkVHMmIxNi83clVGL21tQ0ZRd1hJcG1Ob3ZUaDEz?=
 =?utf-8?B?bXBWRmtlWW1vNlIrVG9aUnArQU9GelNzd0JxOFNpR21iOG1rSFpKOVBBOXds?=
 =?utf-8?B?QngrTWNjWGxQZ0cxRlBWVEFXMWxsM3QrOTFBeXVmQjNxUzQvalplZzRJckhO?=
 =?utf-8?B?OWdCbTNvY1dPMTFEZUppaUo3aUlCaklKcnprM2NadlUzNHVNdEZDdlEzN3Uy?=
 =?utf-8?B?d2FieDNxVUx2NW9sVThRV3BIK2NPTDVleUtJL0t4RXdEU2oxeGlTeVRxUVh4?=
 =?utf-8?B?SGxpblh3eG83Sy9uNVZaRXBrM3NGYm02UTVUVHdXQkkwd2ZNamNZS05lc2FS?=
 =?utf-8?B?cGxEMjYzWE9PZGUvQUkvaC9Ed3VOWDNITXBvL2ZDbEwvczhpMEhkbW9tTzRS?=
 =?utf-8?B?azIzV2hzOE9BaVZzVkxiR1ZqNXdPK1hrcXl6NVB4TjZ0OThDbytkN3UzTGdp?=
 =?utf-8?B?cDJwWlVlZkxpd1UrM3pDSWNQWE92WVZMa0hKZENEVVZjV1VQRCtGYlh5S3Jp?=
 =?utf-8?B?U2ZrcWRxUjduNVlUckJLdDNGTjdlaFVLL1lWY29tZFNqQ25veTVTVGI5dXhi?=
 =?utf-8?B?K094djd1Szd5Z3R6SndyME5UZ0w3N0NTZ0hCdUNxcFZ4ZTk4TnlNeFRYcHRM?=
 =?utf-8?B?NHNtRUdSMEJJbDNLMlY1K0lhdXRZemhUTStWeFpWQnJMNUcvSFZBeDhaV2c2?=
 =?utf-8?B?WVlUcldDdXJBMFlxeG1wTXptL2t2RFA3U3NvUGZTSDZienFVSG9ad1diTkRG?=
 =?utf-8?B?Q3pNNzY1T3BtdkxQMmd1Q1ZOTXdEckdTU1JKUzNlQjd1dm1ZQXJMSm9YZW16?=
 =?utf-8?B?NXVzd1JuRWhFR0tVQjRnZWtlVWNHZU1YY2Z6Sk53RG9BbEFMTldRZHhtd1Rt?=
 =?utf-8?B?cnBCNldCSnVzY1NCOFh3MUVaa2J1VjZ4eEhMb096TzluZkp6VHEzWmI4bVJ1?=
 =?utf-8?B?MWxRb0lacTBHbU4vcW53bktDdG40V2M1WEtKS3g2RUViQXNlaDY5ejNLLzg1?=
 =?utf-8?B?WUVxekN0Z3h1Y3BVZUZyREpKWkZtM2VhaWJOUCszMlNycHRBWisxckRzTWFH?=
 =?utf-8?B?VzdnRFpaeC9tY0NocU55dGVNYUhxTExKbUx1bkFSb2pSMU5SeDZDTWRDN2lE?=
 =?utf-8?B?VnRCaEduaFdTb2tqQTBzN0dQbFd3Yys4RndGa2diZXJSVk1XQkVIVEE4TURK?=
 =?utf-8?B?elV3N2Fubm5DV05UaTJsSnp3SVpiOFVqaURGTVV1ellZQWdSZjdjNUVBcWhX?=
 =?utf-8?B?aDUrWGo3clJrSFpKU2dFY0NWcWt6MXdZYkYxcHdKZjB4VG10UThsVEhWUkpL?=
 =?utf-8?B?SXdhQzRPTWlXTVd5bklZV1BGQkZNdUxuK1l4N1p2RS9kZCtzekt1eTE4YXNk?=
 =?utf-8?B?b0pKTk9tRTEzTlZLQ0NRVThhTnJBVFZDRWZnZDE5eFhBempiL2QyVzdWOVdS?=
 =?utf-8?B?Zlp0Q2NlSFlWV2h4MjJlVi9QYmhaTDRPcTU2TjRxemNpTjgzMWRFZ2xxWHd4?=
 =?utf-8?B?R085cnNEUWtneDR4OHlyVHI0YWlHWUdRQjZSU053OWEvVkt6ZlJWd1NiRWR6?=
 =?utf-8?B?NWdEOGxKc3YvV1dFQ1B1VkhEQm1HNldWM3hTSjVidXBUTHJvd0RlNWdWL2xR?=
 =?utf-8?B?bnNKOGUvWnYvK2daYkNSdU5BTHBhRW9weU1ORWo3QVRjNGk3UHI5dmZTeUhN?=
 =?utf-8?B?WXVXQWtzd0ZsOEp3dTlCWFV2eHlXdE1LZmZ1Rmt2dXRmd004L3lTQWtOd3d3?=
 =?utf-8?B?d3FGbERxTldpeUd4YktjLzY2eGNHMTI2dW9LZmlTQ21jVHA5em1JS0ZEYVpo?=
 =?utf-8?B?MmJlNStwZGxUa01WSkZaWWlzamtCQk1nZFRIOEN5aW0zbmFiSU9kUE9uZnJY?=
 =?utf-8?B?OXR6TnBMdncxVi9sb05KLzRNM1FGaSs5amZVWmVOUCtsd0tNVVRQSUhTTmFQ?=
 =?utf-8?B?ZVhjZ1BzNW1IL29MZmpqNXlmM2JtbkY3b3BHcmlUUWFjSDQ3aW5nbVBodjJN?=
 =?utf-8?B?enpYY3B2aVk1SUgwNjZLMWJwcVV2dGtGRjFtZUJ6RFJKNzNna1Q5WGdncUZ3?=
 =?utf-8?Q?t3BEer7oiNo1U3MKlY9DTmSaI?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd16590-c1c9-4762-b7f1-08d9fdf912cf
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 16:07:25.5641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N6d4JdHP3F11BP8uKzd/rDL4tTFWjI6iFVUCPLuziN8frNpct1FY38BsLHoDidUR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1554
X-Proofpoint-ORIG-GUID: IsHM_Krlf66cr5594AuAmNRF2dFTgpvM
X-Proofpoint-GUID: IsHM_Krlf66cr5594AuAmNRF2dFTgpvM
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-03-04_07,2022-03-04_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 mlxlogscore=507
 spamscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0
 adultscore=0 clxscore=1015 mlxscore=0 bulkscore=0 suspectscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203040083
X-FB-Internal: deliver
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/3/22 11:04 PM, Yuntao Wang wrote:
> Using strncpy() on NUL-terminated strings is considered deprecated[1].
> Moreover, if the length of 'task->comm' is less than the destination buffer
> size, strncpy() will NUL-pad the destination buffer, which is a needless
> performance penalty.
> 
> Replacing strncpy() with strscpy() fixes all these issues.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
> 
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>